Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 11:21:03 +0200
From:   Simon Horman <simon.horman@corigine.com>
To:     Justin Stitt <justinstitt@google.com>
Cc:     "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Tom Rix <trix@redhat.com>, Fei Qin <fei.qin@corigine.com>,
        Yu Xiao <yu.xiao@corigine.com>,
        Yinjun Zhang <yinjun.zhang@corigine.com>,
        Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
        Leon Romanovsky <leon@kernel.org>, oss-drivers@corigine.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        llvm@lists.linux.dev
Subject: Re: [PATCH] nfp: fix clang -Wformat warnings
Message-ID: <Ys08/1BjtahTIIvJ@corigine.com>
References: <20220712000152.2292031-1-justinstitt@google.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220712000152.2292031-1-justinstitt@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yl94m2deNnUWPJJOiDWTLgk4v+uRRRh0EbmoPl7p/pHNqN5PNalzG+7D+Nvl?=
 =?us-ascii?Q?6RMjzOAGItwfT8z36m+zkpTax9FpoWtxfBYJP9foH0a3xmxFMgCzEptYd9Iq?=
 =?us-ascii?Q?Nv1+XC3GLBk4jcqYsp17jHBZ2f3lSTXuNxpSe3bzExT2KFoPUzX9U0TMqSpo?=
 =?us-ascii?Q?QYS2CkmHVNDMbZSRWPi4GaBmzJ3aWMSeO2NfSEEt5TMiJjIFEvBMkeBavWwF?=
 =?us-ascii?Q?FVozgoAOqUB+yrhu4tTb5yx3zDN/LB5YUyyW+PvlSEmCE1nDCekF1+boOt2p?=
 =?us-ascii?Q?Ge0Oe5Bj4rFu6abzFyThKbG2DJ/doxPUVI6SNodPXfu1rtx6uLgWXrsDILLB?=
 =?us-ascii?Q?9FFMb1HKbJAMa81M9CcU45zTYqbJ3TPq2PJZia7syCdOLGr5QyKx1I3jT1AA?=
 =?us-ascii?Q?GtkuOZgiVMDhc1QtUuShpQ4GIb6ji2w7zbOEInVPTNLXK0T08mtfJRbpSSdY?=
 =?us-ascii?Q?qtO6OpVhpZ4l67cJSzRK47Bn1qZfWOvNBEoiatIhpq0xD2h8GU8NHKrHFdDm?=
 =?us-ascii?Q?NObgXVVY/xwJVEtnl6jHEXRm7te475lcg2OrUoQSnEfEugo7lkrTBhbuzv+B?=
 =?us-ascii?Q?4++t1BpOq9KkBqdEVo0DHlhfgC84JQ1jo44DClWQ67amWd/nWQkx0mzfqZzo?=
 =?us-ascii?Q?DrWschVmLSiD6X2jllj26PSf1j2hVRUsoZvoOZCFZ8bMzczcTfoDYf7KHA1s?=
 =?us-ascii?Q?1BJl8IcpDnq6GgZGDZFH/hdyETsUg+Ifom+RQcR1cY5rFim/FRNTnQq5vYo7?=
 =?us-ascii?Q?Trx9qIL3kt1Nuoejbh06N0yK6UdFG2rBnuyF40eDR1gSGb+cSy2gVATAXQ2Z?=
 =?us-ascii?Q?HR3Q9rAjZnFRlSdJ+v51Q+JftBZ+PfLnfcw49jl5Rirg0WXQ4qYj7VzucHhF?=
 =?us-ascii?Q?eLqpHgilPTxvDq6TZOlzwo34hpP4OfhoRfFAJqvWv+9AD5vY+tkXWalGFdvs?=
 =?us-ascii?Q?85OeeS0NYWusxcibcI58RWj0IrTztIA/kqvX3LXKCMA4grFQZ9/Uk+43FKDX?=
 =?us-ascii?Q?DkeINd1Ye1KLYvVk8+WwhQYIwjs0LF64ReTrj+hCLLnakFBBWod2edwQotjQ?=
 =?us-ascii?Q?STaZDnhmPongph9zdDFrasaZve0i+zAiKVMEepHprxq3C576M/Pd+m0v7aDl?=
 =?us-ascii?Q?Q8IGX70WSqq0mnn1BUeq6Mwj6H+bkJapP1cm1sdh9PFE7j4XoSruOX3xXWj+?=
 =?us-ascii?Q?A+tV5Gr50nVUt7ektvPpfsRAZvMuoGAlBGQtgFCgKbO1KZoSAu9QPgVdJMhZ?=
 =?us-ascii?Q?Y1JACXcWTyGFEbhdyHkcBTmpcmp6BirqVG3oRr0m27vm7Yhc89hThh4ICaxE?=
 =?us-ascii?Q?IRS5GJw6OzD0fmZjkWEOcfXOEX+SCIETqdmJXvXmQy6bSUg7oTKHRa8Z9Dxw?=
 =?us-ascii?Q?IFs0TRKaf3azTQZ3j5vWWLxhrisGMxBYynAOOoRj0SILziCYfI4g013toD2k?=
 =?us-ascii?Q?3XrOnV6+4isUyFOHFW2z6kBg4DOwcfPY2YK4Z4af+4aE2vi/RKbe0bH9q/jh?=
 =?us-ascii?Q?skp4/T0tHjVvFOL0ZTJYyJ8iiJ0IhNq1G5PuvbnCA4oU3imqJMPkkwHVOH1B?=
 =?us-ascii?Q?VFQAb8NPpAfPLPccUpFvVUVK1XKcCgsiM5YNumzjC9Al4cx3Iw6Qu7hyoiay?=
 =?us-ascii?Q?IUfzv4zclVLSB2zD2V4KYSQkRv4+74YvBg313yAtzvLhSbhh3fBWWOSxzhJB?=
 =?us-ascii?Q?0lR8IQ=3D=3D?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 942dc8a9-5b88-40cd-63c7-08da63e7dbb4
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 09:21:10.2380
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gxdfDBOg/0ukukGGzRa75XeWapw9ugcOCyb/HSrwtihMXN9IqfeHFOQ1R6FDkRvcukEKpmWRBpjS+erpNGT3HZpOEO0/6mlHW65VT17NCRc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3700
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Jul 11, 2022 at 05:01:52PM -0700, Justin Stitt wrote:
> When building with Clang we encounter these warnings:
> | drivers/net/ethernet/netronome/nfp/nfp_app.c:233:99: error: format
> | specifies type 'unsigned char' but the argument has underlying type
> | 'unsigned int' [-Werror,-Wformat] nfp_err(pf->cpp, "unknown FW app ID
> | 0x%02hhx, driver too old or support for FW not built in\n", id);
> -
> | drivers/net/ethernet/netronome/nfp/nfp_main.c:396:11: error: format
> | specifies type 'unsigned char' but the argument has type 'int'
> | [-Werror,-Wformat] serial, interface >> 8, interface & 0xff);
> 
> Correct format specifier for `id` is `%x` since the default type for the
> `nfp_app_id` enum is `unsigned int`. The second warning is also solved
> by using the `%x` format specifier as the expressions involving
> `interface` are implicity promoted to integers (%x is used to maintain
> hexadecimal representation).
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/378
> Signed-off-by: Justin Stitt <justinstitt@google.com>

Thanks for improving the nfp driver.

Reviewed-by: Simon Horman <simon.horman@corigine.com>