Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 11:57:48 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Rao Shoaib <rao.shoaib@oracle.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org
Subject: net/unix/af_unix.c:2471 manage_oob() warn: returning freed memory
 'skb'
Message-ID: <202207090117.Ub3gbT5M-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?T2bCGLYv0WXXD5X54xt172SKBlqdgB0FAvoXy/U9ditNB35bQZNeSA8TM7SG?=
 =?us-ascii?Q?iCUQ6ZSNArjOhpAmkiteng14LOEt3MFjwyT3FqaX0qZwgWeIUVtbNu8RgHQZ?=
 =?us-ascii?Q?x5iXrXkkaFboWykMY8SaahXgn5FBhvZBxSzD3Iq9YTGIva4HiOehkr+oZTCL?=
 =?us-ascii?Q?XH4loa5bqcdsHh+I4eLBum6uQ7w2ItII0OgdCFFP47as48OsZsGjMigx2Ebu?=
 =?us-ascii?Q?rYmOWvZWJFCIvKNCtEirimF43v4ngRiGoEvtHRtNhKmynH8ED9U689GSkPmJ?=
 =?us-ascii?Q?W528cjTExKSAUSX+Lng5tIMMLZ6mMcu1JvxEU7Vv1yP3u1K92VQLTs+zJGaD?=
 =?us-ascii?Q?qYiyhsyGTWuPXfTm7hz0iypFzMaF/CdE1KAt2wfKoOzz2u/vKWUTixHke9xP?=
 =?us-ascii?Q?5fd1cMH/wbu+nD6d2kRTAu92K4wK8e99jfOFZylh3Z1nqya9x7tMK4ZGckCh?=
 =?us-ascii?Q?VmioXwA7xvVnRc7bNDUL2bK3bdPE53K68yX1fSXvAyVU+IRFhuKcWDEVYFGT?=
 =?us-ascii?Q?gggYkJR1ZfuUiO9oKyQ3Mf0nljMHBX3sW51v+F9a9IHg5q0YeGIsbC27aLn6?=
 =?us-ascii?Q?hhppQjSOmMAewVHVgGrzgH11hXrPsTpYff+odrsxwmr2CfzDqX3PD9lgSxn0?=
 =?us-ascii?Q?xJjcdvYPOLDh4+BglnjY3qUulQq/NaqIOuIRU02Y9eT2I/p+9jPg7onJ9HsZ?=
 =?us-ascii?Q?AChicLe4h8R+emmMBjClkJ0Q4S5+X1WKS3mxBWX/y2pKwu3wQd5PSP91X7SG?=
 =?us-ascii?Q?ydn+yFnq/VQE08zeGM31TJmqkQZP1ucl/HW1JL2DReEkJ5Gl/70wUNM6ACKd?=
 =?us-ascii?Q?P6HPKDpX3lYPp2gvP7/m0BoN50mCJ7Ug1lIIeW1XQwzoDSyxdBTk1iZUyX5z?=
 =?us-ascii?Q?O7nKMhMNgX3o49d6DqLcIrGxypy4GFRyDTDjq9aYXcezPDkPmjY8muYfYtUC?=
 =?us-ascii?Q?WJ9nWdu+kKFLsIWp2mBhz2Hww2T5KHUGa2ORL+ap8PkosGlGsP/tw4tNqqAL?=
 =?us-ascii?Q?DPqe1R2nFCBGaw/GgHGkaN/KKBouxMETNIPukNcAx7EVO5mpCz6nuvW1L1QX?=
 =?us-ascii?Q?kjvO2ZLkPNY1pd+GacaEzUTX2fOUyi8mbcuRbFKy9XAythTojYFiQycyFQn0?=
 =?us-ascii?Q?3fl7iJDyG8o18K1MyA8bxz7LEyHAtohb+yFiU+7pJj2XPxxi3ZtIn+8GhmXt?=
 =?us-ascii?Q?IPvI4sPrwDDalJVJZ5H/RsAzbv4u1rOjeN2KAwPhcuURdDUb1pdGx/rucWRe?=
 =?us-ascii?Q?/CKx5xdeZCV8ZAirXMgqFe1NJbxo6rxPSse+ZBIAnj7BWN4GL0QNPM47ckZk?=
 =?us-ascii?Q?aUL2rrPB7+Cpoqa9KBvUWiX+aP2q4/ASKchDGP+oLZL/R965lNOhhRbcuDHb?=
 =?us-ascii?Q?BuKuS75zVydFRdqgQ6sLgN3gJWYzLPqTLqWXxdw8I+DBeSxYvDPvYfGqlknm?=
 =?us-ascii?Q?CSlrVGulPtEjGNGBLy7+7gwzpHiknmrmmSDfvpDMbzZx63TtVSyKmEpk7Pqe?=
 =?us-ascii?Q?+gq3UCObdUJjtSNbukhC2HqdTciTR+wdiCrB4PYX/r0MFkgbKLwj1oOTUG6g?=
 =?us-ascii?Q?T7Zi7yscX4byQgq7yEKi0/JGuWCokLAuvZmneCpd1mkjiLBMY8IMSjL+LVuT?=
 =?us-ascii?Q?Iw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca9e4285-9e2f-477b-fc4c-08da63e49e3a
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 08:57:58.7361
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aWCd/erIKXcf/p5uLhJbeM3I+hk+CU52wGVK2yFGiYT8EMdX5qYjs/G3ULedX7MbE23Gv3rLSse05u6SF2GzkTKvMtlg5NiW+NibB1JRyUo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5754
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-12_05:2022-07-08,2022-07-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 malwarescore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207120034
X-Proofpoint-GUID: WMx2lXq2QHomLgb2OK5KF_FZtJRLm-Dv
X-Proofpoint-ORIG-GUID: WMx2lXq2QHomLgb2OK5KF_FZtJRLm-Dv
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   e8a4e1c1bb697b1d9fc48f0e56dc0f50bc024bee
commit: 314001f0bf927015e459c9d387d62a231fe93af3 af_unix: Add OOB support
config: m68k-randconfig-m031-20220708 (https://download.01.org/0day-ci/archive/20220709/202207090117.Ub3gbT5M-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
net/unix/af_unix.c:2471 manage_oob() warn: returning freed memory 'skb'

vim +/skb +2471 net/unix/af_unix.c

314001f0bf9270 Rao Shoaib 2021-08-01  2446  static struct sk_buff *manage_oob(struct sk_buff *skb, struct sock *sk,
314001f0bf9270 Rao Shoaib 2021-08-01  2447  				  int flags, int copied)
314001f0bf9270 Rao Shoaib 2021-08-01  2448  {
314001f0bf9270 Rao Shoaib 2021-08-01  2449  	struct unix_sock *u = unix_sk(sk);
314001f0bf9270 Rao Shoaib 2021-08-01  2450  
314001f0bf9270 Rao Shoaib 2021-08-01  2451  	if (!unix_skb_len(skb) && !(flags & MSG_PEEK)) {
314001f0bf9270 Rao Shoaib 2021-08-01  2452  		skb_unlink(skb, &sk->sk_receive_queue);
314001f0bf9270 Rao Shoaib 2021-08-01  2453  		consume_skb(skb);
314001f0bf9270 Rao Shoaib 2021-08-01  2454  		skb = NULL;
314001f0bf9270 Rao Shoaib 2021-08-01  2455  	} else {
314001f0bf9270 Rao Shoaib 2021-08-01  2456  		if (skb == u->oob_skb) {
314001f0bf9270 Rao Shoaib 2021-08-01  2457  			if (copied) {
314001f0bf9270 Rao Shoaib 2021-08-01  2458  				skb = NULL;
314001f0bf9270 Rao Shoaib 2021-08-01  2459  			} else if (sock_flag(sk, SOCK_URGINLINE)) {
314001f0bf9270 Rao Shoaib 2021-08-01  2460  				if (!(flags & MSG_PEEK)) {
314001f0bf9270 Rao Shoaib 2021-08-01  2461  					u->oob_skb = NULL;
314001f0bf9270 Rao Shoaib 2021-08-01  2462  					consume_skb(skb);

It's so weird that we're sending warnings about 2021 code...  I looked
at this warning on Aug 10, 2021 but for some reason I didn't send it.

314001f0bf9270 Rao Shoaib 2021-08-01  2463  				}
314001f0bf9270 Rao Shoaib 2021-08-01  2464  			} else if (!(flags & MSG_PEEK)) {
314001f0bf9270 Rao Shoaib 2021-08-01  2465  				skb_unlink(skb, &sk->sk_receive_queue);
314001f0bf9270 Rao Shoaib 2021-08-01  2466  				consume_skb(skb);
314001f0bf9270 Rao Shoaib 2021-08-01  2467  				skb = skb_peek(&sk->sk_receive_queue);
314001f0bf9270 Rao Shoaib 2021-08-01  2468  			}
314001f0bf9270 Rao Shoaib 2021-08-01  2469  		}
314001f0bf9270 Rao Shoaib 2021-08-01  2470  	}
314001f0bf9270 Rao Shoaib 2021-08-01 @2471  	return skb;
314001f0bf9270 Rao Shoaib 2021-08-01  2472  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp