Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5c3d9637-7739-1323-8630-433ff8cb4dc4@linux.ibm.com>
Date:   Tue, 12 Jul 2022 11:21:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.3.0
Subject: Re: [PATCH v12 2/3] KVM: s390: guest support for topology function
Content-Language: en-US
To:     Janis Schoetterl-Glausch <scgl@linux.ibm.com>, kvm@vger.kernel.org
Cc:     linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        borntraeger@de.ibm.com, frankja@linux.ibm.com, cohuck@redhat.com,
        david@redhat.com, thuth@redhat.com, imbrenda@linux.ibm.com,
        hca@linux.ibm.com, gor@linux.ibm.com, wintera@linux.ibm.com,
        seiden@linux.ibm.com, nrb@linux.ibm.com
References: <20220711084148.25017-1-pmorel@linux.ibm.com>
 <20220711084148.25017-3-pmorel@linux.ibm.com>
 <92c6d13c-4494-de56-83f4-9d7384444008@linux.ibm.com>
 <1884bc26-b91b-83a7-7f8b-96b6090a0bac@linux.ibm.com>
 <6124248a-24be-b43a-f827-b6bebf9e7f3d@linux.ibm.com>
From:   Pierre Morel <pmorel@linux.ibm.com>
In-Reply-To: <6124248a-24be-b43a-f827-b6bebf9e7f3d@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 7/12/22 10:50, Janis Schoetterl-Glausch wrote:
> On 7/12/22 09:45, Pierre Morel wrote:
>>
>>
>> On 7/11/22 14:30, Janis Schoetterl-Glausch wrote:
>>> On 7/11/22 10:41, Pierre Morel wrote:
>>>> We report a topology change to the guest for any CPU hotplug.
>>>>
>>>> The reporting to the guest is done using the Multiprocessor
>>>> Topology-Change-Report (MTCR) bit of the utility entry in the guest's
>>>> SCA which will be cleared during the interpretation of PTF.
>>>>
>>>> On every vCPU creation we set the MCTR bit to let the guest know the
>>>> next time it uses the PTF with command 2 instruction that the
>>>> topology changed and that it should use the STSI(15.1.x) instruction
>>>> to get the topology details.
>>>>
>>>> STSI(15.1.x) gives information on the CPU configuration topology.
>>>> Let's accept the interception of STSI with the function code 15 and
>>>> let the userland part of the hypervisor handle it when userland
>>>> supports the CPU Topology facility.
>>>>
>>>> Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
>>>> Reviewed-by: Nico Boehr <nrb@linux.ibm.com>
>>>
>>> Reviewed-by: Janis Schoetterl-Glausch <scgl@linux.ibm.com>
>>
>> Thanks.
>>
>>
>>> See nit below.
>>>> ---
>>>>    arch/s390/include/asm/kvm_host.h | 18 +++++++++++++++---
>>>>    arch/s390/kvm/kvm-s390.c         | 31 +++++++++++++++++++++++++++++++
>>>>    arch/s390/kvm/priv.c             | 22 ++++++++++++++++++----
>>>>    arch/s390/kvm/vsie.c             |  8 ++++++++
>>>>    4 files changed, 72 insertions(+), 7 deletions(-)
>>>>
>>>
>>> [...]
>>>
>>>> diff --git a/arch/s390/kvm/kvm-s390.c b/arch/s390/kvm/kvm-s390.c
>>>> index 8fcb56141689..70436bfff53a 100644
>>>> --- a/arch/s390/kvm/kvm-s390.c
>>>> +++ b/arch/s390/kvm/kvm-s390.c
>>>> @@ -1691,6 +1691,32 @@ static int kvm_s390_get_cpu_model(struct kvm *kvm, struct kvm_device_attr *attr)
>>>>        return ret;
>>>>    }
>>>>    +/**
>>>> + * kvm_s390_update_topology_change_report - update CPU topology change report
>>>> + * @kvm: guest KVM description
>>>> + * @val: set or clear the MTCR bit
>>>> + *
>>>> + * Updates the Multiprocessor Topology-Change-Report bit to signal
>>>> + * the guest with a topology change.
>>>> + * This is only relevant if the topology facility is present.
>>>> + *
>>>> + * The SCA version, bsca or esca, doesn't matter as offset is the same.
>>>> + */
>>>> +static void kvm_s390_update_topology_change_report(struct kvm *kvm, bool val)
>>>> +{
>>>> +    union sca_utility new, old;
>>>> +    struct bsca_block *sca;
>>>> +
>>>> +    read_lock(&kvm->arch.sca_lock);
>>>> +    do {
>>>> +        sca = kvm->arch.sca;
>>>
>>> I find this assignment being in the loop unintuitive, but it should not make a difference.
>>
>> The price would be an ugly cast.
> 
> I don't get what you mean. Nothing about the types changes if you move it before the loop.

Yes right, did wrong understand.
It is better before.

>>
>>
>>>
>>>> +        old = READ_ONCE(sca->utility);
>>>> +        new = old;
>>>> +        new.mtcr = val;
>>>> +    } while (cmpxchg(&sca->utility.val, old.val, new.val) != old.val);
>>>> +    read_unlock(&kvm->arch.sca_lock);
>>>> +}
>>>> +
>>> [...]
>>>
>>
>>
> 

-- 
Pierre Morel
IBM Lab Boeblingen