Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] MIPS: fix pmd_mkinvalid
From:   Hongchen Zhang <zhanghongchen@loongson.cn>
To:     Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc:     linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1657181495-33004-1-git-send-email-zhanghongchen@loongson.cn>
 <20220707092206.GA9894@alpha.franken.de>
 <bfb97f6b-7a39-8253-bc14-08f2f54ed312@loongson.cn>
Message-ID: <0fd4e823-493f-07f0-08d5-f4a22491b602@loongson.cn>
Date:   Tue, 12 Jul 2022 18:01:08 +0800
User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <bfb97f6b-7a39-8253-bc14-08f2f54ed312@loongson.cn>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2022/7/7 下午7:12, Hongchen Zhang wrote:
> On 2022/7/7 下午5:22, Thomas Bogendoerfer wrote:
>> On Thu, Jul 07, 2022 at 04:11:35PM +0800, Hongchen Zhang wrote:
>>> When a pmd entry is invalidated by pmd_mkinvalid,pmd_present should
>>> return true.
>>> So introduce a _PMD_PRESENT_INVALID_SHIFT bit to check if a pmd is
>>> present but invalidated by pmd_mkinvalid.
>>
>> What problem are you trying to fix ? What are the symptoms ?
>>
>>> Reported-by: kernel test robot <lkp@intel.com>
>>
>> the test robot showed problems with your last version of the patch,
>> which hasn't been integrated into at least the MIPS tree, so no
>> need to that.
>>
>> Thomas.
>>
> 
> Hi Thomas,
>    The idea come from the commit:
>    b65399f6111b(arm64/mm: Change THP helpers to comply with generic MM 
>   semantics).
>    There is an problem now:
>          CPU 0        CPU 1
>      pmdp_invalidate        do_page_fault
>      ...              __handle_mm_fault
>                      is_swap_pmd == true
>                      trigger VM_BUG_ON() ?
>      set_pmd_at
>    the reason is that pmd_present return true,after this commit
>    pmd_present will return false,and the VM_BUG_ON will not be triggered.
>    Like arm64 does,we can introduce a new bit to fix this.
> 
> Thanks.
Hi Thomas,
  Is there problem of this patch? What's your opinion of this patch?

Thanks