Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22a21338-305d-bdf7-0079-df67fb030fc7@amd.com>
Date:   Tue, 12 Jul 2022 12:26:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2] drm/syncobj: Fix sync syncobj issue
Content-Language: en-US
To:     jie1zhan <jesse.zhang@amd.com>, broonie@kernel.org,
        dri-devel-bounces@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org
Cc:     Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, ajitkumar.pandey@amd.com,
        lucas.demarchi@intel.com, nirmoy.das@linux.intel.com,
        lionel.g.landwerlin@intel.com,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        open list <linux-kernel@vger.kernel.org>
References: <20220707102953.769684-1-jesse.zhang@amd.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220707102953.769684-1-jesse.zhang@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?am5UNVUrK0hveGYySGxRQjd5NHp6QzVDVjlUS2FVU2N3WlN4Z3VSV3ZxMDVh?=
 =?utf-8?B?SzQxS0dQKy9OclpzZG5HdUFDZng1QXJUSVQ3cTh3YnlVdmFFL0dudFlNdzdI?=
 =?utf-8?B?VThRMmZBT1ZqamRnTjN6TGdQMEZPVnluTkV0eUg3SFVvakZ5Y3RydEhOOXhB?=
 =?utf-8?B?NTZxU05tUWVISGFDVUhaRk5OWXJLOFBlaE5oa0NCcmpGOVdKS0s5d2F1VVYx?=
 =?utf-8?B?U0xqMlF5M21KQlNESzdpOEVJRHl2KzIvQXN6a3h4MXBUWFJaOWhaQUl3L05Q?=
 =?utf-8?B?Z3M3V0lmUHYrcTQ2S2hoTFgzVHdnbmlhODhLeHlUUWFxazJSalh6aU44NkZX?=
 =?utf-8?B?b3hhUlNkOGpVVjBuQXlmU2pOV3U2MWFJWkVKYnFZR1JIOVcyMkRST0NIVmg3?=
 =?utf-8?B?WCtZVmFVbVE0dC93dEx3ZDMwMStUa1h0UjZHa0szN1B3OEQyNzVJZi96c1Vu?=
 =?utf-8?B?d1paekdmczVyRnBzb3d4cE9uQXNUUlBuS2I4bXdtNGYzRG40SHpYMVRSOWUv?=
 =?utf-8?B?Rk0rU2lHKzZ0VUlxZm1JNDdKaW5VaTlYKzliR1FHNW9LcTA1RXNIUXU4UlBQ?=
 =?utf-8?B?Y2g0M2dvUUw2aDBKTmhQTGJEOWVvbFlGa2EydzBjOTNEeU04d0xycTdiSElS?=
 =?utf-8?B?RHVoRHR6VFB1Y0Qwczc1NE41UDhsMnZxOFRQdzhlbkhRbVBVUU1OT1JsUjJt?=
 =?utf-8?B?RFVrT21kYitNS09qRE9wcHlIRzFaalFuRndvTTFyUWNGaUV2SW9ucTlDWkp3?=
 =?utf-8?B?TFcvc0FnTlNHWUJwdFBpSm55MENlS1dmOCtKM05zS1VyRllwQmhDVVpFSVJ2?=
 =?utf-8?B?aVU1dk1TbVRCb282QU9xMGo3NUVIRnBDb2V2MlJoSXlVRGczNUFKL2NlSEJV?=
 =?utf-8?B?SE53QnZFaDhVUkNOOVpFY2JnWWQvcjFMamc2UmVBMkJBWTdIYVB6MER4R1ZR?=
 =?utf-8?B?SndsSDN4Q2U0ZkdjZjBDRDh2UEgwd2lRWEFJRkRBU1p0eEN4SmU4OTNpUHhy?=
 =?utf-8?B?UkJiQ0JqMHRlaEdSQkhCY2NNZnhRYTk1RXNGVWFUSEJHb1BEUEpLeWplaUhP?=
 =?utf-8?B?d3dYZjJ6WXJVOTlyMFJORWZiOFVHTEhOUFVKUTh2enFwdEppdjFhQzVvREpY?=
 =?utf-8?B?dkl6WnpKOWEwYkRZeXVadHk5WE1TQ2V4WmNORGNtOXVLUE94MDBGOHF3NmlE?=
 =?utf-8?B?SSs5aWtHdnBwL3JCT2JlU0RTSlZrV0w1cDEzN1ZCK0Y1blFYcWpVdXVqZGdG?=
 =?utf-8?B?NnBnMWhVVGFoL0dOWHNRUWtxUFdvWm5MRkxLNUFxRDhlNmtmd0R0UzBYNWRT?=
 =?utf-8?B?SmhieTN3b1MxT200SzlaNkhWdEwrTWtTK0xJUnVvVUh1b1QvaDl5MDZHZ1lP?=
 =?utf-8?B?dnpjb3RLZUs3RUI4c1lJTkZzNlRzMFhKYjZnZ0VPMnlvMm9JdWtQMlc3UDJp?=
 =?utf-8?B?SzY2clloUjA3eWhRVzkxL1FmbGFlcWpPMDBCMVpMczdlak5RTFg3dzJXNkZP?=
 =?utf-8?B?Z3hRRTZ2V2crRmZ5R1VscnU0SVF5eWRjcUd4VWRaMnBrMFc1SlZtMUg2c241?=
 =?utf-8?B?SVI5RTByNkcyQktHdVV5OTRIQlQ0djRkSkdlTWlRNU5uMWc4Ukt5bG5Sakdr?=
 =?utf-8?B?TFhsbm05Z3BFdFhOclZMOVBUNTZHVGpGaDdrKzk0bFBRYjdrUTFKY2Fna2Rj?=
 =?utf-8?B?Q21NTG40ZTZ3dnlUNkVlRGJuczMzNThZbDYrTGxvWHBjb25SZlZtRTlrbENG?=
 =?utf-8?B?NDBjdGduamJPbGlNKzFndnBIbWZjZGhSb2VxZklYUVowdmlsMGFqR2tJT1FD?=
 =?utf-8?B?cWtUMlM1aUltck9BSlE5UWgyMnByMnQ2NGxRd01aMWNqNnE4L2NZWUdpc0Vy?=
 =?utf-8?B?Qy9RZCtSbDBrSnJLeXZ2b0dqV01vbzcyeXEzNWJ2MDhHWlk4b1kzeU5lKzha?=
 =?utf-8?B?d0pJN2hhMERmTWVjUHl3NVhnZUpCcWNmSlltMnpIMU9oaVFESW5vUGUzdURZ?=
 =?utf-8?B?cTcxVjVxdGhQUHB3REV6NFlwUktZYkE2WTAwcHMzQkVMZkt5TlBON1kzaVVQ?=
 =?utf-8?B?anhZL1FEWjdIckNMQlhESlg2emtodTR0NVhhZ25DOFBMRS9FaUxJYXZ4VU96?=
 =?utf-8?Q?1PW/6eJpOkAlJy1+YgmyfeVoa?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc1d73d-538f-43ca-6764-08da63f0ff79
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 10:26:35.8762
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: mVaMCJUWM8uGFG0S912z3aQWqBnSm3adZuEImqw0R+oVG34w9+jM5blv7F1BnQGK
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5759
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Ping to the Intel guys here. Especially Lucas/Nirmoy/Lionel.

IIRC you stumbled over that problem as well, have you found any solution?

Regards,
Christian.

Am 07.07.22 um 12:29 schrieb jie1zhan:
> enable signaling after flatten dma_fence_chains on transfer
>
> Signed-off-by: jie1zhan <jesse.zhang@amd.com>
> ---
>   drivers/gpu/drm/drm_syncobj.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/drm_syncobj.c b/drivers/gpu/drm/drm_syncobj.c
> index 7e48dcd1bee4..0d9d3577325f 100644
> --- a/drivers/gpu/drm/drm_syncobj.c
> +++ b/drivers/gpu/drm/drm_syncobj.c
> @@ -920,6 +920,7 @@ static int drm_syncobj_transfer_to_timeline(struct drm_file *file_private,
>   	if (ret)
>   		goto err_free_fence;
>   
> +	dma_fence_enable_sw_signaling(fence);
>   	chain = dma_fence_chain_alloc();
>   	if (!chain) {
>   		ret = -ENOMEM;