Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 11:59:48 +0100
From:   Catalin Marinas <catalin.marinas@arm.com>
To:     patrick wang <patrick.wang.shcn@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, dennis@kernel.org,
        tj@kernel.org, cl@linux.com,
        "open list:MEMORY MANAGEMENT" <linux-mm@kvack.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: percpu: use kmemleak_ignore_phys() instead of
 kmemleak_free()
Message-ID: <Ys1UJMYa7UW0+Bt0@arm.com>
References: <20220705113158.127600-1-patrick.wang.shcn@gmail.com>
 <20220705142000.4679acaaf1238a73a555ea58@linux-foundation.org>
 <CAGcnep_1QSdkNYqvgYC+ec2XVmqvG6rjZud-NfG22f_wQrJHKQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAGcnep_1QSdkNYqvgYC+ec2XVmqvG6rjZud-NfG22f_wQrJHKQ@mail.gmail.com>
Precedence: bulk

On Wed, Jul 06, 2022 at 10:44:11PM +0800, patrick wang wrote:
> On Wed, Jul 6, 2022 at 5:20 AM Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > On Tue,  5 Jul 2022 19:31:58 +0800 Patrick Wang <patrick.wang.shcn@gmail.com> wrote:
> >
> > > Kmemleak recently added a rbtree to store the objects
> > > allocted with physical address. Those objects can't be
> > > freed with kmemleak_free(). Use kmemleak_ignore_phys()
> > > instead of kmemleak_free() for those objects.
> >
> > Thanks.  What are the user-visible runtime effects of this?
> 
> According to the comments, percpu allocations are tracked
> by kmemleak separately. Kmemleak_free() was used to avoid
> the unnecessary tracking. If kmemleak_free() fails, those
> objects would be scanned by kmemleak, which is unnecessary
> but shouldn't lead to other effects.
> 
> I didn't observe any anomaly without this commit on riscv
> and arm64.

What could happen is an increased rate of false negatives as it scans
more than necessary.

> > And are we able to identify a commit for the Fixes: line?
> 
> 0c24e061196c (mm: kmemleak: add rbtree and store physical
> address for objects allocated with PA)
> Current in mm-stable.

I think we could add a Fixes line for the above. For the patch:

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>