Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 13:51:37 +0200
From:   Alexander Gordeev <agordeev@linux.ibm.com>
To:     Liam Howlett <liam.howlett@oracle.com>
Cc:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] maple_tree: Fix mas_empty_area_rev() search exhaustion
 at root node
Message-ID: <Ys1gSRC3kTQQZ0Fr@li-4a3a4a4c-28e5-11b2-a85c-a8d192c6f089.ibm.com>
References: <20220712014957.4064879-1-Liam.Howlett@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220712014957.4064879-1-Liam.Howlett@oracle.com>
Precedence: bulk

On Tue, Jul 12, 2022 at 01:50:36AM +0000, Liam Howlett wrote:
> When the possibilities of finding a gap are exhausted at the root node,
> the error code was not returned which results in returning a range that
> is currently occupied.  Add the necessary check for the error code and
> return to the caller.
> 
> Reported-by: Alexander Gordeev <agordeev@linux.ibm.com>
> Fixes: d0aac5e48048 (Maple Tree: add new data structure)
> Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
>  lib/maple_tree.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index 9dc4ffff18d0..14e9ab14c1da 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -5287,6 +5287,9 @@ int mas_empty_area_rev(struct ma_state *mas, unsigned long min,
>  		}
>  	}
>  
> +	if (mas_is_err(mas))
> +		return xa_err(mas->node);
> +
>  	if (unlikely(mas->offset == MAPLE_NODE_SLOTS))
>  		return -EBUSY;

Tested-by: Alexander Gordeev <agordeev@linux.ibm.com>

Thanks!