Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 15:50:49 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Daniel Latypov <dlatypov@google.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        GNU/Weeb Mailing List <gwml@vger.gnuweeb.org>,
        linux-kernel@vger.kernel.org,
        Shuah Khan <skhan@linuxfoundation.org>,
        David Gow <davidgow@google.com>,
        Brendan Higgins <brendanhiggins@google.com>
Subject: [ammarfaizi2-block:shuah/linux-kselftest/kunit 4/16]
 lib/kunit/executor.c:78 kunit_filter_tests() warn: possible memory leak of
 'copy'
Message-ID: <202207101328.ASjx88yj-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P8ZIYDujd/QEDl3+qicMh57CznrtQ8o11LFuJuD4jA9lwF7fdLW1bFfTE7EO?=
 =?us-ascii?Q?qsUX3RKaUMQgh7d9zGFw8ag38LZsdtbo4fHdyPE0vLmkhxKsIKTyYQacTTgb?=
 =?us-ascii?Q?ptXu3+xZtkh2qssw9ZMiyibB2HjHBDOHr/XMfDVZP/bQVQ27CavVslnqYYT4?=
 =?us-ascii?Q?XA4V03+MIouGjbIbi/d9HCC9xJ9vSBAt2GQGjwv2GNc74CtAP3E4580Hzwr8?=
 =?us-ascii?Q?+3Xfy0ILUp34iVUm7QHrAslLpiUQk2og2s7hM3O0VwuHHmPrwz5digg/OP23?=
 =?us-ascii?Q?kZEa6ZhwvA1Iyo+mq4ON7TeeyCxLMjmyQCWzRNYzgtIFzw+7cS9WRZ8iMjyB?=
 =?us-ascii?Q?J1hz4o/r+39lsHDm1UwrEd4zqVC2vnnVO/pvg6n+A5QhNpPJ6hUqkUmt3GhJ?=
 =?us-ascii?Q?Sra/s5NjvA/pLvZ8LgFtjT3ATHq2NN9k9kKGw0aIoX88qlUJC0EVmIPsDL8i?=
 =?us-ascii?Q?dYUFlveVPDzEMZ8ycf4zXswdi4ce9h8dLXNCzZBS95SEnuiBJ+a9FnJShEnn?=
 =?us-ascii?Q?o5oYfgtGZ09mO2u25ocwf16B5UHLTdxSvil3+4x5HXiQpxI2p889BcimuU5r?=
 =?us-ascii?Q?lZTkHwvdMnOe1UrV3WMgr1p/OvWyuyrN++twt4VhpOkv9KbGxQ7e4MsLJdWP?=
 =?us-ascii?Q?of2dLjEirr8jR9JlkAbdhHU6L/SjRQRWNbRYcOa2Z5DK9WgqBPhYJYDPVAWI?=
 =?us-ascii?Q?UpdM4f/3O+nU4r4cdwfrFE7v5+5O28VNr9+IWTiAq4e9YzkZvX5dcIdHzjmW?=
 =?us-ascii?Q?1X8MTrfKJ1mSXoQiX8h2nJNLkMLJ5wp0inoUuQkM19KTZ7+a9bn1s5eK3T/a?=
 =?us-ascii?Q?HhJCySOD7A1nafJ0BCkjurIrfERz5gOjrXVzhUmUO8HpYkbuPJ/nLMTGquy7?=
 =?us-ascii?Q?k5mOKGYRlIkgXmCYRMJZAwmjY3PoGaNrC6R/OX++p7QjA1OBu8Fi523iuvkr?=
 =?us-ascii?Q?UHisSFi2M2coxcs16otsHoxRBNyOh6N2Y+Chw/tVT/wMXggeywZ8vuW20EZA?=
 =?us-ascii?Q?fBKhhOXbrkCZuSGjFq9sulNeJhQZtOU8ThS/rTt7lAB0eigDsQ/IaGDUcr2P?=
 =?us-ascii?Q?dTZySD7IxFI1dvm82bQNANj5h1VxelyRhHMWuhQ3bOwUigM2aDGi7JxN8UQs?=
 =?us-ascii?Q?ug4Yy9UiAzXKTG0keyh1qaiefd8By2F3XQfO+Yn5zg4uI9L23WFY5aKSgeA+?=
 =?us-ascii?Q?o40M931b/OvTe6+7O92ACJl6cB17IcLVvT51wqToRRnXga5M+YXJkIXADylU?=
 =?us-ascii?Q?NIRqB2T3NyiV6s3IAwcBVzluVaT7gnTxi2aCqMlm0ad9Jg8475FJEas5RR09?=
 =?us-ascii?Q?r1uvo+GtcFs7y/4yRUUF9CbFG6Lkqbcr0M30FSgy8RsQQRkyBCwx4qZl1WC2?=
 =?us-ascii?Q?gEyB0obVUz1ocAEW4zB5iao5fNOcDL7lHFiMYZaZjKNh4s0tLNf9Xo8c0Unt?=
 =?us-ascii?Q?m3O6J0wXVtMGbJpJwetRdPBhyA1fFEVOiMeiu4nXbj80n7rUUgFBPnhcUIu8?=
 =?us-ascii?Q?by1BpPPw5Hye0SLeJ1ry24af0Zz7PFUukKsNQbg/0MEQsAkXkgh3eLhSh5gq?=
 =?us-ascii?Q?kn3EgTV1yK1+s0J4dMK/FcwGp7rm1MNg6ViDcG1rexFU87llf/PHMCowjP7l?=
 =?us-ascii?Q?ig=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9dde7561-ca54-4622-6b6d-08da64052cf9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 12:51:02.0222
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: m2tIIFxWw/v7vrC2hLZ5qJBT+89DavFE/LTVocGUMOxaVOWlMleRPo3coFGQix0SqzRtD4TnlBE7QACujvGXPlwbS0z+AtmviSyy4HV41u0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4197
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-12_08:2022-07-12,2022-07-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0 mlxscore=0
 suspectscore=0 adultscore=0 spamscore=0 mlxlogscore=999 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207120049
X-Proofpoint-ORIG-GUID: IA5duPaD8L8HaRhczHcHbqUjKAyhh6mo
X-Proofpoint-GUID: IA5duPaD8L8HaRhczHcHbqUjKAyhh6mo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://github.com/ammarfaizi2/linux-block shuah/linux-kselftest/kunit
head:   7635778bac7e46458392c1261e3916e8e9e86860
commit: d2fbdde838f270377de4fc20e919aac3941ea55f [4/16] kunit: use kmemdup in kunit_filter_tests(), take suite as const
config: arc-randconfig-m031-20220707 (https://download.01.org/0day-ci/archive/20220710/202207101328.ASjx88yj-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
lib/kunit/executor.c:78 kunit_filter_tests() warn: possible memory leak of 'copy'

vim +/copy +78 lib/kunit/executor.c

a127b154a8f2317 Daniel Latypov 2021-09-14  57  static struct kunit_suite *
d2fbdde838f2703 Daniel Latypov 2022-05-16  58  kunit_filter_tests(const struct kunit_suite *const suite, const char *test_glob)
a127b154a8f2317 Daniel Latypov 2021-09-14  59  {
a127b154a8f2317 Daniel Latypov 2021-09-14  60  	int n = 0;
a127b154a8f2317 Daniel Latypov 2021-09-14  61  	struct kunit_case *filtered, *test_case;
a127b154a8f2317 Daniel Latypov 2021-09-14  62  	struct kunit_suite *copy;
a127b154a8f2317 Daniel Latypov 2021-09-14  63  
a127b154a8f2317 Daniel Latypov 2021-09-14  64  	kunit_suite_for_each_test_case(suite, test_case) {
a127b154a8f2317 Daniel Latypov 2021-09-14  65  		if (!test_glob || glob_match(test_glob, test_case->name))
a127b154a8f2317 Daniel Latypov 2021-09-14  66  			++n;
a127b154a8f2317 Daniel Latypov 2021-09-14  67  	}
a127b154a8f2317 Daniel Latypov 2021-09-14  68  
a127b154a8f2317 Daniel Latypov 2021-09-14  69  	if (n == 0)
a127b154a8f2317 Daniel Latypov 2021-09-14  70  		return NULL;
a127b154a8f2317 Daniel Latypov 2021-09-14  71  
d2fbdde838f2703 Daniel Latypov 2022-05-16  72  	copy = kmemdup(suite, sizeof(*copy), GFP_KERNEL);
a02353f491622e4 Daniel Latypov 2022-05-11  73  	if (!copy)
a02353f491622e4 Daniel Latypov 2022-05-11  74  		return ERR_PTR(-ENOMEM);
a127b154a8f2317 Daniel Latypov 2021-09-14  75  
a127b154a8f2317 Daniel Latypov 2021-09-14  76  	filtered = kcalloc(n + 1, sizeof(*filtered), GFP_KERNEL);
a02353f491622e4 Daniel Latypov 2022-05-11  77  	if (!filtered)
a02353f491622e4 Daniel Latypov 2022-05-11 @78  		return ERR_PTR(-ENOMEM);

kfree(copy)?  Is the burden of random devs looking at this warning
forever more than the burden of adding a kfree()?  Hard to measure.

a127b154a8f2317 Daniel Latypov 2021-09-14  79  
a127b154a8f2317 Daniel Latypov 2021-09-14  80  	n = 0;
a127b154a8f2317 Daniel Latypov 2021-09-14  81  	kunit_suite_for_each_test_case(suite, test_case) {
a127b154a8f2317 Daniel Latypov 2021-09-14  82  		if (!test_glob || glob_match(test_glob, test_case->name))
a127b154a8f2317 Daniel Latypov 2021-09-14  83  			filtered[n++] = *test_case;
a127b154a8f2317 Daniel Latypov 2021-09-14  84  	}
a127b154a8f2317 Daniel Latypov 2021-09-14  85  
a127b154a8f2317 Daniel Latypov 2021-09-14  86  	copy->test_cases = filtered;
a127b154a8f2317 Daniel Latypov 2021-09-14  87  	return copy;
a127b154a8f2317 Daniel Latypov 2021-09-14  88  }

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp