Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 15:25:08 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Martin Kaiser <martin@kaiser.cx>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Larry Finger <Larry.Finger@lwfinger.net>,
        Phillip Potter <phil@philpotter.co.uk>,
        Michael Straube <straube.linux@gmail.com>,
        Pavel Skripkin <paskripkin@gmail.com>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/14] staging: r8188eu: use a local buffer for efuse data
Message-ID: <20220712122507.GN2338@kadam>
References: <20220709171000.180481-1-martin@kaiser.cx>
 <20220709171000.180481-6-martin@kaiser.cx>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220709171000.180481-6-martin@kaiser.cx>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?xulD4sJSv9LdPnc6juhW+tHFN55WG6RGQzZ05jlR174vru0JA7Le5s8KEDTo?=
 =?us-ascii?Q?gbKvBlUnsbFyCUWsbVkwnFHpI1bcqXn2NzPIohd2iUiedokhEC5fARu4ZKDm?=
 =?us-ascii?Q?TN/odLvifp4Wz2j5VDPMUU4yQnrs1S7LdRlV41bvQqdR9WvmMaHgHWg/pcvR?=
 =?us-ascii?Q?i2T7wmvw8T5CtHU18IsCI8wALNM3GETN2SiT0c503W4GwghPFk1SQ1AwD7Gu?=
 =?us-ascii?Q?33zF0HQTkdjuc+HH2dMhdSQWarGWB/fwvs4auWqqyTUAfjtlRx/ZToK7v59H?=
 =?us-ascii?Q?dmtp9iWgdlgVUTDNFepohuLP7W87LsgBY3hpiCfL7x+XgpnWfWB9nUYl1QxJ?=
 =?us-ascii?Q?7zYerisxK0o4NDmqdzSaZ9UBd5wpWZ0YXZXPXI5uFiXPwBv9c5avQB3t0GJ5?=
 =?us-ascii?Q?of/j3YA+srVO5VOAp627HK0NSzTj5jwWkdUMTZzEoqbOvPyprYuH1w9Igkvp?=
 =?us-ascii?Q?vETcldqcNABSiiTgYMdwbYGWD/5y8aRt2lsd8CTMv3i/49pJJq2T4Daff7B8?=
 =?us-ascii?Q?fPdSlPxMVsRXNKO4goZ4XIaZdfv7G/UDJOqxr8erE6smivpcvHqg9pkOgwDi?=
 =?us-ascii?Q?unINusJv3fXxFJkVu9l5hIpIRHVDZYnHXuJqqVzOWqaIKaHAhlgScQhLvn04?=
 =?us-ascii?Q?Mq2hUXFXXdZfv3DHbmPzG/FuZ9+1ltCsEMI1iZ5pm13gthlpRQ5hgUx1R9l8?=
 =?us-ascii?Q?if7Km6xj3aha4s+UAYJhweDqOrHLQ02ThQUccFeVJiHcXu1hDb7O2gtEwFFQ?=
 =?us-ascii?Q?ajv3HcW6KmPVhWDEml2FPPfB+Yvq2NxtLvbDFYx9UBQjQ6SvD4j5BJ3vdMkz?=
 =?us-ascii?Q?VImHc031mv9RsCFwaQA7vWd/o12EvB/Y1vJmvblQgZ+O5pcZpA1JfCyHwPMq?=
 =?us-ascii?Q?93YQCZo6FdVC8CUT9KHqUls54u49vO5TWBwXPdXtOtn9QaY7Bhwy/7BYvkNH?=
 =?us-ascii?Q?XquGWMIMseBToRKTmXuX6ECrk95WtNlsG0bQ6N2uQucrUT6zXFhFu61+naL1?=
 =?us-ascii?Q?TYuSy5FNTWdme7nh1It9I9Vw4ZsWU2oSyb4xoyiOFEpghXVQaClC2/gTYhPo?=
 =?us-ascii?Q?Uh8bfN34iU8SVjGAwIjx3fQRdgY9q4wN44T1+BDp847mAGOcPdBcWEmAVft7?=
 =?us-ascii?Q?AdoEB650ZDvs2Q011Kl5lt+qkjUIE2UDtlm7AOeOtguxB1dUMyC5JOZ9GT4Y?=
 =?us-ascii?Q?qQY4T8Kc23XrbK515g+Cbd12o1+3GnZCRcdWAUZM7JJBzKgJQCshyBW16pX0?=
 =?us-ascii?Q?kb3A1v/0Rjc4Zk39kojNLnudLqSdNYtuOhEs0S/5gJG7ffENLhTwxYBWD0Wu?=
 =?us-ascii?Q?IqorcpF8McxVuF8cJNxkNQOCTGNDd7DHpPHjH6522FJEk0texqs9CcVRNVb3?=
 =?us-ascii?Q?tcDOpaQpe5sPyZjtB/7oBGtNbLFHzvPgmx0ckaowOgGCDxodJc0tdmwgfnBt?=
 =?us-ascii?Q?e2UKTwQEZgCxShzid2fPTu+k4/gneY2Ah/Bwevfb+nNoTt5oinwms5U0jUim?=
 =?us-ascii?Q?WaC1M8Y9WhgeTUfvcFJlqttLsVvxxwXeiibiwcNLUshzExbvoeT1Ys2CoDb+?=
 =?us-ascii?Q?GTAwLnfJY5fhaKBSmYDpmBu3Co3Brixsn0kBJqpi?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 605d7074-f6e0-431c-ceda-08da64019c29
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 12:25:30.9076
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ziO4i0+plvxnQwN1wd5x3QX9Fr3WeRQjLJOyxD17J/kbm9lRR1fEk2xHscRxdphsv4Qs2kjNrGrNSgweo1bEciGiwYuEqslgoBu5UWZ83Q4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR10MB3454
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-12_08:2022-07-12,2022-07-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207120048
X-Proofpoint-GUID: -222AL0Euoa-4Q7ZwC525ezrKsnDPrr2
X-Proofpoint-ORIG-GUID: -222AL0Euoa-4Q7ZwC525ezrKsnDPrr2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jul 09, 2022 at 07:09:51PM +0200, Martin Kaiser wrote:
> The efuse_eeprom_data array in struct eeprom_priv is used only by
> ReadAdapterInfo8188EU. We can remove efuse_eeprom_data and use a local
> buffer instead.
> 
> Use EFUSE_MAP_LEN_88E as buffer size. Its value is the same as
> HWSET_MAX_SIZE_512. The functions that access the buffer use
> EFUSE_MAP_LEN_88E for its size.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  drivers/staging/r8188eu/hal/usb_halinit.c    | 23 ++++++++++----------
>  drivers/staging/r8188eu/include/rtw_eeprom.h |  3 ---
>  2 files changed, 12 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/hal/usb_halinit.c b/drivers/staging/r8188eu/hal/usb_halinit.c
> index 18c2817bf1e3..807d8ce8cbfc 100644
> --- a/drivers/staging/r8188eu/hal/usb_halinit.c
> +++ b/drivers/staging/r8188eu/hal/usb_halinit.c
> @@ -929,6 +929,7 @@ void ReadAdapterInfo8188EU(struct adapter *Adapter)
>  {
>  	struct eeprom_priv *eeprom = &Adapter->eeprompriv;
>  	struct led_priv *ledpriv = &Adapter->ledpriv;
> +	u8 efuse_buf[EFUSE_MAP_LEN_88E] __aligned(4);

This is 512 bytes.  We used to be slightly worried about declaring 512
bytes on the stack, but I'm not sure the situation now.

regards,
dan carpenter