Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <124806c0-4189-0280-ce9a-80cafb238c7d@kernel.org>
Date:   Tue, 12 Jul 2022 07:52:12 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCHv6 1/2] i2c: designware: introduce a custom scl recovery
 for SoCFPGA platforms
Content-Language: en-US
From:   Dinh Nguyen <dinguyen@kernel.org>
To:     Wolfram Sang <wsa@kernel.org>, jarkko.nikula@linux.intel.com,
        andriy.shevchenko@linux.intel.com, mika.westerberg@linux.intel.com,
        robh+dt@kernel.org, krzk+dt@kernel.org, linux-i2c@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        christopher.hatch@intel.com
References: <20220620230109.986298-1-dinguyen@kernel.org>
 <YrI6EeVkkWVMNPFY@shikoro> <928b2996-b2e7-d847-0e20-7e19df3cbf03@kernel.org>
 <YrN2lxvlP4cWfelY@kunai> <c765455f-c1b9-2da0-675e-591f7c268d99@kernel.org>
In-Reply-To: <c765455f-c1b9-2da0-675e-591f7c268d99@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 7/12/22 07:41, Dinh Nguyen wrote:
> Hi Wolfram,
> 
> On 6/22/22 15:07, Wolfram Sang wrote:
>>
>>>  From the original code, the first mechanism to a recovery is to 
>>> acquire a
>>> GPIO for the SCL line and send the 9 SCL pulses, after that, it does 
>>> a reset
>>> of the I2C module. For the SOCFPGA part, there is no GPIO line for 
>>> the SCL,
>>> thus the I2C module cannot even get a reset. This code allows the 
>>> function
>>> to reset the I2C module for SOCFPGA, which is the 2nd part of the 
>>> recovery
>>> process.
>>
>> The second part is totally useless if the client device is holding SDA
>> low. Which is exactly the situation that recovery tries to fix. As I
>> said, if you can't control SCL, you don't have recovery.
>>
> 
> This is recovery of the master and not the slave.  We have a customer 
> that is the using I2C with the signals routed through the FPGA, and thus 
> are not GPIO. During a timeout, with this code, the driver is able to 
> recover the master.
> 

Adding a bit more, because of patch:

ca382f5b38f3 ("i2c: designware: add i2c gpio recovery option")

the driver is now not able to reset the controller at all because it has 
placed a strict dependency on getting a GPIO. Before this patch, during 
a timeout, there was a simple call to i2c_dw_init_master(), which 
ultimately resets the master.

Dinh