Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 15:35:35 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@lists.01.org, Zach O'Keefe <zokeefe@google.com>
Cc:     lkp@intel.com, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux Memory Management List <linux-mm@kvack.org>
Subject: [akpm-mm:mm-unstable 284/293] mm/khugepaged.c:2409
 madvise_collapse() warn: possible memory leak of 'cc'
Message-ID: <202207100715.TBIYQ4fc-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CRqTqL1Xdh1Z3YPN2nz+exXtL6dAd5UK6ks+NnD2msOWqTatENX9mhP3b4kf?=
 =?us-ascii?Q?lFZMQWCkQPOVeeWBpB7CaPLhDYn1UjCQ7x9GU6ABohg6clFtabKcbBJAWCAB?=
 =?us-ascii?Q?MWz/gOGc5UUP6KFHOgi9N7O1HGMyMRdHkuOlMpX6vWbFf8EfnM/FMBT3PSkF?=
 =?us-ascii?Q?ffnhpW/LtZ5g9E5vI8Z+AYZZQY1yPQO9+lk5wjuHbszdEVnvC6QAH6p5Eehu?=
 =?us-ascii?Q?dOvbLJqoiU4K+LbjSvRlRPHrP8NJcXYQxVCqAuNosla3RBj29LEy0vVKY96N?=
 =?us-ascii?Q?Q/SHVW73ZFjFx11BgnGZHCmmI8EfOlnirorjW/5pTqW4cNE0yw8HZLn3xixh?=
 =?us-ascii?Q?5w4vl6/xO33cM6yJaedbEFB8MJdnglBF6CSa7wO1OdffXDd6Mcw380oweWQ/?=
 =?us-ascii?Q?mLecSpCVxgi7czeps/92gDsLLgjbdM2v6Y77/D30EDzI7C3jPzk4PLVjHhF/?=
 =?us-ascii?Q?rqW5XiQiUO4uPnZUOAJO2Kj+i145x3+f/FBAWww4PUzttESHhKhGM6OSFh6K?=
 =?us-ascii?Q?f3txJQUsn+3vxaIeQ4fWD6eAtwA/HG/YNPpL/qS+2fDMvIjEnD09uk9bUv4y?=
 =?us-ascii?Q?+RPGTuVq5uf38O7nNJo2/2+5loOdbDeRyx+Pti8rtQUXhsibLfGU9SPWxM5D?=
 =?us-ascii?Q?R51I0TjFPqFnqIrn1MpO+bvZ6FLcL3wiDfpv9BeMLFcR+On8Pi2Xhf83VzFS?=
 =?us-ascii?Q?1+cVTqXtHJ3cGuKPSAdHeQiAddAMtv1MI0UVo7X0YCPN21BsPs51oa/mIRId?=
 =?us-ascii?Q?MYpMAZj3KAteVmAXVoKYEOHtAjAmrEcf9NDhEepkKjZCT6DEVGRsqqxE3PCu?=
 =?us-ascii?Q?bdhgWRFVhV2YcNgLKG6LLaDKUyV1+W1tH+h7KHUSjNEXZTD/iWYQzlwjDAH0?=
 =?us-ascii?Q?qoYmuHPIbkyLe7hXgsllyuFnUTp62G7CHjr59abbHdEAo4XmjR90+X1yTM2c?=
 =?us-ascii?Q?2gHZsmBTorrocA+dT2ewL9JtZDWkjqXSvoukzVsUBgzUbOIWyS2hgByR8nx0?=
 =?us-ascii?Q?LOpnLrqx4OJ+8O6Y8rj74d1QiZtQ++yXst6uXYMRShTuH6n8zYk0lsA3XLya?=
 =?us-ascii?Q?CHSnWw1SweuQuRQyZLpXqjNhc3f31InwpliAyGpXlbLa0t0l67VM+II38K8p?=
 =?us-ascii?Q?D5R21WBof6I4ABxoWfiEhgmui3ZjoQfTkXPqS6dK3bBfZqMEvjdua+8CUp/J?=
 =?us-ascii?Q?21QVgYYjpg+SB1dHPFWc1VA9FuisWWzd9frA8Dol+RXTI1+/KMeSRZJ2/i/4?=
 =?us-ascii?Q?WhSjZnM00+tgFJJV21LEKZBfW9BzKpo9mMhuUtSKhSnfeHo6LKq5fp1Mogxa?=
 =?us-ascii?Q?DAnAK0GvO9b5Kcvn18cDa24x8RSv++TKaBEmtAmiwADgCNHsFEm/q2tdAjY9?=
 =?us-ascii?Q?AQ059+u65Q3znWJ+slB8bfJpoL6TgjXu1KNbYhPxNAYed/5UcvMDbri3kyoO?=
 =?us-ascii?Q?tQMlRt/By9GxV5lYsHsiUTRvl1gmhhZIjVw//CQONP8MjmzDPDapLaQ5XJCw?=
 =?us-ascii?Q?jgDD1r+TOYf+d5rJRpNj93Bm7MCMhMzWaNTPzkGJTfTyId1z80ZygmIsmf9o?=
 =?us-ascii?Q?iXn/BlEE+CAECYMZSx93vycAOqS/MLRxHNodcMcY95M+qvXub7iryT7SVZTv?=
 =?us-ascii?Q?Pw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 78fb96fc-d723-4a5d-97db-08da64030adc
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 12:35:45.7817
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: QubtRYfsdrJZYS8klNYODROLMTzobcU1GHrkA3YMaOBl7QiosQ5mWlOZ7mZFeHa4U2tfHLgu9FEWIPvQLfJdYPTU+LhzPKXIcRmjzhPI+hc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR10MB2900
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-12_08:2022-07-12,2022-07-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 malwarescore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207120048
X-Proofpoint-GUID: bAA6-w4x8M6BzQzft3SKIjJeOz1lxqn4
X-Proofpoint-ORIG-GUID: bAA6-w4x8M6BzQzft3SKIjJeOz1lxqn4
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-unstable
head:   0e9f775fb0b4adf1a4ef50ea156ead09a0fc5194
commit: 9f626ffb1d1c5c26b4a8e0fdffec784a5f773274 [284/293] mm/madvise: introduce MADV_COLLAPSE sync hugepage collapse
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220710/202207100715.TBIYQ4fc-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
mm/khugepaged.c:2409 madvise_collapse() warn: possible memory leak of 'cc'

vim +/cc +2409 mm/khugepaged.c

9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2387  int madvise_collapse(struct vm_area_struct *vma, struct vm_area_struct **prev,
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2388  		     unsigned long start, unsigned long end)
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2389  {
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2390  	struct collapse_control *cc;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2391  	struct mm_struct *mm = vma->vm_mm;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2392  	unsigned long hstart, hend, addr;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2393  	int thps = 0, last_fail = SCAN_FAIL;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2394  	bool mmap_locked = true;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2395  
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2396  	BUG_ON(vma->vm_start > start);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2397  	BUG_ON(vma->vm_end < end);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2398  
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2399  	cc = kmalloc(sizeof(*cc), GFP_KERNEL);
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2400  	if (!cc)
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2401  		return -ENOMEM;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2402  	cc->is_khugepaged = false;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2403  	cc->last_target_node = NUMA_NO_NODE;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2404  
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2405  	*prev = vma;
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2406  
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2407  	/* TODO: Support file/shmem */
9f626ffb1d1c5c Zach O'Keefe 2022-07-06  2408  	if (!vma->anon_vma || !vma_is_anonymous(vma))
9f626ffb1d1c5c Zach O'Keefe 2022-07-06 @2409  		return -EINVAL;

kfree(cc);?


-- 
0-DAY CI Kernel Test Service
https://01.org/lkp