Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4350530imw; Tue, 12 Jul 2022 06:33:58 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tuflw2ZA75bycb53Duh6qzIE1PQbzpz1KUqHRScqC0npH2feAlZVKsC91fl0rTJ5D6MEPw X-Received: by 2002:a17:906:cc18:b0:72a:e88c:4cc4 with SMTP id ml24-20020a170906cc1800b0072ae88c4cc4mr24085996ejb.629.1657632838665; Tue, 12 Jul 2022 06:33:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657632838; cv=none; d=google.com; s=arc-20160816; b=GYlgrYon0zfm9JHf3g7hoZhqVJL6eZPK2oYCDhDyWkiEQl2diGjvm5ReJvhT6mRBvU B0EHoNfY4Ht2YOy2YvjS4MZuvYsjvYrwrxwrhDAEArXUDYqxv7TyM6dQ6DZKn1F9t+mm 0z+CYFpVoAW6MRL70i5PylCnGCQE+zqeNAyD5GIAy3RVA61lTUi/wSRn7oDNYk0K3KXu xOJ8Iu5aSilMGIrN8JA9U1u+sFhz7JsOvSI0ywDD3uHc+huD7TsQJijNnsrb6HOmYMzp zRMUipGi9ziQyKPrBVWPIDfbAsppZNTYGywyIWVxa5I8NgiRfGZpB+bmbbeQp+LGw02w Jn4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GeBXHzaR9hFbNi2rsIvOiJSjHq9fAExMloziB95EMUE=; b=RiJ4PFFtbFmZwYoqszQjdcj7OjAfFQ0hNnAl6d3VQhOVL819yQ7mc1J+wxqXAPpn7V lBqcv1EGWIjAbE1xopq82ezJkVEIQEdqSYeZDZXbP8YnQI1xNxkF8Or6ryFo6N1QuYp4 3ukesIn8MYr4QGCBtwQQoonvlhvrZOIW+vB4aYNtCQLvMReDqk52SA10azA9l/m0tFew kXqHYYxjzOSt+7vFWQjT/ks7wClTu1vGfndbr728EJLB4lRNKjriNAThMtf6Gkt1ahJM ND1VCUvpJp7M1Be/kUgiQVawDqovcAbP/OsH3pAdiAfy3KkEyWd63Pg6eHqxyDLaMOc2 UPOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=V+oUzrIn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bf5-20020a0564021a4500b00435728c0adbsi13150319edb.158.2022.07.12.06.33.30; Tue, 12 Jul 2022 06:33:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=V+oUzrIn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbiGLN1q (ORCPT + 99 others); Tue, 12 Jul 2022 09:27:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbiGLN1p (ORCPT ); Tue, 12 Jul 2022 09:27:45 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 72EB8904DB; Tue, 12 Jul 2022 06:27:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=GeBXHzaR9hFbNi2rsIvOiJSjHq9fAExMloziB95EMUE=; b=V+oUzrIn7OyuULfkM8jc8uIeM/ 6PQQ1LvQ8inlh9SbFMk0HnMP9C+trqbaWo9si/3wpN+YtTLvrsfjFQM4iowRT9qt/ydUexQZPULb8 7EQ649RrQ6mfQzid78/+c5EmrfQtxkDfoyl4viwYarZGKVEPGLSJJa0kvaQCj+WUGqFA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oBFvL-00A3LL-JD; Tue, 12 Jul 2022 15:27:35 +0200 Date: Tue, 12 Jul 2022 15:27:35 +0200 From: Andrew Lunn To: Michael Walle Cc: Xu Liang , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 4/4] net: phy: mxl-gpy: print firmware in human readable form Message-ID: References: <20220712131554.2737792-1-michael@walle.cc> <20220712131554.2737792-5-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220712131554.2737792-5-michael@walle.cc> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2022 at 03:15:54PM +0200, Michael Walle wrote: > Now having a major and a minor number, also print the firmware in > human readable form "major.minor". Still keep the 4-digit hexadecimal > representation because that form is used in the firmware changelog > documents. Also, drop the "release" string assuming that most common > case, but make it clearer that the user is running a test version. > > Signed-off-by: Michael Walle O.K, this answers my earlier question :-) Reviewed-by: Andrew Lunn Andrew