Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4351576imw; Tue, 12 Jul 2022 06:34:59 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vXa0FgRPnATsliz54/Xk8dqanBZ/Dd2Ivg61J0kEjq+Nop1C6nm61Idx0YG9uKfTiFlNpQ X-Received: by 2002:aa7:db09:0:b0:43a:7353:94a6 with SMTP id t9-20020aa7db09000000b0043a735394a6mr32262191eds.191.1657632899040; Tue, 12 Jul 2022 06:34:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657632899; cv=none; d=google.com; s=arc-20160816; b=zVgb8y87v9wJiY8OI2cKmp9Jm8guyxvPKIGwtcfgc3stoD3XUuVGkVv0PhmSdC/Ycn H/mKj9Xx66X6t0Rrvycopa7oKdVi8KZd8LMTr7Uy0DV7zYhNxEFkj48GWvKInqqzv7hf ixUSZRXdz+vicvQpBJ5OXqXsBn9IhG5D2pzbYfWZVyM1o/EEM7YiR/LCWGrDeLpLbPj5 hJVlleywijYcGdVf4Yrdea7wbUwHLVxke8HUh46DCkDOn1RslD1lLRRPuEXRAd+30+zh EufNFPQtE4+PIQtEfq/+1ygyJNa7L/oxEZF7ds/DSoXBxGXVfnVrpGP4PPjX7/D5J4Bm 21pA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=JaJl3AgDn2VAYBI+dRS8tej3gYsLkQ/9hedEWeQ4VQk=; b=02CNbW5CLEv72oaczHJsVqY7RO99cEmQ/izL+t5zY+zhnXxsXcwu553QB3tJB/mqg9 gAoZ3Kp2bLrFBl25i/cEaV245e+bYotDXBp/8Mw9af6V30bfWwgx1e7AkHfNRVhvfFhV BccnAfBeTD8msebW9LZcnpm1KlagV7Z9B09j9BKE/UcNhm7AcZedvx8iFoSMgyZ9Jkyh 3shQZAYTZf3LsasNIRUQ31CA1oi6noCnDagqPfrnBCJPxdwmYlLFZ0eg4WZqEXJ3McvD gFQVvYcEF2oal6k+uo5Bhz4lt+agN7UV9yWqcl6yMPVfZCMJ1gZIhZrJYAqvTYkHg1LL wBIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZTu3PkoL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cs13-20020a170906dc8d00b0072a6bd1a193si16062984ejc.112.2022.07.12.06.34.34; Tue, 12 Jul 2022 06:34:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=ZTu3PkoL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233026AbiGLNbt (ORCPT + 99 others); Tue, 12 Jul 2022 09:31:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232992AbiGLNbr (ORCPT ); Tue, 12 Jul 2022 09:31:47 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 481A1B62A4; Tue, 12 Jul 2022 06:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JaJl3AgDn2VAYBI+dRS8tej3gYsLkQ/9hedEWeQ4VQk=; b=ZTu3PkoLHP3nfvt90STODSdGIe 0k81CXqOMdupSjRLoUzuk9Ep36uh9JDm6Al1xo03hRrKfmbc+cJZ+w3mfmtv8ouEUnU/aGXkW6yXE 68KP3dIjZwZsBKI9OO2hQnfpGrNjyyNh/NVa04Wh872NsQh1pT/EKhjIeMhI+rmRELg0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1oBFzF-00A3NI-EY; Tue, 12 Jul 2022 15:31:37 +0200 Date: Tue, 12 Jul 2022 15:31:37 +0200 From: Andrew Lunn To: Michael Walle Cc: Xu Liang , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 2/4] net: phy: mxl-gpy: cache PHY firmware version Message-ID: References: <20220712131554.2737792-1-michael@walle.cc> <20220712131554.2737792-3-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220712131554.2737792-3-michael@walle.cc> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2022 at 03:15:52PM +0200, Michael Walle wrote: > Cache the firmware version during probe. There is no need to read the > firmware version on every autonegotiation. > > Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Andrew