Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3780329f-0197-0e47-81a1-22ceae28fd1c@linux.ibm.com>
Date:   Tue, 12 Jul 2022 09:25:00 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v6 4/6] tpm: of: Make of-tree specific function commonly
 available
Content-Language: en-US
To:     Mimi Zohar <zohar@linux.ibm.com>, kexec@lists.infradead.org,
        devicetree@vger.kernel.org, linux-integrity@vger.kernel.org,
        linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc:     nayna@linux.ibm.com, nasastry@in.ibm.com, mpe@ellerman.id.au,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Rob Herring <robh+dt@kernel.org>,
        Frank Rowand <frowand.list@gmail.com>
References: <20220707172026.831614-1-stefanb@linux.ibm.com>
 <20220707172026.831614-5-stefanb@linux.ibm.com>
 <9fc4f6dc2ee497a4d4998df17392ac73ebdf3d63.camel@linux.ibm.com>
From:   Stefan Berger <stefanb@linux.ibm.com>
In-Reply-To: <9fc4f6dc2ee497a4d4998df17392ac73ebdf3d63.camel@linux.ibm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Precedence: bulk


On 7/11/22 18:04, Mimi Zohar wrote:
> Hi Stefan,
> 
> On Thu, 2022-07-07 at 13:20 -0400, Stefan Berger wrote:
>> -       /*
>> -        * For both vtpm/tpm, firmware has log addr and log size in big
>> -        * endian format. But in case of vtpm, there is a method called
>> -        * sml-handover which is run during kernel init even before
>> -        * device tree is setup. This sml-handover function takes care
>> -        * of endianness and writes to sml-base and sml-size in little
>> -        * endian format. For this reason, vtpm doesn't need conversion
>> -        * but physical tpm needs the conversion.
>> -        */
> 
> This comment is dropped.  Perhaps not in such detail, but shouldn't a
> comment or function description exist in the new function.

I am adding back the comment in v7.

> 
> Otherwise,
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
> 
> thanks,
> 
> Mimi
> 
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec