Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <062bf9e7-8903-5635-b681-ff42ea518031@amd.com>
Date:   Tue, 12 Jul 2022 09:56:36 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH] drm/amd/display: correct check of coverage blend mode
Content-Language: en-US
To:     Melissa Wen <mwen@igalia.com>, sunpeng.li@amd.com,
        Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com,
        christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie,
        daniel@ffwll.ch
Cc:     Sungjoon.Kim@amd.com, kernel-dev@igalia.com,
        kernel test robot <lkp@intel.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20220712113239.132905-1-mwen@igalia.com>
From:   Harry Wentland <harry.wentland@amd.com>
In-Reply-To: <20220712113239.132905-1-mwen@igalia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VjBZOG1vSWxzYVZwMENxQWhDQ2k0SG50RXdYL0pUaDhMZTFRM3dOWklyRDBt?=
 =?utf-8?B?bzNiTFdFQlU4dDRGTnRjSnJzTkRLZG42T25QRVUrTVlGcERVVE14aklEdVBO?=
 =?utf-8?B?d1ZYUHN1dmZxbjFHeFBKR0ltNmtQYk9lNGtBeHZlTkh3ZkR3NGtLUVh2MU1y?=
 =?utf-8?B?d2hVaG9xOGZlaTB3VHpxSmRJd0hyRU5vN1NlYkN0OXBzOXYzMUh1SlpySnQv?=
 =?utf-8?B?KzJGWVl0eUdsWndabXBXcDJzREFIOHRVUzYwQ3FUem5tajY5TDVKdHhnYVdF?=
 =?utf-8?B?WWFyaitUVnN3SWFHbENGYVdBbjl0cnNlMDdEUE8zY2VOcGQ1ZTJZN1JkS3Bz?=
 =?utf-8?B?SUxlZWxWa3hVcSt3QWNWSDVLc3UwUDVlQW1CMGVXSTluck1VY2hBMWp1cG5T?=
 =?utf-8?B?YUU1V2ZDMnRrOFhweWxZeWVTcXB4TVlKRC9qRGYrZmVnUmRodGRyZkVWSG9F?=
 =?utf-8?B?aXdyNGszT2U0ZGpTZjNlWTdWdTlZUzJ6K1Z6VjJSd2VwbnNKTEtyVm5CTzlM?=
 =?utf-8?B?MEErd1o0QUZyYjlWQU1yZ2s0cG5zZ3V1OGJlYnU5VStmb0Uza0J1NlhFNy93?=
 =?utf-8?B?azBQUEF3Q0NocmxlNTZWWUE2bUFKREpiV0ZSam5PUzBncVNmRkJwWm10LzE4?=
 =?utf-8?B?Ri9Ic1VVUFl5UUwxVDNTRDBqZTk5VXUxSnRpNGhhakdPVDI0VGdHdHhvQytW?=
 =?utf-8?B?WFEwcldzWjlCVTlOdjVaNmswTHlRZ29KTk55ZHhHczVOb09qUDZRYlhHdjQv?=
 =?utf-8?B?TSsxNDVLQ3NyQ3RzaUpHYlFNblRQMXRNbHJmRWFsWi9Wbk4zNkczclNJd3BP?=
 =?utf-8?B?Nm11WHQrY3JPNDhmSVRRdjAzVUhnWm95dDNySThKdjA0Q01DUHhyWGlhRmFF?=
 =?utf-8?B?VmJxQ1B0MW1wZ2ZXVTlyOXZMc0xBcDkzbXFvcjFoM0gxdHc1bEF0Vm9PcTVi?=
 =?utf-8?B?RitLUk1QTXJIaTBLTmZQYzNMVTU2T01RZXliUkpLSm9iS3BmbFBBR1hMcE1u?=
 =?utf-8?B?Tklvdm9RYWhYUlhmS3h1M0Vwb0l6RDdDVWVBODlKVndzZ2RzN2JBRU5IVHRW?=
 =?utf-8?B?em1tak9sa2N4NDNMK0ZId3lja1pOUkgvQVNsUWlQOElmZ3VvL1FGN0w5djl4?=
 =?utf-8?B?N2Qwc0poZEZQWkJTNnlsOHpJdUt0RGMzRS9sd29jajA3NllyeTlxaEFIOG5k?=
 =?utf-8?B?NWZsYVhEenczOURVM0krcnpYaExrTGZGSU1hMDU0ZytOeGhlelpvOVUrNDRu?=
 =?utf-8?B?TXNkUWN2aTI2dTdLcGRjN0VvM29EY0ZSN0oyVjVjUzVWUU4rWEtTTkZsSjR1?=
 =?utf-8?B?TkYxZUhJY29PTFNwNnZ1bnFEci9PaWVyUUdrRm52d2k3NTJUUnhGdUhqMGFu?=
 =?utf-8?B?VS9uaUhNOWFqVXN4ZW00WE5xbTFwVTdrU1V5UTMxNFcyUTZOSjl2enpmNGta?=
 =?utf-8?B?emtqZTV0T0dWbDZZUFpXamRmeHp1bENzV3RxaXFQS1RsOFk5V2t2UG9QRGZy?=
 =?utf-8?B?NFBXTDBXamUzTG1HaEliV2FTaHJnTGR1blkwblhlQjQxemU5dE1uQWhodlpV?=
 =?utf-8?B?cG1rLzNOTmJoZUgwaTZyM2pkOVJoZmlKYXowamRmTE5hVThEeFBlaVlFQTJK?=
 =?utf-8?B?NXJvam5XTzZCS09mME1LREUyblZycXhTRGV6cFMvNEFuZ2JDS01hUmJLSUpO?=
 =?utf-8?B?dHRiMldxL21VZGM5VWhkdExXNW44MXMzMGJpMW92eDdDaDdxSzR3aC9jT1pF?=
 =?utf-8?B?Y1FJOG5wY09GbUlLVFdFZnltTGhrbm1pV3pOd0dBak8ra1JvTzF1OVNPVjNv?=
 =?utf-8?B?VngwZmxPbTkzb21mTjhXNDU3NUVYb2NrSVF0SlNYS2MxZjdiZm5UZGMvMkFo?=
 =?utf-8?B?SGR0UG80OWR4WmxLaTMvYlR4WWg2L0hyMXJKakJTblBNd3poUVltakxTRml0?=
 =?utf-8?B?a0hIOThiQVl3UldIWExZWVBIUlpkY2ZFMng3RjJsbDJ5bUVwQXEvN2JBWE4y?=
 =?utf-8?B?QVFSUkxnY3hUM0VuRlowVUZ4aDFQdnlJNjJ6WVlGUHNxRmxERzJTb0Ywenl4?=
 =?utf-8?B?czkzeWpPb0ZvQzdxS2xES0h3UStjVzVOTkp6ckVkMjhoU0piQmpFQzJsY05k?=
 =?utf-8?Q?FdA2sJH4uxxiiVgdXm0GWXLdq?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c49ee1b4-7cfc-4af7-8620-08da640e5863
X-MS-Exchange-CrossTenant-AuthSource: CO6PR12MB5427.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 13:56:40.4864
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: luvtCZpTap83/0ld3Bi1CCOo0+lcjGkXr2HZFI2hJ3ptVWm2PhmM+vmbxtwMaj6XD8aETlEdlYk7a6RrPiYaUw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2889
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-07-12 07:32, Melissa Wen wrote:
> Check the value of per_pixel_alpha to decide whether the Coverage pixel
> blend mode is applicable or not.
> 
> Fixes: 76818cdd11a2 ("drm/amd/display: add Coverage blend mode for overlay plane")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Melissa Wen <mwen@igalia.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index de1c139ae279..25cb833b267c 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -5486,7 +5486,7 @@ fill_blending_from_plane_state(const struct drm_plane_state *plane_state,
>  			}
>  		}
>  
> -		if (per_pixel_alpha && plane_state->pixel_blend_mode == DRM_MODE_BLEND_COVERAGE)
> +		if (*per_pixel_alpha && plane_state->pixel_blend_mode == DRM_MODE_BLEND_COVERAGE)
>  			*pre_multiplied_alpha = false;
>  	}
>