Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <5caa08ba-6211-f2ad-6c78-4201ffbed8a4@amd.com>
Date:   Tue, 12 Jul 2022 16:57:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2] drm/syncobj: Fix sync syncobj issue
Content-Language: en-US
To:     Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
        jie1zhan <jesse.zhang@amd.com>, broonie@kernel.org,
        dri-devel-bounces@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org
Cc:     Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, ajitkumar.pandey@amd.com,
        lucas.demarchi@intel.com, nirmoy.das@linux.intel.com,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        open list <linux-kernel@vger.kernel.org>
References: <20220707102953.769684-1-jesse.zhang@amd.com>
 <22a21338-305d-bdf7-0079-df67fb030fc7@amd.com>
 <ea892ffc-4a03-7772-6d99-85a356a3738b@intel.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <ea892ffc-4a03-7772-6d99-85a356a3738b@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Qk1WNUxBVVhVYnF6T0QrOHdpSnA5UllFUWd3WjdZbm1ZcEp2alFya0NCZGJz?=
 =?utf-8?B?YUdxaE1EUkRjZkdPSXpUNlpndG5zT2l0d0ZJYklqaFE0bFpHaUo3VGFoK2pn?=
 =?utf-8?B?cXNyVkUveG1YNXpuT1FLRGppcjFvYlJYYlBrZHk0M04xR1JIUHdnRFYxVjZP?=
 =?utf-8?B?T05xb2ZCRUtqdFk3Yk1wVm5RWlFTb2lZUjFpUEI5cnZyQWZmL1hoRHRHK1Iw?=
 =?utf-8?B?b3p3eEFlTTc2TDZ4dy9SNmozcGVtSXpFZzgyNHlPMzhhUzRLejR6bEx1REda?=
 =?utf-8?B?WUo0TzQ0M0h4aHMwTkVjcjhrcGRTeTR1Qm1oSXNWc1YrdVZOSEtscXByOFZq?=
 =?utf-8?B?cWFEV0g2M1haUG5IaE5oWGNZa1hIeXZsM2hSZUJSMk83azNMY3A2ZlJ6RFRD?=
 =?utf-8?B?eEd4OVl0S1J3QStNU2dDek8wT0xISU1yZnlkaCtnd050aHluUHAycmhuUTcy?=
 =?utf-8?B?TTQ1c3dUOUs0emZNczRUaWhpYTExSFBSSGt6bDY4TzJoeFdDRXVKbFNNUUV2?=
 =?utf-8?B?N2NVWTVac0dTV3VkU2p1Qk1WQmZEUThXeVdBTm1UUWY2UklreE1Oa3BTVVFE?=
 =?utf-8?B?QUJFT3pDaHhOcW04WjBhTkgwd0xMNm02TU9tMi9RSC9lUGk3NmFpaGtjd2Ns?=
 =?utf-8?B?SDQvUUlSSWFvOTlmWlpuem5Yc1RoaE9lL2pCRXplVU8wL0hLVElzVDVYQkU0?=
 =?utf-8?B?b0dETjJtRWxtcWZuL3pCWkFsQ0pGMDhFRjRFKzhQekdoMTFLWTBsdlBJbmRv?=
 =?utf-8?B?TjRSeGRLUkI1OU1ERWcyRWdyc1k5bVppeGR3THFGSUJEbmJ4T0J6eStRSGxr?=
 =?utf-8?B?dFRoSCt3QndEMExVRy9DVkpCb2phUi81Qnpvc3BMV3hjUkl6cVJUemNkWEta?=
 =?utf-8?B?OUxNZHRJeDZKZjY5cElVcFdxR2gvdWJqbHNZWE43YVFrdytIYkMvWE9hVzA4?=
 =?utf-8?B?ZFRHY0N4TTI0dzl6cktJTFJUQTA2WW95bko2T1FkdWRaNDBzQmxGUndkWHR0?=
 =?utf-8?B?RmtQamJ0VlQ0ZDhtaUh6eWVqb2RWUW0yNU5xT2pLMjh4c3I5dTlaYkEvWUhC?=
 =?utf-8?B?Nll4NzZyb3pPaFFOK0hadFVyL0lpdGtKc0RzR3B2VTRrOE03WUg5NURwbWtC?=
 =?utf-8?B?L2xMOUdBd2EyZ092VEF6R3dXRXN1U3cwUzFhQk9qTjAzSVFRREZvalJHOVFD?=
 =?utf-8?B?d0pTMXdsU0JQZ1paV0VxVkF2QjdCeDdoQ1J4TzRmVjlCT3E4dHVvVFA0WXBw?=
 =?utf-8?B?cmh0U0QwWWIzTjRGWXZlY3lOV0N2Rm9tZHU5ZlZiVllKRStVbFhuc0NkdlFX?=
 =?utf-8?B?bEdKWTJFNHlVMWo5a2lrNWIrWnNjMGdmVWdFNm5XeG1yeWdLUWc1QjVCZWMr?=
 =?utf-8?B?OU1FT0hPNXFRcU9seTlaZlRJY1BBQi9jaStMRFJlV3pneWxTbGhiNy9pRkdQ?=
 =?utf-8?B?WUJqaUh1UGJNQStGdk54RkpEUXk1MHRXbnN1N0xoblNHM2tLbTVOWTNVcVEv?=
 =?utf-8?B?S2xyZjhBU1pkN3RVVklpZkFMRGhwWU9xcGI2TlNKL0dKL1ZkSm0vNkR6Ukk4?=
 =?utf-8?B?MFNDdmora1JyU2FBRUc4MCtRdGZlVEdoQjhpRXhJMktWS2ZHLzhrTzlrOEdq?=
 =?utf-8?B?MEZSUFVrWEthdXV4d0ViaFkzSGo0MjNOekd5b29ZSS9FM0tTMzlrbXpMdHdv?=
 =?utf-8?B?Y0tUdDdHRU81aDBBay83Ungra011OEVDbVFQZHBDYVRHdTJhZW9naEs4M1p6?=
 =?utf-8?B?dHlESHRsQVJBbzBGN2RJRHF1d3hRTlp1SFg0VHI5Tk1jeVlFdUtqOWtXOFYv?=
 =?utf-8?B?REZ2OFhnR2xYRm9VSlo3K2lwQUh5aCs0UkMxWmhic1JWVlJWeXBKd2IyeVpS?=
 =?utf-8?B?RXRMY0Uxajh4c2NiZFRXcHRzcmtMSXlvWEMyRWJ0T090TWx6WFh5RUhtYTdo?=
 =?utf-8?B?WWtKZmtiNHUwczFYM0w2REMvTW9OQklVUjhxTzdaSW1rWjZSY0dwcFhTdVB4?=
 =?utf-8?B?RVZGMmZEYzJlRTJjbzNrbEZNQ2NKRnJaZXpDVmJQbzM5OFdRNDIzVUpxWVBC?=
 =?utf-8?B?cklQeFQ3em0rYU04dHVsZkUvUGFTYmpGM0xaOXZ1TDNtZWQ4KzFKQytzRC9W?=
 =?utf-8?B?R1ZxV0E1WXc5VFBnSDNuNnoxMjRZSVFnTnhLTUMyZFZ2ekpkTzBuWEJySGxW?=
 =?utf-8?Q?kzksUhjckvNH/W9Qx1Itwd4lpB2bxM84+8eRk5U47OJ3?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 044e4067-11f7-46f1-ad25-08da6416e6df
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 14:57:55.4010
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UnWVDyc+yrUaCr1Ywt4EXn3N19xR5oParLXAF38w5Hk2plYziQg02io/t9wTq1mE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4165
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Yeah, adding dma_fence_enable_sw_signaling() is the right thing to do.

The question is where to add that? Usually right before the fence is 
returned from the object or queried from userspace would probably be the 
right place.

Regards,
Christian.

Am 12.07.22 um 16:22 schrieb Lionel Landwerlin:
> I'll let Lucas comment. I've only looked a little at it.
> From what I remember just enabling sw_signaling was enough to fix the 
> issue.
>
> -Lionel
>
> On 12/07/2022 13:26, Christian König wrote:
>> Ping to the Intel guys here. Especially Lucas/Nirmoy/Lionel.
>>
>> IIRC you stumbled over that problem as well, have you found any 
>> solution?
>>
>> Regards,
>> Christian.
>>
>> Am 07.07.22 um 12:29 schrieb jie1zhan:
>>> enable signaling after flatten dma_fence_chains on transfer
>>>
>>> Signed-off-by: jie1zhan <jesse.zhang@amd.com>
>>> ---
>>>   drivers/gpu/drm/drm_syncobj.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_syncobj.c 
>>> b/drivers/gpu/drm/drm_syncobj.c
>>> index 7e48dcd1bee4..0d9d3577325f 100644
>>> --- a/drivers/gpu/drm/drm_syncobj.c
>>> +++ b/drivers/gpu/drm/drm_syncobj.c
>>> @@ -920,6 +920,7 @@ static int 
>>> drm_syncobj_transfer_to_timeline(struct drm_file *file_private,
>>>       if (ret)
>>>           goto err_free_fence;
>>>   +    dma_fence_enable_sw_signaling(fence);
>>>       chain = dma_fence_chain_alloc();
>>>       if (!chain) {
>>>           ret = -ENOMEM;
>>
>