Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 17:33:19 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kernel test robot <lkp@intel.com>
Cc:     Dan Carpenter <error27@gmail.com>, Jason Gunthorpe <jgg@ziepe.ca>,
        kbuild-all@lists.01.org, Yishai Hadas <yishaih@nvidia.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Alex Williamson <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Leon Romanovsky <leon@kernel.org>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] vfio/mlx5: clean up overflow check
Message-ID: <20220712143318.GQ2338@kadam>
References: <YsbzgQQ4bg6v+iTS@kili>
 <202207080331.FTVSHxW8-lkp@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202207080331.FTVSHxW8-lkp@intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PFp4261S14GEPNR1I0DHtT7LmR7EvA8L7N/ic4AZARLhA859UBzg9K9emDAy?=
 =?us-ascii?Q?KUJyEbenJoXrmmBRYG2Eh4kST3IYDxyuu6C5IXGCXhV++hF0GH6vzwQ93yDa?=
 =?us-ascii?Q?vJz8G6XthydzHh2qd+Dyd3RjAEuds+0paOPsDmdVLReEyIE6Rrc4qgRlb0Gs?=
 =?us-ascii?Q?9gEolU3ktV+WqiBMYWVaxNeJGpT2qfgn8bWbV5EA7ggEohYGB5F29H32J7wu?=
 =?us-ascii?Q?H8R6hkCm2B8q5JifyfNw2poldjaZDKsVuTDJ18orMvPt71JCGNGcl/iQU1yU?=
 =?us-ascii?Q?HJjTDttPQcrxoGfCgz2TcDJ6mQJf4Au0+waEAJ4j06wuCNqWTbHORyBJiRAc?=
 =?us-ascii?Q?Xo+QvkwWYtqObqPOQihsENcWtOjSAoC3hOH8OCAMaVxxQ8kriGP3rUvKX8bM?=
 =?us-ascii?Q?4wwJ0dXoPhwfHNTAYxamwlbNXfRlAVJY+m9V5Lm20MCcHXn9X39/xgriF5T+?=
 =?us-ascii?Q?2mIXY9mIhmbmbqLxXvLF6SHKhy4UXwWq5inbENEs7wZvqRycqsdDKwssgAHu?=
 =?us-ascii?Q?0Vb87FC53Va/jDGG516pURlpycuvsslU30vby7NS5G0fWDX9JUakmT6JvUxE?=
 =?us-ascii?Q?7CgFDCdmkAoDId7ZrWIHhn1LP1UpHTCUGZrU2jCU3eQgNqnVE1gOnCWqlpkO?=
 =?us-ascii?Q?HrkF7vAC0K1w5s3iuPVp/V9kp+NTdxt2Zl0+IuqX1qDi4BqM4GCCdCnotfwR?=
 =?us-ascii?Q?L1xxqnV8aRccMjexlus3BJkys6cfIVUTPKX2tBGwqFFuGgOFrQH2r6Dexhi+?=
 =?us-ascii?Q?yTId0JAf1/+6vhVRyBgXibql2uRil6zN2khBPHwHLr4QeLwx7Zxbl4p1X/P9?=
 =?us-ascii?Q?csVljsrU36V2H141RyKPT0nTrs2v0eURSNcUC3B94nzkXWbrwKENgtg+QbnW?=
 =?us-ascii?Q?9OToNBt/N6HqKDfvy9HMgjRf1DHwGaxMyHoKkbvER9hieXlkFsv741/pK3Hq?=
 =?us-ascii?Q?1wNDMAkJZTgOwgrVRydjIVtOSi1Q5YKX6p9F96nPURuFjVChwbp4IVg2ouW0?=
 =?us-ascii?Q?3zbiXiQ++Qe6DBXchDEJIDVIB8g062R9NLBN0WcRS/ZWu8mBEgKlmPFy1u8/?=
 =?us-ascii?Q?DJsRZf5KocQWGbCh0kMlu4T4DeF95N/4TDhzp1K8QR5M6Jg7vfflwZ8MIYiu?=
 =?us-ascii?Q?HQa4VxJqTXlzi7oCyRtyw5G8PvPMdTw3lakdW96XjZh7nwQvhE3Uc2fQ8l+b?=
 =?us-ascii?Q?eGL6RheKruBOgJZwzX83JYd3N27glxznLI35YNWyvJwUCS/NLKKlSY5/dc9t?=
 =?us-ascii?Q?YW3Pu0XTiAJO18pHfESHjDphohBSsqXpsvEY3Hq/qpHNzPPbWbJkAujFBsgQ?=
 =?us-ascii?Q?r0v/Le4ybIxTdR3PakRQqhUO+hT6RQvHO06pvq9TICPENFNBiOVfJ/WHLfAq?=
 =?us-ascii?Q?hxZVdDxC5Gd8Cbs5AJ8dMBo8WpSQwaCR28kc7wP6VF72oST0k3Ku/EwOMa57?=
 =?us-ascii?Q?SPQZiolvu1ZMRBtdHl60bPMgovOQU1uinyYMUlvFZdl8fIEdywfMpf08zaN6?=
 =?us-ascii?Q?DFgU6qy47NTgj0pOmcv39dvT4wsA1ZpXEXKKvDoLTqmPsxXG+MUmlda83gZF?=
 =?us-ascii?Q?daX3kUZXHQNvGMCIsuG59ZHGlIvVmuQ9UWTdoVtwLGivaPSsHQAroCwDVdei?=
 =?us-ascii?Q?Gg=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d9df0652-0b60-42c0-acd6-08da64137e4c
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 14:33:31.4488
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Bnma7jdngo7Hzym7/3CpP2idjyu0zhjPtLz8PhaaF2V+E+vNQQUDaV5IwJQ7RJ49cHYsV1Gx3Bi6kCriz3yZA8rXW8PoK+loiCzCHC+FJmU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4059
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-12_08:2022-07-12,2022-07-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207120056
X-Proofpoint-ORIG-GUID: ZoWtc1li90CmvryBCoJWCJ1F2RZE7KaO
X-Proofpoint-GUID: ZoWtc1li90CmvryBCoJWCJ1F2RZE7KaO
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sorry for these!  I need to resend, of course.  I'm sligtly delayed
because it was a three day weekend.  I will try do that tomorrow.

regards,
dan carpenter

On Fri, Jul 08, 2022 at 03:37:32AM +0800, kernel test robot wrote:
> Hi Dan,
> 
> Thank you for the patch! Perhaps something to improve:
> 
> [auto build test WARNING on awilliam-vfio/next]
> [also build test WARNING on rdma/for-next linus/master v5.19-rc5 next-20220707]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
> 
> url:    https://github.com/intel-lab-lkp/linux/commits/Dan-Carpenter/vfio-mlx5-clean-up-overflow-check/20220707-225657
> base:   https://github.com/awilliam/linux-vfio.git next
> config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220708/202207080331.FTVSHxW8-lkp@intel.com/config)
> compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
> reproduce (this is a W=1 build):
>         # https://github.com/intel-lab-lkp/linux/commit/44607f8f3817e1af6622db7d70ad5bc457b8f203
>         git remote add linux-review https://github.com/intel-lab-lkp/linux
>         git fetch --no-tags linux-review Dan-Carpenter/vfio-mlx5-clean-up-overflow-check/20220707-225657
>         git checkout 44607f8f3817e1af6622db7d70ad5bc457b8f203
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/vfio/pci/mlx5/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from include/linux/device.h:29,
>                     from drivers/vfio/pci/mlx5/main.c:6:
>    drivers/vfio/pci/mlx5/main.c: In function 'mlx5vf_resume_write':
> >> include/linux/overflow.h:67:22: warning: comparison of distinct pointer types lacks a cast
>       67 |         (void) (&__a == &__b);                  \
>          |                      ^~
>    drivers/vfio/pci/mlx5/main.c:282:13: note: in expansion of macro 'check_add_overflow'
>      282 |             check_add_overflow(len, (unsigned long)*pos, &requested_length))
>          |             ^~~~~~~~~~~~~~~~~~
>    include/linux/overflow.h:68:22: warning: comparison of distinct pointer types lacks a cast
>       68 |         (void) (&__a == __d);                   \
>          |                      ^~
>    drivers/vfio/pci/mlx5/main.c:282:13: note: in expansion of macro 'check_add_overflow'
>      282 |             check_add_overflow(len, (unsigned long)*pos, &requested_length))
>          |             ^~~~~~~~~~~~~~~~~~
> 
> 
> vim +67 include/linux/overflow.h
> 
> 9b80e4c4ddaca35 Kees Cook        2020-08-12  54  
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  55  /*
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  56   * For simplicity and code hygiene, the fallback code below insists on
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  57   * a, b and *d having the same type (similar to the min() and max()
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  58   * macros), whereas gcc's type-generic overflow checkers accept
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  59   * different types. Hence we don't just make check_add_overflow an
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  60   * alias for __builtin_add_overflow, but add type checks similar to
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  61   * below.
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  62   */
> 9b80e4c4ddaca35 Kees Cook        2020-08-12  63  #define check_add_overflow(a, b, d) __must_check_overflow(({	\
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  64  	typeof(a) __a = (a);			\
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  65  	typeof(b) __b = (b);			\
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  66  	typeof(d) __d = (d);			\
> f0907827a8a9152 Rasmus Villemoes 2018-05-08 @67  	(void) (&__a == &__b);			\
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  68  	(void) (&__a == __d);			\
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  69  	__builtin_add_overflow(__a, __b, __d);	\
> 9b80e4c4ddaca35 Kees Cook        2020-08-12  70  }))
> f0907827a8a9152 Rasmus Villemoes 2018-05-08  71  
> 
> -- 
> 0-DAY CI Kernel Test Service
> https://01.org/lkp