Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [RFC PATCH net-next 2/9] dt-bindings: net: Expand pcs-handle to
 an array
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Russell King <linux@armlinux.org.uk>, netdev@vger.kernel.org
Cc:     Jakub Kicinski <kuba@kernel.org>,
        Madalin Bucur <madalin.bucur@nxp.com>,
        "David S . Miller" <davem@davemloft.net>,
        Paolo Abeni <pabeni@redhat.com>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        linux-kernel@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org
References: <20220711160519.741990-1-sean.anderson@seco.com>
 <20220711160519.741990-3-sean.anderson@seco.com>
 <ecaf9d0f-6ddb-5842-790e-3d5ee80e2a77@linaro.org>
From:   Sean Anderson <sean.anderson@seco.com>
Message-ID: <fdd34075-4e5e-a617-696d-15c5ac6e9bfe@seco.com>
Date:   Tue, 12 Jul 2022 11:06:20 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <ecaf9d0f-6ddb-5842-790e-3d5ee80e2a77@linaro.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?d3RTSEFyT0tVUnJyMEZ6NVlmeVZGV3o1V0lvNEFPVlV2R1V1Z08yL1ZqeEJQ?=
 =?utf-8?B?anAxZWhxZ0JvNVJzbUxiaU1Ddk1kUTBmSGVQQUVSTndjZG5ZdnBPQ2x1d29l?=
 =?utf-8?B?NGFMYlRuUHg3VlRzY2lTRkczWUtGOXk5YW9qYjRTNEtrQjRlU3FWWEkwRUV4?=
 =?utf-8?B?WXN0WTcrVDZ1SUxIamhUNjVTbGkvS01WK2xSUXArUXRaeDlGMGxVWnJPV3VP?=
 =?utf-8?B?ckpyRm8wenNUWnZETHFLajNCZ1NmY0VNVlpIY1VSd3lCYUk3K3FXQjg0cXpv?=
 =?utf-8?B?ckM1VUdxdHFKTXErOWhzZ2prNzJlbXpNYVFVcHo1R1JrNDVQZ0tVOXhVWG9t?=
 =?utf-8?B?Mk81ZWpLZTE5dCtXUjlCMUpKdmVWZkVvdmZzTWdwQzBqaWRRZ2NpYUxtRnlm?=
 =?utf-8?B?MkQrT0RVbDFOQkx5WlhlU05BdDJSdmhjWUFqZkxVa3pwczJESVM4UTQ0MUpy?=
 =?utf-8?B?Ynd0YnFWM2RoSVhmMitKSmxCZ0Y3R1B5M3dQRGRMNzUzVk14d0pZd2Q5OFpr?=
 =?utf-8?B?bXZCZ2taY3ZQKzJOeDYwME9adjdhYVdpODdtL1BGd1MyS0FkWnhUZWUrMVdI?=
 =?utf-8?B?R1o0ZjI0djR1Uk82QjhGTTlQYkpSYmFIbXZZL2ppY0xQM3JzS3lwL3NzeGE3?=
 =?utf-8?B?Q3EzSW5xcFpOUGhTZ1ZEcG9XS05aNkhocDlBT29IenhYQTNCcXBWbzBVM0E3?=
 =?utf-8?B?T3BOcGkrNkI1WlFrcFBBN1lwMGt2bFdKZGxoTnQ0NGcxMmRWbGJpZnJYZEl5?=
 =?utf-8?B?TEQ2L1U0dFFtV2VXWmRndzAyeE9sMVlhWlRDVkQwMGRVenZDa2RnOUltVllm?=
 =?utf-8?B?aXVidWhuWjFYWVJNK2dlMHNCVXhzai91dnpWcmpUVHdPR0I1ckZ5aWVwVndP?=
 =?utf-8?B?ZVNSdHdtd2NINHZhNG5vbHA0ckFUWXFMeXl3ZzhWdUZLcnNZNHcrQ2d3TWJ1?=
 =?utf-8?B?V01IeGVqR1FvMXQ0UytnWndoNGZvbDR0RHlvRGFpcTk0b2YzUEtKajJHTHl2?=
 =?utf-8?B?VEhTNnFUTFBHV1ZvWFQyQ2Zsdk11RFNOSERBSGRGR3RNdXpnNmVmSzEzOENu?=
 =?utf-8?B?UkVJTngvckRyanJKTXY1Nm1mQkZlWkw3R1BSdHIwWVlmVStpWHBtYjZ2Zk9u?=
 =?utf-8?B?TlluNHNTc1YvY1YrOGZNUGsyNHlkUTJuK1BWWmFVVU1ZRjgvUE1VUGFnVnBi?=
 =?utf-8?B?NmpWb3VQYnlYSk9RYWY2VWQ3TXd3RmF4THNISVRoVU9vdk8zaTV2Q0t4ZzVD?=
 =?utf-8?B?KzJPWmJIZ0d5c0N2eTNmemVDZThLaGtkY09Fd090eFE5M1pJUFNJeU5uNjBx?=
 =?utf-8?B?UUdKUnZqS2h3NzQ3M29sQzhkQVM1bHA4Z1J6Q2V6K09ucmtheXJXZlpXakZM?=
 =?utf-8?B?NWZQSVZOWk40OGh3bjFvd2c3ekd3RVRmUXpHeXpsZGQvRSszc2Q5c1dvMEI2?=
 =?utf-8?B?ZEd3WHBSTXJMcFpnM0VJZzBnZi9uVnBFbUNPeVJJbm5Pb2JuM3NPdVhhdjF3?=
 =?utf-8?B?bTFSQzgwRlJnVVo2V0RYbUZuMlFyOUFQaFlvZjJNOWpVdjAzYkpsSGFQWDU2?=
 =?utf-8?B?WEY5dHQxeUtuZ1pHRW5GVnFUdmhtbW1XOFMzT3d6am1VbmY1QWJUZ0t4SzJI?=
 =?utf-8?B?Wm5QNzgxQmpQakVWRlZ2WXFPbEZWaVg1WEJXdmVrc2lQaDYxendhanJiQUNj?=
 =?utf-8?B?d3FBdDFOa3dPclFjSGJjODErVnRPQW1hYy9YQms4Z29vTzhuWmZMWXpFOE9Q?=
 =?utf-8?B?ZFlHMnJ0YmpLaFJyU2w4UU9pZFoyT05UQmlYWWw4UTRLRkJScGhyeVdvNDZa?=
 =?utf-8?B?WENyUjVDdzJZcDE3TDlzYlB1bFBKNnowKzVBcExhNURFZXBYTmVrYjRQSUlz?=
 =?utf-8?B?dGtUQkVaQ3ByQUhIMnE0bDFHZVdvd2x2NXdKUkFjcktCYWY4YmZybHM5UE5x?=
 =?utf-8?B?WnJGcjdQSVMxZ2FFRTNPbEk3eHJPd2orWnBNb21CcTZHWjBmUVozOGNRUkRs?=
 =?utf-8?B?MHpmV0l0Ri9ZSzhFNDBaWmw3TUFuUGIvbGR1MnhESzJmME9ESVRxd0ViWml6?=
 =?utf-8?B?Z2FXQndVT2ZTMzE3NGRqREdudzZYM29sU3ZxWWpoSC9qZk0wOUdQWkpST2Vr?=
 =?utf-8?B?MjFRRGNJdVJvcS95S3h1SGVyc2JEMTRBelNaUDFJbXZJV2RmRWRkL21pOFZr?=
 =?utf-8?B?R2c9PQ==?=
X-OriginatorOrg: seco.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b9a277b7-bf6f-4d47-60f6-08da6418165a
X-MS-Exchange-CrossTenant-AuthSource: DB7PR03MB4972.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 15:06:24.5079
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: bebe97c3-6438-442e-ade3-ff17aa50e733
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zPiqIBJpXRP3RnIWv60w2gaJWU9XhrOj8eoPZ95Y9WpLjTS95Y/3vqZTIt82e5tPHnRXsQ2/g0ZNGvWg0/M6wA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9PR03MB6961
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof,

On 7/12/22 4:51 AM, Krzysztof Kozlowski wrote:
> On 11/07/2022 18:05, Sean Anderson wrote:
>> This allows multiple phandles to be specified for pcs-handle, such as
>> when multiple PCSs are present for a single MAC. To differentiate
>> between them, also add a pcs-names property.
>> 
>> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
>> ---
>> 
>>  .../devicetree/bindings/net/ethernet-controller.yaml       | 7 ++++++-
>>  1 file changed, 6 insertions(+), 1 deletion(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
>> index 4f15463611f8..c033e536f869 100644
>> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml
>> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml
>> @@ -107,11 +107,16 @@ properties:
>>      $ref: "#/properties/phy-connection-type"
>>  
>>    pcs-handle:
>> -    $ref: /schemas/types.yaml#/definitions/phandle
>> +    $ref: /schemas/types.yaml#/definitions/phandle-array
>>      description:
>>        Specifies a reference to a node representing a PCS PHY device on a MDIO
>>        bus to link with an external PHY (phy-handle) if exists.
> 
> You need to update all existing bindings and add maxItems:1.
> 
>>  
>> +  pcs-names:
> 
> To be consistent with other properties this should be "pcs-handle-names"
> and the other "pcs-handles"... and then actually drop the "handle".

Sorry, I'm not sure what you're recommending in the second half here.

>> +    $ref: /schemas/types.yaml#/definitions/string-array
>> +    description:
>> +      The name of each PCS in pcs-handle.
> 
> You also need:
> dependencies:
>   pcs-names: [ pcs-handle ]
> 

OK

--Sean