Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 17:16:02 +0200
From:   Henning Schild <henning.schild@siemens.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Linus Walleij <linus.walleij@linaro.org>,
        Tasanakorn Phaipool <tasanakorn@gmail.com>,
        Sheng-Yuan Huang <syhuang3@nuvoton.com>,
        Kuan-Wei Ho <cwho@nuvoton.com>
Subject: Re: [PATCH v3 0/1] add device driver for Nuvoton SIO gpio function
Message-ID: <20220712171602.1e7c49f4@md1za8fc.ad001.siemens.net>
In-Reply-To: <CAHp75VeYHi8XTf3Y6HMmitVvuvF2uiWdSzpiKFji5SfV20HqpQ@mail.gmail.com>
References: <20220712143237.13992-1-henning.schild@siemens.com>
        <CAHp75VeYHi8XTf3Y6HMmitVvuvF2uiWdSzpiKFji5SfV20HqpQ@mail.gmail.com>
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BsaONZPWkq6aHSa9wsZP6xDhnmye+Y1U6hJAHC9kfT8iP85qp68B0DKlBk36?=
 =?us-ascii?Q?OEsOnGrwcW3DHkjhShm3/apeeKMDa98MYh8t2Diu0MvC7jDmSjeI9bXE1tlN?=
 =?us-ascii?Q?T3Ay8UR0jUitnolzUO0ETKLMIiMCGBIm+2pMi5nyAjJxQse1WAT+RS9sxiDb?=
 =?us-ascii?Q?0M7jB1lZuOJGAlTSPWGPWGDPOm+UAm7qUvpb0nsU4bN83SvgaM0xS2pXbvoo?=
 =?us-ascii?Q?HMhBP61xphKuRyIExyJbr2bZsIix4iidnfPGwuxzjt1qitsZ5cK7UCYli5h+?=
 =?us-ascii?Q?C6c7ziGp8cPD6Ovn2mqHkI7tGmaS69++X40b7T9nWltYLfS+Fd+d3bYXIxn+?=
 =?us-ascii?Q?FIwg+LdCYk1hdHD9kPzJiDeiCVaVZFSRPli6z0byLco6I4LNGOxttg1SpRX4?=
 =?us-ascii?Q?BS4B35XLGJsYaHHvqnnrJ9mtKfFPzVibL66tsvLhkK1UkkU+gW7GvoTZXun8?=
 =?us-ascii?Q?mGPNaE7WlxTu4ZCIXlKBHSSTAOlo1HitRZypNJnSWaFf3GPFDUzJNgL4pSGB?=
 =?us-ascii?Q?tj/TnYi9/ZDTagKsfGDos+O4vuvzzSeQ0XFxS6GlAB1ON5YJOn4tHSP+ygE5?=
 =?us-ascii?Q?ONT93I+NJHJeWv9RU6qTe6BXeOqUAe8SClgXfcLHAykozVC31ATjMMhfBDDx?=
 =?us-ascii?Q?s4rVRxE27rRzPsIN7bJOI9asKZMWIs60cVi4cebjgY7sY+QH8WKhCSiwuqrd?=
 =?us-ascii?Q?tjjB8FwLeaJ1OPySwbFa/ba1SrnqFR70nJC1yKwChETqdLm5ss8CHEK66Bhj?=
 =?us-ascii?Q?5nwZTXhwsi3V6fWuwqW8HvGgi5AmPctnooMaAEait7i/ZeYSx6KqX5XtTIae?=
 =?us-ascii?Q?NIAyQMZT1JBNlX43r/vY5dl7rorZO7kMMc/IflfL/Np628UUJDS40UkroDPO?=
 =?us-ascii?Q?gJC4vMcl5rnn+jQggTwBGxRxhadod0IH+3ERVTBdjyj1kqjibZa4VTsphPWv?=
 =?us-ascii?Q?5gmjXERwg0ej+ehqCD3o3oZvY7eNTnEX4cBxHJwprtPNdbhU8gG/d5dRREkM?=
 =?us-ascii?Q?+gg/YBdjkyDLJPgHIS+tX+KcjZjhVEq/AsHEPRh0+8v6SEcwqOvCfyTeVl8m?=
 =?us-ascii?Q?lsYEsuMMv4Dr92n3A4LteZ/tPORTYOYHlsoCNbRZBnWTH3jkZ5JTAgUhQ7wz?=
 =?us-ascii?Q?wWCXapGuZ95+nE4l95P4GfiCsgRQFvvTMLLEsdTPjdPEreD6I/fO8ZJJBmWj?=
 =?us-ascii?Q?n+kQkBAbEuMEF9xLYYMkJ59K3NU2tMfiNkKyApssvDB2LqJ0EWEqSEY3wLzg?=
 =?us-ascii?Q?gH10Y8gOsxGdPcsRMbHAxTACz4tGlcdJMobUOz5WXjsv3zpNQIZiWuh3FC2N?=
 =?us-ascii?Q?VLNSBYmt67qWcMX74zExqlgkEeYk2JmD6+fq6NJbmE34hL7QzU/ws/SMymXJ?=
 =?us-ascii?Q?8tZlQVIj5KE0r/dJCxA5ri4xKirXzc1aRGG3LlK6xxau6maTVVLwtjAYA55i?=
 =?us-ascii?Q?1BSQLhZrTp/toMZh+b/29tNp1BfpdJWzHTG/5X070zKGfVyz1Dav4zz6r2R1?=
 =?us-ascii?Q?KgEqKI69yA3cH2cwPDAagQn59UbFrS8bl7mS1EFuiY2Gsv7PhnBZb2sQlkbg?=
 =?us-ascii?Q?C/TPfX/i1rXtG8iMHPsfCHHNv8+YyrihihLQbzpX8Tu3E9whdicK4bUq/nf6?=
 =?us-ascii?Q?8Q=3D=3D?=
X-OriginatorOrg: siemens.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e5cfabff-c30a-4623-1561-08da64196ff6
X-MS-Exchange-CrossTenant-AuthSource: DB9PR10MB5762.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 15:16:04.2954
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 38ae3bcd-9579-4fd4-adda-b42e1495d55a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1T1pKVEeeTyxToHrezi5oi6CdvWClhvCUN4NDGthz7tmv/zLhGM16BDtxzeGwl7QxvWptziU4iS3FUg6Gf/N/MJOv4zmxkIPXWaMX3YSuWU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB1615
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am Tue, 12 Jul 2022 16:42:46 +0200
schrieb Andy Shevchenko <andy.shevchenko@gmail.com>:

> On Tue, Jul 12, 2022 at 4:32 PM Henning Schild
> <henning.schild@siemens.com> wrote:
> >
> > changes since v2:
> >  - move from subsys_initcall to module_init
> >  - add 2 more patches to show how it can be used later
> >  - v2 is based on [PATCH v6 00/12] platform/x86: introduce
> > p2sb_bar() helper
> >
> > changes since v1:
> >  - implement get_direction function
> >  - style changes requested in review  
> 
> JFYI: You have a strange subject. Had you used `git format-patch
> --cover-letter ...`?

Yes, but i changed that subject. Took the old line and turned v2 into
v3. What is strange about it?

Henning

> > This adds gpio support for several Super IO chips from Nuvoton. The
> > driver was originally developed by Nuvoton and i am just
> > contributing it on behalf, because other patches i will send later
> > will require access to the gpios. The driver is valid on its own.
> > In fact v2 of this series shows a future user, not to be merged
> > right away but to show what is planned.
> >
> > The driver supports several chips, of which i only managed to test
> > one but did not want to drop the others.
> >
> > I hope the original authors will help with the testing and
> > addressing review feedback. The changes i did so far mainly are
> > inspired by similar drivers and some just concern coding style. If
> > more has to be done and the original authors do not jump in, we
> > might start off with just that one chip i can test and add the
> > others later on.  
> 
>