Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220712142040.12021-1-v.v.mitrofanov@yadro.com>
In-Reply-To: <20220712142040.12021-1-v.v.mitrofanov@yadro.com>
From:   Emil Renner Berthing <emil.renner.berthing@gmail.com>
Date:   Tue, 12 Jul 2022 17:01:06 +0200
Message-ID: <CANBLGcwXLNpbmCaqvBWbZLZ2-n4B+dJkStTKcrxsyvjHO756QA@mail.gmail.com>
Subject: Re: [PATCH] riscv: dts: fu740: Add PDMA node
To:     Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>
Cc:     linux@yadro.com, Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Stephen Boyd <sboyd@kernel.org>, Zong Li <zong.li@sifive.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Viacheslav,

Thanks for your patch! I have a comment below.

On Tue, 12 Jul 2022 at 16:22, Viacheslav Mitrofanov
<v.v.mitrofanov@yadro.com> wrote:
>
> HiFive unmatched supports PDMA but is not implemented in DT.
>
> Add the PDMA node in SiFive FU740 soc-specific DT file.
>
> Signed-off-by: Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>
> ---
>  arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> index 7b77c13496d8..4bd670d8632f 100644
> --- a/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> +++ b/arch/riscv/boot/dts/sifive/fu740-c000.dtsi
> @@ -161,6 +161,14 @@ prci: clock-controller@10000000 {
>                         #clock-cells = <1>;
>                         #reset-cells = <1>;
>                 };
> +               dma: dma-controller@3000000 {
> +                       compatible = "sifive,pdma0";

I think this should be

compatible = "sifive,fu740-c000-pdma", "sifive,pdma0";

..but before adding that you'll also need a separate patch to

Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml

..adding the new compatible string. Otherwise this will complain

make ARCH=riscv
DT_SCHEMA_FILES=Documentation/devicetree/bindings/dma/sifive,fu540-c000-pdma.yaml
dtbs_check

/Emil
> +                       reg = <0x0 0x3000000 0x0 0x8000>;
> +                       interrupt-parent = <&plic0>;
> +                       interrupts = <11 12 13 14 15 16 17 18>;
> +                       dma-channels = <4>;
> +                       #dma-cells = <1>;
> +               };
>                 uart0: serial@10010000 {
>                         compatible = "sifive,fu740-c000-uart", "sifive,uart0";
>                         reg = <0x0 0x10010000 0x0 0x1000>;
> --
> 2.25.1
>
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv