Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f847f665-f374-9b28-124a-abc6f0372db7@samsung.com>
Date:   Tue, 12 Jul 2022 17:39:06 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0)
        Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH v2 1/7] iommu/exynos: Reuse SysMMU constants for page
 size and order
Content-Language: en-US
To:     Sam Protsenko <semen.protsenko@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Janghyuck Kim <janghyuck.kim@samsung.com>,
        Cho KyongHo <pullip.cho@samsung.com>,
        Daniel Mentz <danielmentz@google.com>,
        David Virag <virag.david003@gmail.com>,
        Sumit Semwal <sumit.semwal@linaro.org>, iommu@lists.linux.dev,
        linux-arm-kernel@lists.infradead.org,
        linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
From:   Marek Szyprowski <m.szyprowski@samsung.com>
In-Reply-To: <20220710230603.13526-2-semen.protsenko@linaro.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <20220710230603.13526-1-semen.protsenko@linaro.org>
        <CGME20220710230612eucas1p1ccf9ad3301b653134479432dfb7c08fa@eucas1p1.samsung.com>
        <20220710230603.13526-2-semen.protsenko@linaro.org>
Precedence: bulk


On 11.07.2022 01:05, Sam Protsenko wrote:
> Using SZ_4K in context of SysMMU driver is better than using PAGE_SIZE,
> as PAGE_SIZE might have different value on different platforms. Though
> it would be even better to use more specific constants, already existing
> in SysMMU driver. Make the code more strict by using SPAGE_ORDER and
> SPAGE_SIZE constants.
>
> It also makes sense, as __sysmmu_tlb_invalidate_entry() also uses
> SPAGE_* constants for further calculations with num_inv param, so it's
> logical that num_inv should be previously calculated using also SPAGE_*
> values.
>
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
> Changes in v2:
>    - (none) This patch is new and added in v2
>
>   drivers/iommu/exynos-iommu.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> index 79729892eb48..8f80aaa35092 100644
> --- a/drivers/iommu/exynos-iommu.c
> +++ b/drivers/iommu/exynos-iommu.c
> @@ -340,7 +340,7 @@ static void __sysmmu_set_ptbase(struct sysmmu_drvdata *data, phys_addr_t pgd)
>   	if (MMU_MAJ_VER(data->version) < 5)
>   		writel(pgd, data->sfrbase + REG_PT_BASE_ADDR);
>   	else
> -		writel(pgd / SZ_4K, data->sfrbase + REG_V5_PT_BASE_PFN);
> +		writel(pgd >> SPAGE_ORDER, data->sfrbase + REG_V5_PT_BASE_PFN);
>   
>   	__sysmmu_tlb_invalidate(data);
>   }
> @@ -550,7 +550,7 @@ static void sysmmu_tlb_invalidate_entry(struct sysmmu_drvdata *data,
>   		 * 64KB page can be one of 16 consecutive sets.
>   		 */
>   		if (MMU_MAJ_VER(data->version) == 2)
> -			num_inv = min_t(unsigned int, size / SZ_4K, 64);
> +			num_inv = min_t(unsigned int, size / SPAGE_SIZE, 64);
>   
>   		if (sysmmu_block(data)) {
>   			__sysmmu_tlb_invalidate_entry(data, iova, num_inv);

Best regards
-- 
Marek Szyprowski, PhD
Samsung R&D Institute Poland