Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Matthew Wilcox <willy@infradead.org>
CC:     "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] maple_tree: Fix sparse reported issues
Thread-Topic: [PATCH] maple_tree: Fix sparse reported issues
Thread-Index: AQHYlfsoLhkzbf9CQkS2b2OLBBRjJa160n2AgAAN9oA=
Date:   Tue, 12 Jul 2022 15:44:09 +0000
Message-ID: <20220712154401.hh5ibuw7d3qlrd4r@revolver>
References: <20220712142441.4184969-1-Liam.Howlett@oracle.com>
 <Ys2LCwQZUuOwiiX6@casper.infradead.org>
In-Reply-To: <Ys2LCwQZUuOwiiX6@casper.infradead.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?XYGCe1ol3FEzg7xzw2+NErJdTusN5Ji+QtsIFbMGhS1YFtzeCg9IKnefkT1o?=
 =?us-ascii?Q?M0leRBH9qXWws2p8eG7KTgI/BNjGeRHNJgLyhG7OK/e5JfdkVuX33mtRd/Y3?=
 =?us-ascii?Q?etwS7T+n/q2dfy66RFaYZqnFQarR/pSmdnnO2naMwMJtsY+JsrmIyQg1KFPN?=
 =?us-ascii?Q?guHDqbgVfZhkTvdrpw2tMRUcys+v2eGMX3KJtHFRTTQxqhrBgj1GAisJNhdu?=
 =?us-ascii?Q?S1kVeUh6JJcxQQd1nrs8eDQz3u4rPxDCnV4h0ugNcNRKWbZor9hBWlBljWsA?=
 =?us-ascii?Q?ab/dP5CsVBkl2ruraK1arQCo4LpyXZCsXZCw8Uyw1Qjt3J3T3HXUxzj5eT6g?=
 =?us-ascii?Q?avsW88nuJEGL5WLRLk4UScNIf4NckcvL3qvurTK5onWrBKFs4q5viEFjVzP5?=
 =?us-ascii?Q?6OEDzEUSF6Z5duXJxgCVj2YIXlyTMpW2ronizZ0e6CkBrQnH+BPMoY1WS4fc?=
 =?us-ascii?Q?fO4AEJ9LHRgX0J8GM1VrALhUPxJpOgwa48DrKEEBj7JCzR4NLZVOdBawemhj?=
 =?us-ascii?Q?qwyt4JBe4+MagtdM85odChJyWHvJWswhSsBVU37cR6ZkQ8vWjc5O+8H1/RSv?=
 =?us-ascii?Q?bDS42qdmixrFpGNSxzyWN/mkZXhc+hCOGTGkpICgr+gzdQX4fICf9VKz+Qg5?=
 =?us-ascii?Q?u3YDBYsiVcOPBL14CyMqWflo9kMnayXB86VDzlqafBfhyfmd+wXV4cqrvDyq?=
 =?us-ascii?Q?EF6FqNH9bn/jKK6NwvTHeYqNzkQh5ErhNJ+yQ1PAPhIoqOSBnqjcUf6e7kX5?=
 =?us-ascii?Q?huPWnIe8pQhWaJ+t+KxPRnPLUspKqXb/Rky5TEHwjuObpeEG/2xWxUooChap?=
 =?us-ascii?Q?gq732Gz5Y9tftwSNMNiMM2ZipPm7cyygg1TUBtpGuang4zmhBJxOPkHABNjV?=
 =?us-ascii?Q?bjDjAtInSKe/fjmoGrNVX6vBdcd1KMsdhRSBsZuTg4lEyfx7QE/yQeh4/KSC?=
 =?us-ascii?Q?jgdDzbozMjlnUd3YD4D3zcjA38FSomz+Llrkw2fBwR+R4wPvJkkyaSrgzhB/?=
 =?us-ascii?Q?eZfbWGrk7gRQraTQ8Hx2g1RRwQWnZL3s3n1TwNHdGOL3gcl/uCwQDBmU3f1Y?=
 =?us-ascii?Q?cuwiugrLdFWsgYLmYSV5Oh26DW2e8FMz1/33OoXS7EBfBwwYvSlCUCO8amRN?=
 =?us-ascii?Q?QP9f0sfzFDh7a+qOdoOHSzO92UFUeNAzqsf1ksAFV28dZ0WQbJOymMWKLCJc?=
 =?us-ascii?Q?+tXMmwssJm+ous/KB3uRGkdYQLzMMROl0PWIvZHJUcqPSwBi/t9VnZKfakkd?=
 =?us-ascii?Q?RJJKkidNX+a9QPnWQykcT5awVk/BGEOnrha4S2dMirZOd526PnSwcv4FZVKh?=
 =?us-ascii?Q?js4KnjsJ3hZWeXle7Gge6/GYD5SKM/mJ/hyAXygQA0iLmyfWUX0gNrUMtnr1?=
 =?us-ascii?Q?x5gNmBIvf93EMfNYbQIQYOIbx2ve8PK00tNuR5FKVGlgmSi4eQ4LRoYAFALT?=
 =?us-ascii?Q?gayQOYb19Lvxg8btFOlE5vcsIDNnVe5kJ+Xjplwrrwp+a56zNh9RcAwAPS99?=
 =?us-ascii?Q?68wp2m9gRHUAC/x6D0actMvD9u/+aYfKmAQmgSvkrPl8TC5ZsiwswGIKpQQz?=
 =?us-ascii?Q?GdTo/IXvQ3K6sMMRmupTfggZzVU48eFY0oytypkY1+uWjQMqn7WTbF4rL9kj?=
 =?us-ascii?Q?9A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8EAC4325DEEE0F4AB257DD3A5B835693@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b2786892-7aac-4d7c-0958-08da641d5cbd
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2022 15:44:09.8912
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6AdMBYS2BlH94LCAhAVSBjwobowzIVFfe4VBxiSylt2RFMIotqtV7mShBMHO6ULL/cmpDwWq5YUWHkrQ6ogtQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4369
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-12_10:2022-07-12,2022-07-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 malwarescore=0 suspectscore=0 mlxscore=0 spamscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207120061
X-Proofpoint-GUID: 12EVrAwsyCUOmBIzaDfoaqtSfNKQajs6
X-Proofpoint-ORIG-GUID: 12EVrAwsyCUOmBIzaDfoaqtSfNKQajs6
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Matthew Wilcox <willy@infradead.org> [220712 10:54]:
> On Tue, Jul 12, 2022 at 02:24:55PM +0000, Liam Howlett wrote:
> > When building with C=3D1, the maple tree had some rcu type mismatch &
> > locking mismatches in the destroy functions.  There were cosmetic only
> > since this happens after the nodes are removed from the tree.
>=20
> ... in the current use-case.  It's a legitimate use of the API to do:
>=20
> 	ma_init();
> 	ma_store();
> 	ma_destroy();
> 	ma_store();
>=20
> Can you add a new test that does that?

I can add this, but a few notes on it.

The function names are mt_init(), mtree_store(), and mtree_destroy().
There is an internal/advanced __mt_destroy().  Both destroy functions
clear the flags - which I think is desirable.

>=20
> > @@ -5524,13 +5526,17 @@ static void mt_destroy_walk(struct maple_enode =
*enode, unsigned char ma_flags,
> > =20
> >  		type =3D mte_node_type(mas.node);
> >  		slots =3D ma_slots(mte_to_node(mas.node), type);
> > -		if ((offset < mt_slots[type]) && mte_node_type(slots[offset]) &&
> > -		    mte_to_node(slots[offset])) {
> > -			struct maple_enode *parent =3D mas.node;
> > +		if (offset >=3D mt_slots[type])
> > +			goto next;
> > =20
> > -			mas.node =3D mas_slot_locked(&mas, slots, offset);
> > +		tmp =3D mas_slot_locked(&mas, slots, offset);
> > +		if (mte_node_type(tmp) && mte_to_node(tmp)) {
> > +
>=20
> Unnecessary blank line?

ack, I'll remove that.


>=20
> > +			parent =3D mas.node;
> > +			mas.node =3D tmp;
> >  			slots =3D mas_destroy_descend(&mas, parent, offset);
> >  		}
> > +next:
> >  		node =3D mas_mn(&mas);
> >  	} while (start !=3D mas.node);
> > =20
> > --=20
> > 2.35.1
> >=20
>=20
> --=20
> maple-tree mailing list
> maple-tree@lists.infradead.org
> https://lists.infradead.org/mailman/listinfo/maple-tree=