Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220712042258.293010-1-jstultz@google.com> <20220712042258.293010-3-jstultz@google.com>
 <44e2cb41-641c-2a50-3e38-284e4504f012@amd.com>
In-Reply-To: <44e2cb41-641c-2a50-3e38-284e4504f012@amd.com>
From:   John Stultz <jstultz@google.com>
Date:   Tue, 12 Jul 2022 08:52:53 -0700
Message-ID: <CANDhNCrPhJacBjQZ4DMhmo9iaxBov8m8tbTqdU07PheaKFbE-g@mail.gmail.com>
Subject: Re: [RFC][PATCH 3/3] kselftest: Add drm_syncobj API test tool
To:     =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jason Ekstrand <jason@jlekstrand.net>,
        Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
        Chunming Zhou <david1.zhou@amd.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, Shuah Khan <shuah@kernel.org>,
        dri-devel@lists.freedesktop.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Jul 12, 2022 at 12:43 AM Christian K=C3=B6nig
<christian.koenig@amd.com> wrote:
> Am 12.07.22 um 06:22 schrieb John Stultz:
> > An initial pass at a drm_syncobj API test.
> >
> > Currently covers trivial use of:
> >    DRM_IOCTL_SYNCOBJ_CREATE
> >    DRM_IOCTL_SYNCOBJ_DESTROY
> >    DRM_IOCTL_SYNCOBJ_HANDLE_TO_FD
> >    DRM_IOCTL_SYNCOBJ_FD_TO_HANDLE
> >    DRM_IOCTL_SYNCOBJ_WAIT
> >    DRM_IOCTL_SYNCOBJ_RESET
> >    DRM_IOCTL_SYNCOBJ_SIGNAL
> >    DRM_IOCTL_SYNCOBJ_TIMELINE_WAIT
> >    DRM_IOCTL_SYNCOBJ_TIMELINE_SIGNAL
> >
> > And demonstrates how the userspace API can be used, along with
> > some fairly simple bad parameter checking.
> >
> > The patch includes a few helpers taken from libdrm, as at least
> > on the VM I was testing with, I didn't have a new enough libdrm
> > to support the *_TIMELINE_* ioctls. Ideally the ioctl-helper bits
> > can be dropped at a later time.
> >
> > Feedback would be appreciated!
>
> DRM userspace selftests usually go either into libdrm or igt and not
> into the kernel source.

Appreciate the pointer, I'll rework and submit to one of those projects.

thanks
-john