Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Frank Jungclaus <Frank.Jungclaus@esd.eu>
To:     "mailhol.vincent@wanadoo.fr" <mailhol.vincent@wanadoo.fr>
CC:     =?iso-8859-15?Q?Stefan_M=E4tje?= <Stefan.Maetje@esd.eu>,
        "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>,
        "mkl@pengutronix.de" <mkl@pengutronix.de>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "wg@grandegger.com" <wg@grandegger.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/6] can: esd_usb: Improved decoding for
 ESD_EV_CAN_ERROR_EXT messages
Thread-Topic: [PATCH 6/6] can: esd_usb: Improved decoding for
 ESD_EV_CAN_ERROR_EXT messages
Thread-Index: AQHYkvZ+J6KAwatI2U+kMqczZwhhVa15+MmAgADsGYA=
Date:   Tue, 12 Jul 2022 15:38:18 +0000
Message-ID: <f8f6df9c613d29058b135af0fa24554225bd23bc.camel@esd.eu>
References: <20220708181235.4104943-1-frank.jungclaus@esd.eu>
         <20220708181235.4104943-7-frank.jungclaus@esd.eu>
         <CAMZ6RqLC9a50mbyeaUSE4zqOfwPEVvOeYXcCVefC5EMD5dN6PA@mail.gmail.com>
In-Reply-To: <CAMZ6RqLC9a50mbyeaUSE4zqOfwPEVvOeYXcCVefC5EMD5dN6PA@mail.gmail.com>
Accept-Language: en-001, de-DE, en-US
Content-Language: en-US
user-agent: Evolution 3.36.5-0ubuntu1 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-15?Q?XlJ9NRoCh/ObgWp87enXzDZpYsKTrNxaojXxqcQnLrwC9/eiKrv0eK2lw?=
 =?iso-8859-15?Q?I5wqxoQkUl3FkakGE71FXlwpQvmz04v0HNJeY+Ma82GKnpSepTg2K3YtF?=
 =?iso-8859-15?Q?uL6UMqCr1uBvQY9vPw51iCt6BGybSwutWEpxuYKkdViv59SUyPFn8EuPI?=
 =?iso-8859-15?Q?xUHJepqwouH6vMCSmgPAstIcMzqRdyD8PrLUJmZnch8lAVwtok2hMgdCq?=
 =?iso-8859-15?Q?0dgWgLOHqrN2jktBiNqUZpNogaW110bfz2IpORdEvGkMeFELHk6dPTDK1?=
 =?iso-8859-15?Q?eIEOBHGms3IRxIdJQ1UZMKuFY3J/Dhw7vAFv+Fm04laTn7S0D158zpcpH?=
 =?iso-8859-15?Q?Zv0a33NTc/Hr2r4Cz5AWBTjA6kHeFP0xdH6ssGyD3d4KSxN9NnteCMGof?=
 =?iso-8859-15?Q?PWYqkUBFGD5NPb49smKOgZJMGfXyfeNDYFjR6Dv2O/7psfBDTkx3gGFl1?=
 =?iso-8859-15?Q?yAgpcZ6XlWcVgoTxCPRCTu0PcsI9TFnB77padQ9XNM/3q8rjcqS2/6Gsq?=
 =?iso-8859-15?Q?Wz9qSZQdYsz/0+3q8I5OdkgEiaSE0TVnHrHcfvIUUlZGHLljJENWBIcBB?=
 =?iso-8859-15?Q?TcGCOTQGIBADT3YRlGrVoLEDx01m7LtpjfDNe8KM99Bs2gbCgigz5I4ZL?=
 =?iso-8859-15?Q?sFpES7jiEJn4seqbtMKLU3NSwVF0YMW3YX7AsgLU7WZCxsEcOnm1NGXut?=
 =?iso-8859-15?Q?DnoZ1uJ/q+gL0WufXDqeLsMHbIOBYqMBarPGDh7wmvzPrqBgxMbbNWQJU?=
 =?iso-8859-15?Q?niijNP8gY9AZZSSFretPgg64KbRcpgl7e9AehtSXFEMqHYB/IKDac1B2o?=
 =?iso-8859-15?Q?crkPeEE90Syy0yowWm5TyXnbVLu/RUQpEz2zPhZjsNZJEZmCX+PHCi4yg?=
 =?iso-8859-15?Q?pDCFX92pHFSJ4p2rt9/UCho73Gbl5TpUrFoqLHX4K3Wdf74/pC/yqzykJ?=
 =?iso-8859-15?Q?gL+vMqS+r8l0QVaPUGBDULnWHNufvmpRdKF+AdESeiz2NSjrOqLiMFWlW?=
 =?iso-8859-15?Q?AU+od1B+IhKoka2ESjZjc0d/rt8Cbe79dxWywUv/G4eY1X0vc3AXGIR9P?=
 =?iso-8859-15?Q?yerVVUeNHLib4IHr2NxJXI67N38XrWKqczrYgsdsgV5YdoaFrHHZp4aW3?=
 =?iso-8859-15?Q?FvUWmbJ84LpkFoX9eLIvI7/mlBd1AN0htXD3pUO5KU9Iu8VIQXTGVu9EU?=
 =?iso-8859-15?Q?ZTnTqz0L7JEBOx0w3V1obhrt0glHcWNPkz3EU0MqvTSl3cWoH2R5tZwr1?=
 =?iso-8859-15?Q?51N7UR14ILtTYX3N5M1vD0sAuTvQt/xH6+f/r3tDZEfvrZH996MFZ+ta9?=
 =?iso-8859-15?Q?+PrBPdXvZ1PQSDLtrhPVmDymul9yblmpbElTHv+HXBM+LkgBYZbpw1l/4?=
 =?iso-8859-15?Q?UKarTc6uioGrAZvVFgcUAm7CwkSv5qteiGn06SphrzHATTAJk6bvOJ6E4?=
 =?iso-8859-15?Q?TXvCUrvibCAHJiL9DyOOfqhmq08esu94QsUrpXsTiNYLRE+IWuBX/agQJ?=
 =?iso-8859-15?Q?EMlN3tracwVbQHCfo6tzUWWmivnEAs5TlJzG0MjD0IJ3MIjN39A0AOz0x?=
 =?iso-8859-15?Q?r6O61/pnHPFHUrxHhIYmwJdzx0IWrmzDxE+AvBz9iq0pyoLLD+lgOnOhA?=
 =?iso-8859-15?Q?Oz3x3YTSFecO7A/M19qyNLJ8ubfKa7yOeAWKepHfatG0QQLhaRfgjYHtr?=
 =?iso-8859-15?Q?2yBZ3QzOpi51tFB8Dae43fQbvg=3D=3D?=
Content-Type: text/plain; charset="iso-8859-15"
Content-ID: <35C827E844FA0D4E87E6E299E3514C10@eurprd03.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: esd.eu
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: GVXPR03MB8426.eurprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 759a0e80-f91f-49b5-116f-08da641c8bbc
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jul 2022 15:38:19.1941
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 5a9c3a1d-52db-4235-b74c-9fd851db2e6b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9c1nrFGFZoPPbftLsssL1+MpStwhAX63ZIyz8A9K+yN1bT3CKqVkcihqUQO09UGJY0+Hv+E889CKCWq4O3BAag==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR03MB6619
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2022-07-12 at 10:33 +0900, Vincent MAILHOL wrote:
> On Sat. 9 Jul. 2022 at 03:14, Frank Jungclaus <frank.jungclaus@esd.eu> wr=
ote:
> > As suggested by Vincent I spend a union plus a struct ev_can_err_ext
>=20
> The canonical way to declare that something was suggested by someone
> else is to use the Suggested-by tag.
>=20
> Also, this particular change was suggested by Marc, not by me ;)
> https://lore.kernel.org/linux-can/20220621071152.ggyhrr5sbzvwpkpx@pengutr=
onix.de/

Ops, sorry for mixing up your names. So the kudos goes to Marc ;)
I'll spend a Suggested-by tag and resend patch 6/6.

Best regards,
Frank

>=20
> > for easier decoding of an ESD_EV_CAN_ERROR_EXT event message (which
> > simply is a rx_msg with some dedicated data).
>=20
> Suggested-by: Marc Kleine-Budde <mkl@pengutronix.de>
>=20
> > Signed-off-by: Frank Jungclaus <frank.jungclaus@esd.eu>
> > ---
> >  drivers/net/can/usb/esd_usb.c | 20 ++++++++++++++------
> >  1 file changed, 14 insertions(+), 6 deletions(-)
> >=20
> > diff --git a/drivers/net/can/usb/esd_usb.c b/drivers/net/can/usb/esd_us=
b.c
> > index 09649a45d6ff..2b149590720c 100644
> > --- a/drivers/net/can/usb/esd_usb.c
> > +++ b/drivers/net/can/usb/esd_usb.c
> > @@ -126,7 +126,15 @@ struct rx_msg {
> >         u8 dlc;
> >         __le32 ts;
> >         __le32 id; /* upper 3 bits contain flags */
> > -       u8 data[8];
> > +       union {
> > +               u8 data[8];
> > +               struct {
> > +                       u8 status; /* CAN Controller Status */
> > +                       u8 ecc;    /* Error Capture Register */
> > +                       u8 rec;    /* RX Error Counter */
> > +                       u8 tec;    /* TX Error Counter */
> > +               } ev_can_err_ext;  /* For ESD_EV_CAN_ERROR_EXT */
> > +       };
> >  };
> >=20
> >  struct tx_msg {
> > @@ -134,7 +142,7 @@ struct tx_msg {
> >         u8 cmd;
> >         u8 net;
> >         u8 dlc;
> > -       u32 hnd;        /* opaque handle, not used by device */
> > +       u32 hnd;   /* opaque handle, not used by device */
> >         __le32 id; /* upper 3 bits contain flags */
> >         u8 data[8];
> >  };
> > @@ -228,11 +236,11 @@ static void esd_usb_rx_event(struct esd_usb_net_p=
riv *priv,
> >         u32 id =3D le32_to_cpu(msg->msg.rx.id) & ESD_IDMASK;
> >=20
> >         if (id =3D=3D ESD_EV_CAN_ERROR_EXT) {
> > -               u8 state =3D msg->msg.rx.data[0];
> > -               u8 ecc   =3D msg->msg.rx.data[1];
> > +               u8 state =3D msg->msg.rx.ev_can_err_ext.status;
> > +               u8 ecc   =3D msg->msg.rx.ev_can_err_ext.ecc;
> >=20
> > -               priv->bec.rxerr =3D msg->msg.rx.data[2];
> > -               priv->bec.txerr =3D msg->msg.rx.data[3];
> > +               priv->bec.rxerr =3D msg->msg.rx.ev_can_err_ext.rec;
> > +               priv->bec.txerr =3D msg->msg.rx.ev_can_err_ext.tec;
> >=20
> >                 netdev_dbg(priv->netdev,
> >                            "CAN_ERR_EV_EXT: dlc=3D%#02x state=3D%02x ec=
c=3D%02x rec=3D%02x tec=3D%02x\n",
>=20
> Yours sincerely,
> Vincent Mailhol