Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4562082imw; Tue, 12 Jul 2022 10:03:41 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uAgJ8cm0aTPTW2HRuk7b0iDfsXQJQkCl8WXH1qRpoB1NseAHIcj487B3FFSByDTvWOfRVg X-Received: by 2002:a17:907:a427:b0:72b:8cc5:5487 with SMTP id sg39-20020a170907a42700b0072b8cc55487mr1833678ejc.354.1657645420765; Tue, 12 Jul 2022 10:03:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657645420; cv=none; d=google.com; s=arc-20160816; b=eL5BITYBKVcVlnxt8zsAufDxEp30Nr6OiuCdrGfMk2LeoREUwKskqM+zFzJMkRwAbD nSA02kd4DvJYjhNravEREASM+iPPICUZ8PaDxv/wWa7gV2EMYbqD5plXt219QLXJrPnW 7o9bVyi64bUhFwBhkp8IYeKHcAmMUOcE0b8zWVLqcdP+sGBmKqzUZ/6gbQ2RNWAT3qAW 3UZ8Itob18pBFMzAvGj9wgIbYRCMvY4WVmfM7V6pwPg8N8ZpWdLGtSImoZ4WYFX3DSE1 2Vli9pJYFPg5ScDsnP5qQr4meV4nQoVDpyP02b8g5+DEPuXuwdi6mgAR0AzqoD4qJIwo H4cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=OdZUFjk6k+XBMCjbJiAxWvJwwXz/OLi+EFuy7XZoz3U=; b=ll9eItrcx6UY2Kd8EVDTFc7Z7DP/6ru7YKJvueZpaxLExjL8eMCa+pyqYH3vgDYJ0n JctBQIydEIZNqf4i77AboyJ+NXTStStSHi1IRSrF0u29bxOCdZSy5tC34kfk5/tmkuW6 +pVqfD1wEbZtkonrBUIySD5TkZVgh5m3M60rRdHNhtJLyff7iWedKoWyPT2i+ril46J0 B2k9plsqyFsJ43spZPYhuQI9I3rlG0CZUHYFnMn/iFqrPHC1ne1mrPzYhSaIHruEf+Dt FtnwYF9txQJPmKEvrenSOi7F7vEO4FTPHxQKPBYDFrXtexlpz0p+pk7c4Qs1TGfuA6Qu S2bw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=DxkWlUNf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ga19-20020a1709070c1300b0072b870ca25esi2331498ejc.996.2022.07.12.10.03.09; Tue, 12 Jul 2022 10:03:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=DxkWlUNf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234338AbiGLQSG (ORCPT + 99 others); Tue, 12 Jul 2022 12:18:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234331AbiGLQSE (ORCPT ); Tue, 12 Jul 2022 12:18:04 -0400 Received: from mail-wr1-x435.google.com (mail-wr1-x435.google.com [IPv6:2a00:1450:4864:20::435]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2ED42CA6EA for ; Tue, 12 Jul 2022 09:18:02 -0700 (PDT) Received: by mail-wr1-x435.google.com with SMTP id r10so5721758wrv.4 for ; Tue, 12 Jul 2022 09:18:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=OdZUFjk6k+XBMCjbJiAxWvJwwXz/OLi+EFuy7XZoz3U=; b=DxkWlUNf6XY3YOvpCrNB5+DhFycC/AVcyTij5uF3oKtLQ3wG+cy4vY4xk7g7bwpwFS fgEQUVpwWKjXDwrkQiPQ/IobBJ/OnkD5KjYh/GXPI5TuqgwDV4ry2xXJQeP9XNuJc909 gr4+dXKAYKDZ2lNUDy63g8dTM8eBdH0YgJSVQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=OdZUFjk6k+XBMCjbJiAxWvJwwXz/OLi+EFuy7XZoz3U=; b=EVFgYCtf8V0L+Ivtgcn7lI4T9HsNKUfZIzOba1nWcAQODfiQOowfm2QAaXV5NafJIY CavEWGAaBhfDUToiVBQp8S/wHqZ7w1A14baa2ZyoasxACKXT2P6ugGPROPiS+mwyy0oX jlEZ/gfqEERWwvOIC5BlR/Z24czPsT3D/wjJG2XaoiA00U9bg+gCqnUuFRoSantNcGlf d8//LHug1Ndhjhn/i/ZCfrVxDLQrILxiMcazywY3eXAjY3DGZOGTDyz8VC+T30YmhFLq ka2McaVMqzEs1n4oLW9V0pERR/tRHYNdyjaELblP/ljM0qQfEav6j0hvUlfgpdtD4a3k g0CQ== X-Gm-Message-State: AJIora+bsl5nIB7TCctmy7NIsn1tF8X/RKD7EEgB+oij96gUYj9VE2fx ptx9+t8GhauM88TwUF6ClS1d0w== X-Received: by 2002:a5d:6a09:0:b0:21d:7a73:c48a with SMTP id m9-20020a5d6a09000000b0021d7a73c48amr22127747wru.366.1657642680691; Tue, 12 Jul 2022 09:18:00 -0700 (PDT) Received: from tom-ThinkPad-T14s-Gen-2i (net-188-217-53-214.cust.vodafonedsl.it. [188.217.53.214]) by smtp.gmail.com with ESMTPSA id g1-20020a05600c000100b00397623ff335sm9631398wmc.10.2022.07.12.09.17.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 09:18:00 -0700 (PDT) Date: Tue, 12 Jul 2022 18:17:57 +0200 From: Tommaso Merciai To: Jacopo Mondi Cc: Krzysztof Kozlowski , linuxfancy@googlegroups.com, linux-amarula@amarulasolutions.com, quentin.schulz@theobroma-systems.com, Daniel Scally , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 5/6] media: dt-bindings: ov5693: document YAML binding Message-ID: <20220712161757.GA1304540@tom-ThinkPad-T14s-Gen-2i> References: <20220630134835.592521-1-tommaso.merciai@amarulasolutions.com> <20220630134835.592521-6-tommaso.merciai@amarulasolutions.com> <20220711093659.mf7i4uqtrejtfong@uno.localdomain> <20220712152538.jh4ufxik7icllox6@uno.localdomain> <47aa4fbc-9cf4-7ac3-2fb4-2135a7703212@linaro.org> <20220712161236.le6wvdhdbleoxeyf@uno.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220712161236.le6wvdhdbleoxeyf@uno.localdomain> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On Tue, Jul 12, 2022 at 06:12:36PM +0200, Jacopo Mondi wrote: > Hi Krzysztof > > On Tue, Jul 12, 2022 at 05:32:45PM +0200, Krzysztof Kozlowski wrote: > > On 12/07/2022 17:25, Jacopo Mondi wrote: > > > Hi Krzysztof > > > could you have a look at the below question ? > > > > Sorry, there was a bunch of quoted text without end. When you reply > > under quote, please remove the rest of the quote. None of us have a lot > > of time to waste on scrolling emails... > > > > I should have kept a counter of the times I've been told "please do > not remove context, I'm so busy I do not have time to read the whole > thread" and "please remove context, I'm so busy I cannot read the > whole email". > > After 5 years of kernel development I would now know what to do. > > > > > > > If no need to resend from Tommaso I think the series could be > > > collected for v5.20. > > > > > > On Mon, Jul 11, 2022 at 11:37:05AM +0200, Jacopo Mondi wrote: > > >> Hi Tommaso, Krzysztof, > > >> > > >> This has been reviewed by Krzysztof already, so I guess it's fine, > > >> but let me ask anyway > > >> > > >> On Thu, Jun 30, 2022 at 03:48:34PM +0200, Tommaso Merciai wrote: > > >>> Add documentation of device tree in YAML schema for the OV5693 > > >>> CMOS image sensor from Omnivision > > >>> > > >>> Signed-off-by: Tommaso Merciai > > >>> Reviewed-by: Krzysztof Kozlowski > > >>> --- > > >>> Changes since v1: > > >>> - Fix allOf position as suggested by Krzysztof > > >>> - Remove port description as suggested by Krzysztof > > >>> - Fix EOF as suggested by Krzysztof > > >>> > > >>> Changes since v2: > > >>> - Fix commit body as suggested by Krzysztof > > >>> > > >>> Changes since v3: > > >>> - Add reviewed-by tags, suggested by Jacopo, Krzysztof > > >>> > > >>> Changes since v4: > > >>> - Remove wrong Sakari reviewed-by tag, suggested by Krzysztof, Sakari > > >>> > > >>> .../bindings/media/i2c/ovti,ov5693.yaml | 106 ++++++++++++++++++ > > >>> MAINTAINERS | 1 + > > >>> 2 files changed, 107 insertions(+) > > >>> create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > >>> > > >>> diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > >>> new file mode 100644 > > >>> index 000000000000..b83c9fc04023 > > >>> --- /dev/null > > >>> +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov5693.yaml > > >>> @@ -0,0 +1,106 @@ > > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > >>> +# Copyright (c) 2022 Amarulasolutions > > >>> +%YAML 1.2 > > >>> +--- > > >>> +$id: http://devicetree.org/schemas/media/i2c/ovti,ov5693.yaml# > > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > > >>> + > > >>> +title: Omnivision OV5693 CMOS Sensor > > >>> + > > >>> +maintainers: > > >>> + - Tommaso Merciai > > >>> + > > >>> +description: | > > >>> + The Omnivision OV5693 is a high performance, 1/4-inch, 5 megapixel, CMOS > > >>> + image sensor that delivers 2592x1944 at 30fps. It provides full-frame, > > >>> + sub-sampled, and windowed 10-bit MIPI images in various formats via the > > >>> + Serial Camera Control Bus (SCCB) interface. > > >>> + > > >>> + OV5693 is controlled via I2C and two-wire Serial Camera Control Bus (SCCB). > > >>> + The sensor output is available via CSI-2 serial data output (up to 2-lane). > > >>> + > > >>> +allOf: > > >>> + - $ref: /schemas/media/video-interface-devices.yaml# > > >>> + > > >>> +properties: > > >>> + compatible: > > >>> + const: ovti,ov5693 > > >>> + > > >>> + reg: > > >>> + maxItems: 1 > > >>> + > > >>> + clocks: > > >>> + description: > > >>> + System input clock (aka XVCLK). From 6 to 27 MHz. > > >>> + maxItems: 1 > > >>> + > > >>> + dovdd-supply: > > >>> + description: > > >>> + Digital I/O voltage supply, 1.8V. > > >>> + > > >>> + avdd-supply: > > >>> + description: > > >>> + Analog voltage supply, 2.8V. > > >>> + > > >>> + dvdd-supply: > > >>> + description: > > >>> + Digital core voltage supply, 1.2V. > > >>> + > > >>> + reset-gpios: > > >>> + description: > > >>> + The phandle and specifier for the GPIO that controls sensor reset. > > >>> + This corresponds to the hardware pin XSHUTDN which is physically > > >>> + active low. > > >>> + maxItems: 1 > > >>> + > > >>> +required: > > >>> + - compatible > > >>> + - reg > > >>> + - clocks > > >>> + - dovdd-supply > > >>> + - avdd-supply > > >>> + - dvdd-supply > > >> > > >> Should supplies be made mandatory ? Sensors are often powered by fixed > > >> rails. Do we want DTS writers to create "fixed-regulators" for all of > > >> them ? The fact the regulator framework creates dummies if there's no > > >> entry in .dts for a regulator makes me think it's fine to have them > > >> optional, but I understand how Linux works should not be an indication > > >> of how a bindings should look like. > > >> > > > > > > This question ^ :) > > > > My generic answer for generic devices would be - if resource is > > physically required (one need to connect the wire), I would say it > > should be also required in the bindings. This also forces driver > > developer to think about these resources and might result on > > portable/better code. > > > > However your point is correct that it might create many "fake" > > regulators, because pretty often these are fixed on the board and not > > controllable. Therefore I am fine with not requiring them - to adjust > > the bindings to real life cases. > > Tommaso if you can re-send this one with the supplies dropped I think > the series is still in time for being collected for this merge window > (Sakari to confirm this). Perfect, I'll send v6 with your suggestion. Thanks, Tommaso > > Thanks > j > > > > > Best regards, > > Krzysztof -- Tommaso Merciai Embedded Linux Engineer tommaso.merciai@amarulasolutions.com __________________________________ Amarula Solutions SRL Via Le Canevare 30, 31100 Treviso, Veneto, IT T. +39 042 243 5310 info@amarulasolutions.com www.amarulasolutions.com