Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 12 Jul 2022 18:50:13 +0200
From:   Claudio Imbrenda <imbrenda@linux.ibm.com>
To:     Steffen Eiden <seiden@linux.ibm.com>
Cc:     Heiko Carstens <hca@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org, nrb@linux.ibm.com
Subject: Re: [PATCH 2/3] s390/cpufeature: allow for facility bits
Message-ID: <20220712185013.3f9320eb@p-imbrenda>
In-Reply-To: <20220712105220.325010-3-seiden@linux.ibm.com>
References: <20220712105220.325010-1-seiden@linux.ibm.com>
        <20220712105220.325010-3-seiden@linux.ibm.com>
Organization: IBM
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 12 Jul 2022 12:52:19 +0200
Steffen Eiden <seiden@linux.ibm.com> wrote:

> From: Heiko Carstens <hca@linux.ibm.com>
> 
> Allow for facility bits to be used in cpu features.
> 
> Signed-off-by: Heiko Carstens <hca@linux.ibm.com>

Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com>

> ---
>  arch/s390/kernel/cpufeature.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/s390/kernel/cpufeature.c b/arch/s390/kernel/cpufeature.c
> index ea4bbfd855db..e70b29804db4 100644
> --- a/arch/s390/kernel/cpufeature.c
> +++ b/arch/s390/kernel/cpufeature.c
> @@ -10,6 +10,7 @@
>  
>  enum {
>  	TYPE_HWCAP,
> +	TYPE_FACILITY,
>  };
>  
>  struct s390_cpu_feature {
> @@ -54,6 +55,8 @@ int cpu_have_feature(unsigned int num)
>  	switch (feature->type) {
>  	case TYPE_HWCAP:
>  		return !!(elf_hwcap & (1UL << feature->num));
> +	case TYPE_FACILITY:
> +		return test_facility(feature->num);
>  	default:
>  		WARN_ON_ONCE(1);
>  		return 0;