Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp4692449imw; Tue, 12 Jul 2022 12:32:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sMNCD5/7t/pXWyLZLJI3zypFRxAksSwheRwNFtdokYkRLx38Ppg+5/DgWYcZuKH6alkKNX X-Received: by 2002:a17:906:cc13:b0:72b:31d5:a899 with SMTP id ml19-20020a170906cc1300b0072b31d5a899mr21496943ejb.184.1657654346969; Tue, 12 Jul 2022 12:32:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657654346; cv=none; d=google.com; s=arc-20160816; b=voqD/s85onCOlUzYufJtv+TwpwfTWe3pLDCpviuwfsK//BRjDDpsHNXtnL5g5Fcmb+ 5Vysy61yZy0ETyksAyfBdpdx4o3Lv6vtg5EU3B5qA3sV6F8toFN6DOoGaeiOtSe4dc1J F60exseUQUwY0Zv+E5lxGeTkBfC8tFfFF9jvMhZXM5YZZXCzjAIyHD6ma0hb1OkJkky2 KmIdD/6zfXGUalnjRZwocxZBF9yBYQq/HQ0oRN3taYLyARbv08ZbYgMkMVSMqFoVwjiX ODhuFx6Njc14tWgmbZL07ic3VdxuZQ8TWopII5XaOCa6K068czPZYerayeWbUd5PwejI FEdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=b1BVafOAk45YqVPRpHM5cAQFPWb/GSd6jJ7wqS1ZN38=; b=Ut5QVKCg7JG5GE1j+ydNRTftr03cMQ7l+c0j/90JA6Oi4dsKP29sTVW4gVSolHi4KT v+y1NrLHqywAsPQZZI6hvEI681xS4G7TrGDMmrl25FeQei7zCrUaHcvlL3qg5V0XFH6c h/TkgtzowGCjWgVU6rsYh8CVySzCCU7L5ROejVFtuULfyTXl/qD2cBODsiTdfj/g+ota ZXhffrtswMtsNw2A4/kpD/IbJ2krmdBsN2JWJO1hrnBP6U8dK5g7St2CxSTFS5l7QMk9 FNfT/d/VqffnWuPPivkR4OxQDKLGTdnTh/znzSKIMX+BUDf7/731mmhBsPrMHL+94Sh4 i0eA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2IiyPVH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id be19-20020a0564021a3300b0043a94332d14si13659601edb.320.2022.07.12.12.32.02; Tue, 12 Jul 2022 12:32:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=2IiyPVH2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234305AbiGLSon (ORCPT + 99 others); Tue, 12 Jul 2022 14:44:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234175AbiGLSnP (ORCPT ); Tue, 12 Jul 2022 14:43:15 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAD0CDA0D3; Tue, 12 Jul 2022 11:42:01 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 57A296186E; Tue, 12 Jul 2022 18:42:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12F6DC3411E; Tue, 12 Jul 2022 18:41:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1657651320; bh=b3T8UY6FZP2wcxf8N/fTReXZewBuYrszqPfDeP+Iw4Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2IiyPVH2xY0BrJhSHdwNHITKj/pd+ycZ0YTewThCDUcSCmAgncIy4LQoJfBLOXBug s0NvIa6i/fPLeOjXud8N+//IHSPREcNfzkGp7XyllzOkvJ7bwsOQ3cSOZHZEOBA5oH Xvdcu9BcJkpd586KLtuPaZ0qYT2x320h60bBfr9s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Peter Zijlstra (Intel)" , Ingo Molnar , Ben Hutchings Subject: [PATCH 5.10 039/130] objtool/x86: Ignore __x86_indirect_alt_* symbols Date: Tue, 12 Jul 2022 20:38:05 +0200 Message-Id: <20220712183248.204625458@linuxfoundation.org> X-Mailer: git-send-email 2.37.0 In-Reply-To: <20220712183246.394947160@linuxfoundation.org> References: <20220712183246.394947160@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Zijlstra commit 31197d3a0f1caeb60fb01f6755e28347e4f44037 upstream. Because the __x86_indirect_alt* symbols are just that, objtool will try and validate them as regular symbols, instead of the alternative replacements that they are. This goes sideways for FRAME_POINTER=y builds; which generate a fair amount of warnings. Fixes: 9bc0bb50727c ("objtool/x86: Rewrite retpoline thunk calls") Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Ingo Molnar Link: https://lore.kernel.org/r/YNCgxwLBiK9wclYJ@hirez.programming.kicks-ass.net Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- arch/x86/lib/retpoline.S | 4 ++++ 1 file changed, 4 insertions(+) --- a/arch/x86/lib/retpoline.S +++ b/arch/x86/lib/retpoline.S @@ -58,12 +58,16 @@ SYM_FUNC_START_NOALIGN(__x86_indirect_al 2: .skip 5-(2b-1b), 0x90 SYM_FUNC_END(__x86_indirect_alt_call_\reg) +STACK_FRAME_NON_STANDARD(__x86_indirect_alt_call_\reg) + SYM_FUNC_START_NOALIGN(__x86_indirect_alt_jmp_\reg) ANNOTATE_RETPOLINE_SAFE 1: jmp *%\reg 2: .skip 5-(2b-1b), 0x90 SYM_FUNC_END(__x86_indirect_alt_jmp_\reg) +STACK_FRAME_NON_STANDARD(__x86_indirect_alt_jmp_\reg) + .endm /*