Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jens Axboe <axboe@kernel.dk>
To:     ubizjak@gmail.com, linux-kernel@vger.kernel.org,
        linux-block@vger.kernel.org
In-Reply-To: <20220712150547.5786-1-ubizjak@gmail.com>
References: <20220712150547.5786-1-ubizjak@gmail.com>
Subject: Re: [PATCH v2] block/rq_qos: Use atomic_try_cmpxchg in atomic_inc_below
Message-Id: <165765839842.44219.4233753152017615209.b4-ty@kernel.dk>
Date:   Tue, 12 Jul 2022 14:39:58 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 12 Jul 2022 17:05:47 +0200, Uros Bizjak wrote:
> Use atomic_try_cmpxchg instead of atomic_cmpxchg (*ptr, old, new) == old in
> atomic_inc_below. x86 CMPXCHG instruction returns success in ZF flag,
> so this change saves a compare after cmpxchg (and related move instruction
> in front of cmpxchg).
> 
> Also, atomic_try_cmpxchg implicitly assigns old *ptr value to "old" when
> cmpxchg fails, enabling further code simplifications.
> 
> [...]

Applied, thanks!

[1/1] block/rq_qos: Use atomic_try_cmpxchg in atomic_inc_below
      commit: f4b1e27db49c8b985b116aa99481b4c6a4342ed4

Best regards,
-- 
Jens Axboe