Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp24416imw; Tue, 12 Jul 2022 13:54:35 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sW8e8Wl/U2lgnVaviRO5QwiSgDDKbRMj52jkcVc93ZcD5rSgug+iBWhrMyma1Qxbyjs+Wd X-Received: by 2002:a17:90a:f8ce:b0:1ef:798c:ae03 with SMTP id l14-20020a17090af8ce00b001ef798cae03mr6485515pjd.8.1657659275643; Tue, 12 Jul 2022 13:54:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657659275; cv=none; d=google.com; s=arc-20160816; b=q6oAKrGBmTzlEYng/b3/rsoHvWou0lSP5KldejlMjZNZ79UsEOwVvU/tj47jttHQQP BwMFPyKxyKr4Pf+0uxiNsQ2UHMsQO+QYi53YvB5X5BcWSSuvTACSvoEt0Gbv4cTyAMhT UJKmsRndx1P+YZ9ZCMTNHl0GoJ+sCzUJo/+fgdyIv2nOAVkLt+1FTE/rW6p1f9iTIU/j AUuLiMD2VKR5MACve+7xusxK1zA1K/y1+EcxPaOEi3fuHnsnlt3qAfsbHLvVMESk7QO1 xn5A6FxA+Bu24UiVbpyhEQI6UEzeU/aGKf4QreIz9IAAnadudKIfAdngLX5DuHlYz9FS XAYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:to:from:dkim-signature; bh=aX97FT52LcXsTBCiBL5hq7AYEJzsuUqnsB+OeO5wNUI=; b=ekiV+GS8HvcmuKYrEmbn7fsrPrekzJosdwtTIMsvJfjHiMt+ryu1NZw+d1n03+1QxU Cl/E002nMFPcebfswyOMBVBjwWu0cZ2YwofmDLvScC3eamBjjmBqKcgHTbvIld0hpxUv 23f2Npmxq6gPgcUjTDmP11aFRM4aza1imU/mKEjm6LNJe2ppYIr7zvA+vq7z2IJQFngj 4DN5GLvUOee0n4utxQsYWsG6yLJqArwfaZYovJPwJBAYoU9TsiwfVjZMgF4Iu8VSq1bc t25JtSB3m2pWzKQ2sk4TZudMOoS5sLnP1JdqYZh6r+HL5YF2WtOFjMmnECNQuqT/E/gv TDWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b="ISNO/DvK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t23-20020a63b257000000b004129c83c31esi13364888pgo.313.2022.07.12.13.54.22; Tue, 12 Jul 2022 13:54:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b="ISNO/DvK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233829AbiGLUkZ (ORCPT + 99 others); Tue, 12 Jul 2022 16:40:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44268 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232918AbiGLUkD (ORCPT ); Tue, 12 Jul 2022 16:40:03 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 159D2CC790 for ; Tue, 12 Jul 2022 13:40:02 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id v4-20020a17090abb8400b001ef966652a3so177647pjr.4 for ; Tue, 12 Jul 2022 13:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=from:to:in-reply-to:references:subject:message-id:date:mime-version :content-transfer-encoding; bh=aX97FT52LcXsTBCiBL5hq7AYEJzsuUqnsB+OeO5wNUI=; b=ISNO/DvKwrzvLX+I3lt4LSTitlFeuCDsXxg7l0bOqQrLfTda0AaH7JwUwddV3ZXjtY NsOyVdJCBRvz26jArgXSzLHTq2NF6SdRNfj7PWjfhVDlJxFudzKCZMZx20MHK1Y1knq0 /9u8jaX5Z291rmQYVGsyY/uxj9NpYGX5ej9ij7Sy5K3oUeWcRy+WFVyI8FKD0BQf7t0Q Hp09wJ6te5WZp9BUQS9FOOj1Xgk6kHejMeI4YdsNG8Zpb851rS8W0+UEsMeTSGmFgOeA +ZKnmH7ZNxajWMDHPJy8ocCWothlzQY43DBWcQCx71CFqz+kGTstfski/wZ1zNhCrXUA msXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:in-reply-to:references:subject :message-id:date:mime-version:content-transfer-encoding; bh=aX97FT52LcXsTBCiBL5hq7AYEJzsuUqnsB+OeO5wNUI=; b=7suMEluya9M3R2LactgcHztohN1t59sEd1Pm1gBTspVxwfVWN4MyjtD112+parabBS XNJwy3o9r40gJw0hXKcNwUSglQ0lLzmpPCN8OqTS8cxZZDVhuhx4jRxQs1O/2qdl1Z1w aSp8oVOEg3ssWFTo0CN6QbgHXk5PTgXL2I1srv0UEG6DydKtlB/4UOnDjsxNDOTtiscM oeGHXry/EwXlj/yV1mT1JhahMbQbUER5QrHeN86JaLnuyCsy06kbQmGO551XZYHC111P p5Zq4nABxLY1i1+uY8SMXHqf5X2rKBVFkd9bnkVvAAkfaKF0UJ+TD9POedAMjth5YirB kSVQ== X-Gm-Message-State: AJIora+WNVKG+tonc5rR5T1bMjphzCBOm3OzivS5v1/ROLzwK/6FpI5b fZLZWhAz4IIVPY/gxtDxd1BDx+IEudB1/A== X-Received: by 2002:a17:902:f60d:b0:16a:1a7f:a22f with SMTP id n13-20020a170902f60d00b0016a1a7fa22fmr25715932plg.13.1657658401528; Tue, 12 Jul 2022 13:40:01 -0700 (PDT) Received: from [127.0.1.1] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id d6-20020a170902654600b0016c0c82e85csm7245012pln.75.2022.07.12.13.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 13:40:01 -0700 (PDT) From: Jens Axboe To: linux-kernel@vger.kernel.org, ubizjak@gmail.com, linux-block@vger.kernel.org In-Reply-To: <20220712152741.7324-1-ubizjak@gmail.com> References: <20220712152741.7324-1-ubizjak@gmail.com> Subject: Re: [PATCH v2] block: Use try_cmpxchg in update_io_ticks Message-Id: <165765840073.44296.3101525406707231315.b4-ty@kernel.dk> Date: Tue, 12 Jul 2022 14:40:00 -0600 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jul 2022 17:27:41 +0200, Uros Bizjak wrote: > Use try_cmpxchg instead of cmpxchg (*ptr, old, new) == old in > update_io_ticks. x86 CMPXCHG instruction returns success in ZF flag, > so this change saves a compare after cmpxchg (and related > move instruction in front of cmpxchg). > > No functional change intended. > > [...] Applied, thanks! [1/1] block: Use try_cmpxchg in update_io_ticks commit: 939f9dd040fe1063d884f8f0f89b037093fe2341 Best regards, -- Jens Axboe