Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp25297imw; Tue, 12 Jul 2022 13:55:53 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vPTx1Of7D0/mbH7nqlxVD/C2gb/7KUpmor1/knFqYjyMpq0Q6oDB93I+vLZXde1N1LJPyW X-Received: by 2002:a17:902:cece:b0:16c:3683:8830 with SMTP id d14-20020a170902cece00b0016c36838830mr17915928plg.107.1657659352988; Tue, 12 Jul 2022 13:55:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657659352; cv=none; d=google.com; s=arc-20160816; b=bO09IlQwZc/cG8KRLhaU+voTX8PSEyFzHccyaU+Jh5YIP2VZj0D+77oLMVSI+YO+Ep bbguHxLH16J0/3VAdT2cAHM42FEDl0pq8fRj+egR6+fTpQbt8L76RHhnhnDWmC/KizgJ 4giL46gsUt63/THcJ1ZqJ636j/OPnW+ciSUMefuiSii5dS+ADT5WCS+CQRT/m9Y6bQLA 3ioF0wLcBnhit6/nWjDwgNO4xySep0V4LbpVjPhv+ANzDckPfPivJFropURG3MIEvxoM tEtQmSMdrjM3W5q1+kZPdqoZAdQ0t+yRa8s6UZgiTjW63Wy1JuRPSLLn2SXE2Kv8iOjH HpJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=SkDVN9tG4QC0N/AKTr20e0AIJFP9M5Kb7SboVANOO/4=; b=cVrX25mZ/0qk7Q+YScBCP8KHYHhY0neFa7X5k6KXzYzMbon78Rv2WGg4JPsZ4toiqF 0MXg61em4OPtEN0g6EnMvG3smv6Vg/wuhcfap4qcqWpsaV+IH1QxlIGk/mprUyoL6Jhi br2bgZbj5USJ2me8h9O4b2tfY7w/YsWidPS9y3BUz1v2rngYxHxcMmE2RiYWcOpaaNCG 4ksVgLPZYbKf5PJfbGAT1nUJSvB0vMvfpNJcQwE/4h67+H1nlGLahRDk/1NMCDormPse GmvUhuUWBAUiY5LDNxvVPrbY4GDUAIWIKVUuKUJh5YB4WVZuy/irtzKcVDvEGfpFWGNc A6SA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c3-20020aa781c3000000b0051bc45234f6si13920016pfn.21.2022.07.12.13.55.30; Tue, 12 Jul 2022 13:55:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233360AbiGLTzf (ORCPT + 99 others); Tue, 12 Jul 2022 15:55:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235379AbiGLTzS (ORCPT ); Tue, 12 Jul 2022 15:55:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3DC721AF for ; Tue, 12 Jul 2022 12:55:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6BA78B81BDB for ; Tue, 12 Jul 2022 19:55:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93CC2C3411C; Tue, 12 Jul 2022 19:55:10 +0000 (UTC) Date: Tue, 12 Jul 2022 15:55:09 -0400 From: Steven Rostedt To: Linyu Yuan Cc: Masami Hiramatsu , Tom Zanussi , Subject: Re: [PATCH v7 0/4] tracing/probes: allow no event name input when create group Message-ID: <20220712155509.02b8d246@gandalf.local.home> In-Reply-To: <1656296348-16111-1-git-send-email-quic_linyyuan@quicinc.com> References: <1656296348-16111-1-git-send-email-quic_linyyuan@quicinc.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 27 Jun 2022 10:19:04 +0800 Linyu Yuan wrote: > take kprobe event as example, when create a group of events, > p[:[GRP/]EVENT] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS], > according to this format, we must input EVENT name, > > this change allow only GRP/ input, EVENT name auto generate from KSYM, > p[:[GRP/][EVENT]] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS] > > similar change apply to eprobe and uprobe. > With this patch set applied, this selftest fails: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc This exactly: echo 'p:foo/ vfs_read' > kprobe_events no longer fails as the test expects it to. I guess we need to remove that check as it now works and no longer fails as "expected". This change fixes it. If it's OK with everyone, I'll apply this change. -- Steve diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc index fa928b431555..7c02509c71d0 100644 --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc @@ -21,7 +21,6 @@ check_error 'p:^/bar vfs_read' # NO_GROUP_NAME check_error 'p:^12345678901234567890123456789012345678901234567890123456789012345/bar vfs_read' # GROUP_TOO_LONG check_error 'p:^foo.1/bar vfs_read' # BAD_GROUP_NAME -check_error 'p:foo/^ vfs_read' # NO_EVENT_NAME check_error 'p:foo/^12345678901234567890123456789012345678901234567890123456789012345 vfs_read' # EVENT_TOO_LONG check_error 'p:foo/^bar.1 vfs_read' # BAD_EVENT_NAME