Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1b8fee7f-5af2-332e-d2c9-ceecd6ff487b@oracle.com>
Date:   Tue, 12 Jul 2022 16:22:41 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: Build warnings in Xen 5.15.y and 5.10.y with retbleed backports
Content-Language: en-US
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>, x86@kernel.org,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
        linux-kernel@vger.kernel.org, jpoimboe@redhat.com
References: <Ys2jlGMqAe6+h1SX@kroah.com>
 <ddcdd531-fc33-39df-a69f-5352d7a1c8af@oracle.com>
 <Ys3MI7cv2yKj9RFc@kroah.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <Ys3MI7cv2yKj9RFc@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M0hiWnVZYmpScnZ2RCt0aGNpQzR0Ti9vOEg4OCtBbzNia1h4ZFNJc1Q3a1hQ?=
 =?utf-8?B?OWN5MmFvcjYzNTZZVG5mMGZiNHNHbnJxVE1Ba3lZY2kvM01oZ2FIa1h0Qmdp?=
 =?utf-8?B?MnJZakFZUGhHc2ZyRlVpckZVL1BZN3d4eTZoSllXT0hvQkR4aWVOTU1zNmM2?=
 =?utf-8?B?cnVoWEI2a0ViaDhpY3hIVUgrMTI3SkNubkxsK1FPRzR5YzN2THlpeXEwbG5j?=
 =?utf-8?B?N3Y0V0RCbWNibURHK3Y3Uyt1bTJjZnhZdG1IbFVnU1l6S2VOT2M5U3FTS0Yv?=
 =?utf-8?B?ZkN4aDdSd3VXUmliRVIxNWdwL1hUNGZ6OGZOekVqTnFhekExSGwxWnl0UEFk?=
 =?utf-8?B?VUFLbkJxZU1sdkEzdW43a2dYZ1hUQnR3RFNXTkNCQm1udTNIenUzb0JPODVX?=
 =?utf-8?B?bVhVaXAvclRxYWk1KzcyNHdXR3Q4Mnd2bDg5N3hlQVhFSkVXZTFMK1JFOE1h?=
 =?utf-8?B?ZE94dE9penE5eXFBU1F2NEdib1VMc0Z1MEdhSjdNaE83TDRWUldrck9WZThM?=
 =?utf-8?B?b0F6Wng0ek5SQlZ2Ykp4WlZOaVFwczgvTTN4cVAydlhyamJHVlJsY3hLS2Zs?=
 =?utf-8?B?SFdBWkRlNDB4OWh2M2NkazlPeUlMQnNhYlI0MG1pOG9xZWptZVMyUUhWU2Fr?=
 =?utf-8?B?T2hBUnVGdlROUmwwUTJDV2RsaTVsWFZobXFjN1lKY3l3dlQrL3FDWXZrT3dZ?=
 =?utf-8?B?bDlhY1cvOGVJcFdubUt2bnhtbEpFTFNwK24vZXpiQk9kRURZWmc5K1NuNmZ6?=
 =?utf-8?B?ZFJGSTFzQUVoblZxejN1YnZtZjJrNW42RU52eW8xb0pESFRQc2d4aE81RFJG?=
 =?utf-8?B?eVVkRlFwb0xxN3BGZWNXeEQ0cjFwVWZ3RmU5QUNWZWdwRjV5cEk3cXFnbVNj?=
 =?utf-8?B?NnZTUXkwMGo3MUR6aU0ra0VOdzQxTFA5eFBweVZ6YVBjUVM4eFgyZ1hGeG5i?=
 =?utf-8?B?OVpIWlR2ditPNElLNVhVdThtR05uc1BrVUd1SWIzWllhYVNyY3V6S3NzUzJz?=
 =?utf-8?B?UmhzMjF6WjJTQ3l0Nmd4VFdSTTJNZmRhYWUrdEJENHo3T3RnNWFRU2l2Q2tj?=
 =?utf-8?B?eHpIQ25ZRkszSFBUYTM2Q0ZjU09NMkNVZnVBN3g2SmlFTnFEUkhobnowRlRF?=
 =?utf-8?B?MXVEYVB4SlRtbHRQOGQ4SzcxSlVqaTVhajhod09FUVo0RGZzU2ErdVQvd2l1?=
 =?utf-8?B?Ykt4dEVhN3NuOWJEcERnSWRncDAzcVhiaFpwem1TTjNQUGlaWjF5enJnZjZQ?=
 =?utf-8?B?Vi92S3g5K05jcmRDVms3UW1JVnZLclJOcVN4cm9OdHkvRU10VFZwMSsxQ2VK?=
 =?utf-8?B?Sm9WcDR0T3h1OFFOTHFlQXpBcGpTZXZRL0RqaUhtbGE0dTluTUFvZlhZb2RV?=
 =?utf-8?B?cE9ycGY0bU1uOWdxdjFYR3hFdXZrMXVucklFRUsySFVqVXpTUWYrbzdhZ1g0?=
 =?utf-8?B?UVVyUnVWUTlUU3VHYlg2ZmpMbnFiMU54MEt5VDVTUXd3a0lyd3lITk15Tk96?=
 =?utf-8?B?eGZMUW5FTGVqdXREVzZzdE9vRHB5Zlp3V0NQZDlIbGdKNDJRbEt5TGlWVUFq?=
 =?utf-8?B?Mmo5OUVuVXc5czJPaFVyeDFER1cvSHR6SVVHcnNMQ0JLa1Q0T0R2MkQraUF0?=
 =?utf-8?B?WDgrcTF0N2wwQUozSS94akdtMjNHaXhjbGJvY1c1NDdJSng3TTVzQmRSZDdn?=
 =?utf-8?B?Y0dLbFpueTBxL25GRVg0Snc2TERGUktnOVE5c1VlUWlnenZyTUM5cW4rUVRD?=
 =?utf-8?B?MTBDTnhzRW5uU0VJVEgranFlYnJYQTFxS1hkMzZGS0JtY1BValgrbEE3cTg5?=
 =?utf-8?B?a003NVBMNUw2d1YrYWtFdVd0c1dqNTltQWJJd0RKTmRSTUJUMHNkd1NyU3M3?=
 =?utf-8?B?OHpJRGRKd0hDZjE4VDVkNGRNTHF0b0cyamFwaTN4ZVFDRitYVWpXZ3Q0WHFT?=
 =?utf-8?B?ek5lWU5rKzExKzZmQUg5ZUdmbElsK2o2d2VCd1V5SGh2TzJwRUVrRzU3TUFo?=
 =?utf-8?B?THJhbzEwKzBrdTUvVi92ZXEzMnEwMEh3cUJXUkNYMkRJQUNuaFlYZHZ5Y01P?=
 =?utf-8?B?UXZVbWZaRm04c0ZzUCtpa3JjWHJGVWNlRkJvaENObVc4NVpKK0t4U29XR2E0?=
 =?utf-8?B?Vy9XeDl3Z1BsZVAyWUhOa1ZjNW56LzZHU2xxNHVqbmJCU1kzMmNFT3Q3Wnhu?=
 =?utf-8?B?QUE9PQ==?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8573936b-b736-4edb-5149-08da6444488e
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2022 20:22:46.6060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 656axEEXAeyLOEk+YMiZk89YjxRKy+kaKtsqtxRksRUBtR4KeQ8VeZj5Gh4lfc3AxfYOsg7T/KptqS5Yot+G6R3qi825bEugh33R1BF9TeQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6015
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-12_12:2022-07-12,2022-07-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207120082
X-Proofpoint-GUID: yObhBEWzazCxw6dW4yliL8UZRyKPGEcQ
X-Proofpoint-ORIG-GUID: yObhBEWzazCxw6dW4yliL8UZRyKPGEcQ
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 7/12/22 3:31 PM, Greg KH wrote:
> On Tue, Jul 12, 2022 at 03:19:39PM -0400, Boris Ostrovsky wrote:
>>
>> On 7/12/22 12:38 PM, Greg KH wrote:
>>> Hi all,
>>>
>>> I'm seeing the following build warning:
>>> 	arch/x86/kernel/head_64.o: warning: objtool: xen_hypercall_mmu_update(): can't find starting instruction
>>> in the 5.15.y and 5.10.y retbleed backports.
>>>
>>> I don't know why just this one hypercall is being called out by objtool,
>>> and this warning isn't in 5.18 and Linus's tree due to I think commit
>>> 5b2fc51576ef ("x86/ibt,xen: Sprinkle the ENDBR") being there.
>>>
>>> But, is this a ret call that we "forgot" here?  It's a "real" ret in
>>> Linus's branch:
>>>
>>> .pushsection .noinstr.text, "ax"
>>> 	.balign PAGE_SIZE
>>> SYM_CODE_START(hypercall_page)
>>> 	.rept (PAGE_SIZE / 32)
>>> 		UNWIND_HINT_FUNC
>>> 		ANNOTATE_NOENDBR
>>> 		ANNOTATE_UNRET_SAFE
>>> 		ret
>>> 		/*
>>> 		 * Xen will write the hypercall page, and sort out ENDBR.
>>> 		 */
>>> 		.skip 31, 0xcc
>>> 	.endr
>>>
>>> while 5.15.y and older has:
>>> .pushsection .text
>>> 	.balign PAGE_SIZE
>>> SYM_CODE_START(hypercall_page)
>>> 	.rept (PAGE_SIZE / 32)
>>> 		UNWIND_HINT_FUNC
>>> 		.skip 31, 0x90
>>> 		ANNOTATE_UNRET_SAFE
>>> 		RET
>>> 	.endr
>>>
>>> So should the "ret" remain or be turned into "RET" in mainline right
>>> now?
>>
>>
>> It doesn't matter --- this is overwritten by the hypervisor during initialization when Xen fills in actual hypercall code.
>>
>>
>> So f4b4bc10b0b85ec66f1a9bf5dddf475e6695b6d2 added 'ret' to make objtool happy and then 14b476e07fab6 replaced 'ret' with RET as part of SLS fixes. The latter was not really necessary but harmless.
>>
>>
>> So it can be 'ret', RET, or anything else that tools don't complain about. It will not be executed.
> 
> Cool, thanks.
> 
> But what about the objtool warning that I now see?  Is that "real"?


It's not real in the sense that the code there is not real, it will be overwritten. (Originally the whole page was 'nop's)


I am getting a different error BTW:

	arch/x86/kernel/head_64.o: warning: objtool: .text+0x5: unreachable instruction


> 
> I don't run any Xen systems, so I can't test any of this myself.


You can't test any changes to that code --- it is rewritten when Xen guest is running.


We probably do want to shut up objtool. Josh, any suggestions?


-boris