Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Jens Axboe <axboe@kernel.dk>
To:     linux-kernel@vger.kernel.org, linux-block@vger.kernel.org,
        ubizjak@gmail.com
In-Reply-To: <20220712154455.66868-1-ubizjak@gmail.com>
References: <20220712154455.66868-1-ubizjak@gmail.com>
Subject: Re: [PATCH v2] blk-cgroup: Use atomic{,64}_try_cmpxchg
Message-Id: <165766236676.63083.2141527891325153647.b4-ty@kernel.dk>
Date:   Tue, 12 Jul 2022 15:46:06 -0600
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 12 Jul 2022 17:44:55 +0200, Uros Bizjak wrote:
> Use atomic_try_cmpxchg instead of atomic_cmpxchg (*ptr, old, new) == old
> in blkcg_unuse_delay, blkcg_set_delay and blkcg_clear_delay and
> atomic64_try_cmpxchg in blkcg_scale_delay.  x86 CMPXCHG instruction
> returns success in ZF flag, so this change saves a compare after cmpxchg
> (and related move instruction in front of cmpxchg).
> 
> Also, atomic_try_cmpxchg implicitly assigns old *ptr value to "old" when
> cmpxchg fails, enabling further code simplifications.
> 
> [...]

Applied, thanks!

[1/1] blk-cgroup: Use atomic{,64}_try_cmpxchg
      commit: 96388f57d2aad9836b2c589181fa1dbaba4066b4

Best regards,
-- 
Jens Axboe