Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d1568f0b-0972-5e52-ed63-042a625060e9@hauke-m.de>
Date:   Wed, 13 Jul 2022 00:23:37 +0200
MIME-Version: 1.0
Subject: Re: [PATCH net-next] net: lantiq_xrx200: use skb cache
Content-Language: en-US
To:     Aleksander Jan Bajkowski <olek2@wp.pl>, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220712181456.3398-1-olek2@wp.pl>
From:   Hauke Mehrtens <hauke@hauke-m.de>
In-Reply-To: <20220712181456.3398-1-olek2@wp.pl>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/12/22 20:14, Aleksander Jan Bajkowski wrote:
> napi_build_skb() reuses NAPI skbuff_head cache in order to save some
> cycles on freeing/allocating skbuff_heads on every new Rx or completed
> Tx.
> Use napi_consume_skb() to feed the cache with skbuff_heads of completed
> Tx. The budget parameter is added to indicate NAPI context, as a value
> of zero can be passed in the case of netpoll.
> 
> NAT performance results on BT Home Hub 5A (kernel 5.15.45, mtu 1500):
> 
> Fast path (Software Flow Offload):
> 	Up	Down
> Before	702.4	719.3
> After	707.3	739.9
> 
> Slow path:
> 	Up	Down
> Before	91.8	184.1
> After	92.0	185.7
> 
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>

Acked-by: Hauke Mehrtens <hauke@hauke-m.de>