Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <732553c4-8c2a-bd3f-cd2a-3e03fb364b5f@intel.com>
Date:   Wed, 13 Jul 2022 08:22:30 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Firefox/91.0 Thunderbird/91.11.0
Subject: Re: [PATCH v7 030/102] KVM: TDX: Do TDX specific vcpu initialization
Content-Language: en-US
To:     Isaku Yamahata <isaku.yamahata@gmail.com>,
        Yuan Yao <yuan.yao@linux.intel.com>
Cc:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <sean.j.christopherson@intel.com>
References: <cover.1656366337.git.isaku.yamahata@intel.com>
 <e05ce01e400f80437803146564d4c351bf1df047.1656366338.git.isaku.yamahata@intel.com>
 <20220708021443.v4frmpcqgbk23hkp@yy-desk-7060>
 <20220712203542.GN1379820@ls.amr.corp.intel.com>
From:   Xiaoyao Li <xiaoyao.li@intel.com>
In-Reply-To: <20220712203542.GN1379820@ls.amr.corp.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 7/13/2022 4:35 AM, Isaku Yamahata wrote:
> On Fri, Jul 08, 2022 at 10:14:43AM +0800,
> Yuan Yao <yuan.yao@linux.intel.com> wrote:
> 
...
>>> +int tdx_vcpu_ioctl(struct kvm_vcpu *vcpu, void __user *argp)
>>> +{
>>> +	struct kvm_tdx *kvm_tdx = to_kvm_tdx(vcpu->kvm);
>>> +	struct vcpu_tdx *tdx = to_tdx(vcpu);
>>> +	struct kvm_tdx_cmd cmd;
>>> +	u64 err;
>>> +
>>> +	if (tdx->initialized)
>>
>> Minor: How about "tdx_vcpu->initialized" ? there's
>> "is_td_initialized()" below, the "tdx" here may lead guys to treat it
>> as whole td vm until they confirmed it's type again.
> 
> I think you man tdx->vcpu_initialized.  If so, makes sense. I'll rename it.

IMO, no need to do so.

All around tdx.c, "tdx" is the brief pointer name, just like "vmx" used 
in vmx.c. People will get used to it.