Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp210120imw; Tue, 12 Jul 2022 18:00:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sQl8TNYKsbIyr7o7XeEm6oib+R2TeIhLBaKncWBg58P5uUJqcYnD0ItvcaLknDjL7+LjXO X-Received: by 2002:a17:907:969f:b0:72b:7141:d6ef with SMTP id hd31-20020a170907969f00b0072b7141d6efmr843909ejc.501.1657674006088; Tue, 12 Jul 2022 18:00:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657674006; cv=none; d=google.com; s=arc-20160816; b=UABQWUMU2u9l2lbImBxrS8hleFVMwHFIvvYVgkOyx5QYkZZNQdhVpc1qAioP8NnYfr L3EeE3sis1cd1xGuYx8cmQU6pEiu4y12HVvLjs11BTWSEUldBo5f4BRQJl8LQfxRzFU7 9QbHIpN5Kp8sqDQ0eEqQrCh0oDwqnySQdArMDm051ukr0xZwmLZrLuDBkh+ZhyU7S8dR 9Vqeb76ncTwb0f8AuhTQ+WyN9Bd0cs8QwrjpMe6J2nsDgNGcxWvKkxgtDzso24H/6x2+ oYsOdoiH15mYWEA8TV2gQWCe/n74pMZ7PUoUOKRrEXteq1ZXPLoY7lwwneMwJaBwuTZ9 BPYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=OLPJy5cLEYg62ISIDls1Kj5CC9Vjc8aCHPKIHIyhgq4=; b=TMcuq8zBldKE/+k/OKjU5sy99knO9stNrv/y24UEjEbDMKJNezX92TS9kQefxiWI3X WTbhgl73oR3HqzycFG9jODTib/z1aIUpoM3SqfuHM5sDk23R0LKApo/fzi6J/EMkQcBY bzonaz9sVkZ/RGiCs3Rrmdm2SY3C5zROsGeNLJut6kK4uzQHYAfzkHw6nWy7tcc8lqCu x2LGWQQHNdpzulATqPZbPmjoiRIUppu6BQzf92B6bkbUJq3i8cFM2mFEHZd6Ukq3wQtr PrY3Pt0U0MLnndqT+2EEyW4cHb40hcYZTCxOd/uxSe8KPLySsgK80HKpUjPCuwjqUDD5 tnEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=POM9zk+c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc4-20020a1709078a0400b0072b5ca32ec4si10258901ejc.488.2022.07.12.17.59.40; Tue, 12 Jul 2022 18:00:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=POM9zk+c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231996AbiGMAhb (ORCPT + 99 others); Tue, 12 Jul 2022 20:37:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231905AbiGMAha (ORCPT ); Tue, 12 Jul 2022 20:37:30 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAD22B7D6A; Tue, 12 Jul 2022 17:37:29 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4C8C361852; Wed, 13 Jul 2022 00:37:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 748CAC3411C; Wed, 13 Jul 2022 00:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657672648; bh=zrEAqCvFaLLRfDkoCkAVybVZ0VUg0r6WiAhoHWGPViU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=POM9zk+cYuG8o1oZk2xlHZdtmynzg8avxWcTBUX8reU8tgQ+AHP8ej2XVH5woil6q a82BdQYfUnGT1aAYmh/3UxC1vOzG8glQr5JDazfnP/PwbmlcyRJkOak1ajzwaf3XhD 0JfWp+IzEVfSyecROZ/WuSaKwwAiteku88YP/xnCzFLZNsJpXxvitCbt0YEboWrCWB CW/oHbmpaS1U7+cl25XGgoaPexqTw5A8l32a4cqq/ndrSVwh6DRDdWWrCsZ/Jij3DF PBYxrIAqh+evFBkqj4BSYczxw8I/IgyYAAp+Ys+aifYIo/5JHYul8rrJHCNcs5rMta aspntO1csOddg== Date: Tue, 12 Jul 2022 17:37:19 -0700 From: Jakub Kicinski To: Hayes Wang Cc: Paolo Abeni , davem@davemloft.net, netdev@vger.kernel.org, nic_swsd@realtek.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] r8152: fix accessing unset transport header Message-ID: <20220712173719.0e834365@kernel.org> In-Reply-To: References: <20220711070004.28010-389-nic_swsd@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 12 Jul 2022 15:06:25 +0200 Paolo Abeni wrote: > On Mon, 2022-07-11 at 15:00 +0800, Hayes Wang wrote: > > A warning is triggered by commit 66e4c8d95008 ("net: warn if transport > > header was not set"). The warning is harmless, because the value from > > skb_transport_offset() is only used for skb_is_gso() is true or the > > skb->ip_summed is equal to CHECKSUM_PARTIAL. > > > > Signed-off-by: Hayes Wang > > If this is targeting the -net tree please add a suitable Fixes tag, > thanks! And FWIW I think the fixes tag you want is: Fixes: 66e4c8d95008 ("net: warn if transport header was not set")