Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ce0e84a0504c1af4ad672b7d4802af8b3d27c32c.camel@intel.com>
Subject: Re: [PATCH v7 003/102] KVM: Refactor CPU compatibility check on
 module initialiization
From:   Kai Huang <kai.huang@intel.com>
To:     isaku.yamahata@intel.com, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     isaku.yamahata@gmail.com, Paolo Bonzini <pbonzini@redhat.com>,
        Sean Christopherson <seanjc@google.com>
Date:   Wed, 13 Jul 2022 15:16:48 +1200
In-Reply-To: <1b5e06b237ad9f2bcbee320e95b94e336109b484.camel@intel.com>
References: <cover.1656366337.git.isaku.yamahata@intel.com>
         <e1f72040effd7b4ed31f9941e009f959d6345129.1656366338.git.isaku.yamahata@intel.com>
         <1b5e06b237ad9f2bcbee320e95b94e336109b484.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 (3.44.3-1.fc36) 
MIME-Version: 1.0
Precedence: bulk


> > +	/* hardware_enable_nolock() checks CPU compatibility on each CPUs. */
> > +	r =3D hardware_enable_all();
> > +	if (r)
> > +		goto out_free_2;
> > +	/*
> > +	 * Arch specific initialization that requires to enable virtualizatio=
n
> > +	 * feature.  e.g. TDX module initialization requires VMXON on all
> > +	 * present CPUs.
> > +	 */
> > +	kvm_arch_post_hardware_enable_setup(opaque);
>=20
> Please see my reply to your patch  "KVM: TDX: Initialize TDX module when =
loading
> kvm_intel.ko".
>=20
> The introduce of __weak kvm_arch_post_hardware_enable_setup() should be i=
n that
> patch since it has nothing to do the job you claimed to do in this patch.
>=20
> And by removing it, this patch can be taken out of TDX series and upstrea=
med
> separately.

I tried to dig more about the history.  Please see my another reply and ign=
ore
this.