Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp370157imw; Tue, 12 Jul 2022 22:52:26 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s3jQAJYhX7reRSbFG++H/oj4TZn0RyVroUPKrKf/otl5nqUExXwGINGKZpibM56CeABbNM X-Received: by 2002:aa7:c98f:0:b0:43a:71c2:3f7e with SMTP id c15-20020aa7c98f000000b0043a71c23f7emr2535371edt.60.1657691546712; Tue, 12 Jul 2022 22:52:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657691546; cv=none; d=google.com; s=arc-20160816; b=kFRPHmjwZO3+sEDZawKScuLk/Zw7pSnAmamnUP+ogD47Wz1lI1n7/kuUBNoiMeRxuy k71eJ8jrytYdw1uzQuhAM+ZK/M9B6IYHmbwKawXSYil1wh6hY0wiHtw3jompBPmB+P9J MwZOUbC6D1r7rJCQBlcZNTWnKcYrI4L24uNWh4TK0GDriTyJRLhefv96+7MiO12w+iAi yHQ87ll8XZYWHSGtsQHg78qi9Rc4e+o7DXNhsotaVzC+9DDKcPlbbSx8zFFogXlQz0Si rZSmgPQVlMwOA2a4hyxO01zHZi0t2OuO9172/Ytr1RyCyVXLijYpg2iv+h/WUiCd2NmY kgWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Ut+uaIBNWmPiRpGqEhRFI1vh60vpzjIhzJJbDXdJFqA=; b=E1/waHJCZ26azN+VIekVn821QRLWPijhmGONeZM+/ZeaW6EdV9gKoLugA3oF0HKDVX Iofqa1XkhcwiAayppmSQ6GlSE4Pw4RVJuDL2/E1EtQ5zmXXBHcuReIXaaFMODi9Qj3Vj jy9HMGbjXaILZQx491235AbU09sL21dc+8hSsghUf3L5xEqmRiQj75JjMG8Y6qJ1wIbu RlsVlg1E0KEIPyEfY6NXpVTrj4wPnfXAnZVslI0zFYlBSml2Y7GUX8ZEx5iWkabE6quF Rf1IEsyhl1kHag+XjhsyIE55EzmfZUHcUgYEZH/C5R49XCtloCHKtoB9MMMa7Fz2kiNc j4rg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HMXfCuTv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lo5-20020a170906fa0500b006feb04902a8si3646206ejb.824.2022.07.12.22.52.02; Tue, 12 Jul 2022 22:52:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HMXfCuTv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231322AbiGMFYN (ORCPT + 99 others); Wed, 13 Jul 2022 01:24:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233861AbiGMFYH (ORCPT ); Wed, 13 Jul 2022 01:24:07 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37D6C599EE for ; Tue, 12 Jul 2022 22:24:05 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id 72so9552036pge.0 for ; Tue, 12 Jul 2022 22:24:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Ut+uaIBNWmPiRpGqEhRFI1vh60vpzjIhzJJbDXdJFqA=; b=HMXfCuTvx4TnBNFFgpcFsDLFe1hlKIJA7x8c8dqAe2c/E9vTXPWHQ8JUQi91nRQdXy 9vp4LhwOvxd9fuxgBHfT2NNQE+mUbzJp4CHHD+YYsgyBiDgzJSEoRCLhysuARQ14LSrB yt+QmoWnMWFaLYTALTLgHsOzAVp6pi3ow5vmkJYuOpoRPEdwvzEB4ReaJS/jmh/AKzzB PpPlbJEzeeAWR6Up4a3iQM+QsHhFIqzwaTbHvLphECmYdKkApEnSTkkxpfnNaKdEnc8X PBoP/7QYKfvJbjNZIO4PTKOCGQk1L48sbi7SN2KXoFOAUbYgoLTPWfvJ8smAFu5zlLcF h9ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Ut+uaIBNWmPiRpGqEhRFI1vh60vpzjIhzJJbDXdJFqA=; b=FlKkfQXbwp6WzrDcaVR2YEEmoJSNpk+BeYi0TSMXsM2KJZx6jBsagYGIcIk/vvMEx5 FK+YLbJOTqm+bulfK73fXDFivrCXELNk3vjqKtAa+0xnGh0JkFefgs1P012Oswh3i8mf g9aCShgoWfaNLClGfUqV0ANztXb39EaTwaZ8gabH8I0dmLK4ZoQl0NvO13ytrO+sN5Y0 Z5Maq8KI9ntnrXvaXBQ1vuhd9wdqq/eTCsUYxH6pctt+ZILCJC6sgEyt1qYultlcKTdt WNd0OnT5Yd1f/1cAV751kx2ym2BpBbJg2nwuNgoULtJ0snW5x9tC77kuLcwOtKLQJD7P PuNg== X-Gm-Message-State: AJIora+tS6sS4JCMArvYnSnBARLBuo0+3xzwn8uOeFhTeWzoKIWhOEoG /w7Bp1oY+64HOyXdHwj0unIUSA== X-Received: by 2002:a63:f355:0:b0:419:8dfd:45d0 with SMTP id t21-20020a63f355000000b004198dfd45d0mr1531053pgj.226.1657689844535; Tue, 12 Jul 2022 22:24:04 -0700 (PDT) Received: from leoy-ThinkPad-X240s (n058152077182.netvigator.com. [58.152.77.182]) by smtp.gmail.com with ESMTPSA id h14-20020a056a00000e00b0051bbe085f16sm7792615pfk.104.2022.07.12.22.24.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Jul 2022 22:24:03 -0700 (PDT) Date: Wed, 13 Jul 2022 13:23:59 +0800 From: Leo Yan To: carsten.haitzler@foss.arm.com Cc: linux-kernel@vger.kernel.org, coresight@lists.linaro.org, suzuki.poulose@arm.com, mathieu.poirier@linaro.org, mike.leach@linaro.org, linux-perf-users@vger.kernel.org, acme@kernel.org Subject: Re: A patch series improving data quality of perf test for CoreSight Message-ID: <20220713052359.GA1354743@leoy-ThinkPad-X240s> References: <20220712135750.2212005-1-carsten.haitzler@foss.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220712135750.2212005-1-carsten.haitzler@foss.arm.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 12, 2022 at 02:57:36PM +0100, carsten.haitzler@foss.arm.com wrote: > This is a prelude to adding more tests to shell tests and in order to > support putting those tests into subdirectories, I need to change the > test code that scans/finds and runs them. > > To support subdirs I have to recurse so it's time to refactor the code to > allow this and centralize the shell script finding into one location and > only one single scan that builds a list of all the found tests in memory > instead of it being duplicated in 3 places. > > This code also optimizes things like knowing the max width of desciption > strings (as we can do that while we scan instead of a whole new pass > of opening files). It also more cleanly filters scripts to see only > *.sh files thus skipping random other files in directories like *~ > backup files, other random junk/data files that may appear and the > scripts must be executable to make the cut (this ensures the script > lib dir is not seen as scripts to run). This avoids perf test running > previous older versions of test scripts that are editor backup files > as well as skipping perf.data files that may appear and so on. > > Signed-off-by: Carsten Haitzler Just remind, you could use the command like below to generate patch set with cover letter, version number, etc: $ git format-patch -v6 --cover-letter COMMIT_HASH -o patches/ Don't need to resend patch set for only this purpose, but it's good later to use cover letter for description for big patch set, and version number is important for maintainers to easily know which is the latest version for merging your patches. Thanks, Leo > >