Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e0faeb99-6c32-a836-3f6b-269318a6b5a6@suse.com>
Date:   Wed, 13 Jul 2022 08:18:05 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v2] Subject: x86/PAT: Report PAT on CPUs that support PAT
 without MTRR
Content-Language: en-US
To:     Chuck Zmudzinski <brchuckz@aol.com>
Cc:     Dave Hansen <dave.hansen@linux.intel.com>,
        Andy Lutomirski <luto@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
        Dan Williams <dan.j.williams@intel.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Jane Chu <jane.chu@oracle.com>,
        Tianyu Lan <Tianyu.Lan@microsoft.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Sean Christopherson <seanjc@google.com>,
        Juergen Gross <jgross@suse.com>,
        xen-devel@lists.xenproject.org, stable@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz.ref@aol.com>
 <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com>
From:   Jan Beulich <jbeulich@suse.com>
In-Reply-To: <9d5070ae4f3e956a95d3f50e24f1a93488b9ff52.1657671676.git.brchuckz@aol.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y2lsVDA3ZlpiQ202TW45QnkvQlFVMGxUL0pWUExmWFpoQ3I3WkR3QzVTeDF6?=
 =?utf-8?B?cDRPL0VtcFZpcWl4N0VRL3NlL0lURDh4azY5a25JbHRWMkJsMVZOWGlSa2gy?=
 =?utf-8?B?bDRzUCtjTDloaWdHdDFWYjFkVC82bEVXOURMVWdlRm8vMm1ZQ3NWS3ByMlN3?=
 =?utf-8?B?NDlMcXU2bzFrZzdicERVRXd3dnhBRUI3dklqWlkyK2pUaEVyVHdLOFdwd05D?=
 =?utf-8?B?TWdyTEF4WGtiRzQ5VE1WMjlpaUNpNEFINkkySXcxS1VmRHZJMzA0VjRzelhj?=
 =?utf-8?B?aWpOQzYyMlVVektLMTBzaitTZnJPc2xzdjVGRmRSaDBWVzllckIzaVRMWG80?=
 =?utf-8?B?T24xRVJIdUlPVkVNL1VBeTlYY0JEV0Qwc2ZHemxzdnBoeTFEMjl0UTVqNW5O?=
 =?utf-8?B?UjJDN2dHb3ZkL3dRdmk5RVI5NjlzM0NqU2lpLzYvK2o4N3p5cFlaNmJzYTZr?=
 =?utf-8?B?b004ZkNkVmdmVGtWd1ZjSmpMMC83YzBMVmFPamI3MUdFeTNrMG9IdTdna3RH?=
 =?utf-8?B?eWhwdy9YTDI1TGl3bFgzTWhJVVd3aUY5eWFHbjR5d25BYWJIdU42aUFIZE1t?=
 =?utf-8?B?Q2k2V01UMTJWd2dWNUc5Q09MOXUydXRnUHNVR1J6YzF2ZVVIc0RCM29DdlZ5?=
 =?utf-8?B?YkhOV0kxUXBTRlVMRWFJcGZKSVc3bXpHR0E4NE0wR1R3Nzd5aG91aEpSUTRv?=
 =?utf-8?B?WFl0am5RUi9rZ1NHS2xPazZZVnpxMmttd1RJRDkwaTd2TjhhR2UySEQ5emM5?=
 =?utf-8?B?RUFyYWxscG5uTHNMWktpaW9SWTlPbEhxSTY0UWNtZzZlQnRrOUk1RzV4WFdS?=
 =?utf-8?B?SC9zYnRtOWpPVUdJQk0vTVZWdlJBUW1hb1NDYWNQUC81VjIxSUJLUmE2WUtO?=
 =?utf-8?B?czBVVGdQenBjeS8rZW1ZdEpYaGljY1lGVkQybWtYdTRxNE5PcDZUVFpzcUhO?=
 =?utf-8?B?ckNTN2NyTllWNUhBNFVVWUJpeHc4VThXc3ZURUxYWTRuR2plbGp3MS9nSGc0?=
 =?utf-8?B?SzhGOUJKTS9NWlVQQjIrbDJ6dTVDWUZ0dEhQMkNHUENQZE9EVjEwR1pZZ081?=
 =?utf-8?B?WXd5bGJZRzk3VTZKci9jTTNlb012RVpVNUJpVUdEYndPZFFRK1VvT0tVUEd4?=
 =?utf-8?B?bk5jaW8zQnI2UU8yQUR1c1F2YjA4MFRvMzdXckN0REs2OVRkUTc4OUI1RHRZ?=
 =?utf-8?B?NXNRdDZCd2wvcTdnaEl5L1JzUE1mZlBzL2Jod3RjU0dZMThQM3c2ZEM0cE5r?=
 =?utf-8?B?K0VXNWN3QW15VnVSMENNVEVnTnJ5QzdjNHFhQ3MwMDUzdWY4Ynp5clo3OExD?=
 =?utf-8?B?L0hXc1BCZS9XbllWRUwremhOVjNNeGpaYkgrQ2htNFlzcDJKWE1vdmNQSlN4?=
 =?utf-8?B?MmhIdlRsNXByYk1sSndFeUhDdS9ZdnRSU01rVkg0OTZyYW5MV1h4UmlzS2pD?=
 =?utf-8?B?ZU9CV0FjdU1rRkp2Zm5ndWNVRTlFUlRDUFdBSzAra2EzVE9hQ1MzUWdQK2ZJ?=
 =?utf-8?B?YU5rR05LeXZNYnk2dXlVN2h5K2krNzBiRUJ0NE42RkJyc3ZkT0tmeHZ1SlNY?=
 =?utf-8?B?M2M4czRlaFVGdTg1ZE0wNS92ZDkwTDl3L2NXcE9SUS8rSDdod056UEFWclQ1?=
 =?utf-8?B?eHZvanE5Qkw4VG0relBEVlZlOCtNSE40ZlNTNVQzVnBKZGwzMWhCcVg1OXNN?=
 =?utf-8?B?Nyt5VTgrS1J0TTRtVWJUN2pkdk8rV0tWdUswTmlvc2Q5WEZDTkdEVFo4KzBp?=
 =?utf-8?B?Mzh1Y2QvenJpL3hSRWxaQ3drZG9UaUV6aUY0UUdjZmpwWSsvYWhUN1A2UG1E?=
 =?utf-8?B?ZzZQbXRZUUkveGpKbTRGQnM5Q0g4OHdrcFBqanU0TmgrOTJiYk9RSTBwOGdK?=
 =?utf-8?B?VjFXMjRFeWpWVnBwaEltVDk4b1hQdURScEp1NHFUZXZRYWkrVldpcCtLQS9v?=
 =?utf-8?B?RDZwclh2cS9rb1kydnlJUFRLSHVIa0N1SExlVmp2djBvNzAwWFI0UW1FYTgx?=
 =?utf-8?B?Q0x6SkxXUWFEaU44UEFNSW53aTlvQm03RHdWR2NZTTQwbHZWOVVRa0FxbEs3?=
 =?utf-8?B?MUQwaEtZaGJKU1lLcWs2Z1NoVWQzUlAzYzBEVmZaQnhOOWEvVmxKSWg2WWJh?=
 =?utf-8?Q?X1xld6PWszTA4VYb1TZk29NGP?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: af25e754-b29f-4d9b-e49d-08da64977493
X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 06:18:08.6441
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +w/j5yjxr17wQz8KWanpBaKeMFDFLqo+mWLUqLm/BpOV0Xzg5i+k8gC5iTI01a9Rnb2jtAY1b4Vjnd9rACI24A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4892
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 13.07.2022 03:36, Chuck Zmudzinski wrote:
> v2: *Add force_pat_disabled variable to fix "nopat" on Xen PV (Jan Beulich)
>     *Add the necessary code to incorporate the "nopat" fix
>     *void init_cache_modes(void) -> void __init init_cache_modes(void)
>     *Add Jan Beulich as Co-developer (Jan has not signed off yet)
>     *Expand the commit message to include relevant parts of the commit
>      message of Jan Beulich's proposed patch for this problem
>     *Fix 'else if ... {' placement and indentation
>     *Remove indication the backport to stable branches is only back to 5.17.y
> 
> I think these changes address all the comments on the original patch
> 
> I added Jan Beulich as a Co-developer because Juergen Gross asked me to
> include Jan's idea for fixing "nopat" that was missing from the first
> version of the patch.

You've sufficiently altered this change to clearly no longer want my
S-o-b; unfortunately in fact I think you broke things:

> @@ -292,7 +294,7 @@ void init_cache_modes(void)
>  		rdmsrl(MSR_IA32_CR_PAT, pat);
>  	}
>  
> -	if (!pat) {
> +	if (!pat || pat_force_disabled) {

By checking the new variable here ...

>  		/*
>  		 * No PAT. Emulate the PAT table that corresponds to the two
>  		 * cache bits, PWT (Write Through) and PCD (Cache Disable).
> @@ -313,6 +315,16 @@ void init_cache_modes(void)
>  		 */
>  		pat = PAT(0, WB) | PAT(1, WT) | PAT(2, UC_MINUS) | PAT(3, UC) |
>  		      PAT(4, WB) | PAT(5, WT) | PAT(6, UC_MINUS) | PAT(7, UC);

... you put in place a software view which doesn't match hardware. I
continue to think that ...

> +	} else if (!pat_bp_enabled) {

... the variable wants checking here instead (at which point, yes,
this comes quite close to simply being a v2 of my original patch).

By using !pat_bp_enabled here you actually broaden where the change
would take effect. Iirc Boris had asked to narrow things (besides
voicing opposition to this approach altogether). Even without that
request I wonder whether you aren't going to far with this.

Jan