Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f63c0955-47df-cb4e-ac19-ec04019dcc06@amd.com>
Date:   Wed, 13 Jul 2022 10:02:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [RFC][PATCH 2/3] drm: vgem: Enable SYNCOBJ and SYNCOBJ_TIMELINE
 on vgem driver
Content-Language: en-US
To:     John Stultz <jstultz@google.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Jason Ekstrand <jason@jlekstrand.net>,
        Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org
References: <20220712042258.293010-1-jstultz@google.com>
 <20220712042258.293010-2-jstultz@google.com>
 <6e490429-e34c-fa51-c6d9-3315c4639d9d@amd.com>
 <CANDhNCo1WAUC9DhGfT19Smq2Z5duruAAwOs6AWUWUvNAjZqgAg@mail.gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <CANDhNCo1WAUC9DhGfT19Smq2Z5duruAAwOs6AWUWUvNAjZqgAg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?empPc2pmeWRoOUZxUEVDaGxoTmxDMzNjVEtvQmlDaHIvQU96VTl6SHI2SUVS?=
 =?utf-8?B?NndFQXJaM3lObzFoU0Y3ejNxZlpCeFRmT05naVFOZDlPdlRsZEgydWxha3pC?=
 =?utf-8?B?eHZGaHZaYnljVUM4TTdHYk0yOHJDeUl4VzJkVTBKdDR4K0s4M25uWTluVHcz?=
 =?utf-8?B?VmViNmNLUk1OeEdaZmFZY3N2Vm5xejhrTHJ6TUpibFhDQ1FUTXk4VUR1U3Zr?=
 =?utf-8?B?QXIrSDc2Zi9Xd1NRUlFsbW5tajcwdVo5NlVSTGFEL01ON0s4aGFqcTh3SHh3?=
 =?utf-8?B?cWkzbnVscE9OT2VIeThiRFVveDhpSFVCVWpjaGk5dUNEWUFBMUZEb21BblRV?=
 =?utf-8?B?b2lMOVBMMTJHdjBnOEVGNDFjWVIwQjRXMDlIRnMwN3p4QSt3Y3hWeVBtMXN1?=
 =?utf-8?B?Q1M4WWs1UGZpcHliMzZuUmt3YTFqeU42ajNHa1FNM0hQUUY4aVpwS2Zaa01S?=
 =?utf-8?B?RmVYcDFYT1JBREtBK01UYUx6bDRkY3lYUnVwL0UzeFhaOGF1QTFaUTJjMUZY?=
 =?utf-8?B?bmxIZXNHaVBBMnA5OTJJMUFyZDRZWVVBRzduWk1iclZvNmhnMjYwVUJLUHdu?=
 =?utf-8?B?dmhtMXlia25uS0Z3ZXJjYXJUcERzY29kNG8vSy9meUp3RG1kSElKeGVtb1R6?=
 =?utf-8?B?d1RTcjJETTVqRXJGcC80dmxUMVVXL1hCWXF6bURhT0l4QUp6WEcxaUN5d25C?=
 =?utf-8?B?TFNFTGFvYVcvRzA4YTQzYzRMM29BSFZCRGNQUUZnMm9TbkVnai9vb1M0Mll5?=
 =?utf-8?B?Rm84TVJmeXF1OWV4dTVDY0ZkUC80YWdId1plR2dOcGVQYTFtbFJrOUl5eGZE?=
 =?utf-8?B?bVIwNlV6QVJRbjBiNmYvN2grekU4U21DUktDUlNCQVFNWU5YNlNORjdUWFhz?=
 =?utf-8?B?RW1XK0ZqYnJjY29mWjAwSmZqRWwzK0lFSHduVmYySjdyWnI3YzAvNkJMTVlF?=
 =?utf-8?B?SXZLRVBKTkQvend4K0xGSFUzWUNOaHhmbjgraWNiYUVMMWJCUHAxd2w4WlMy?=
 =?utf-8?B?VmdVbWN2RnFwZEcyWlR5TjFNbXRuZTBmMDlWRHBCWVlUanE3S3M3d2dkeDYz?=
 =?utf-8?B?UVcrUjRJalB2N2dHcndtclJqa0k5U3Y3T2p0QnFIcTYzMDF5TllNeTU3S2JB?=
 =?utf-8?B?VXdncmtOODdsY3MvaWNTdHFxdGxvMDFYZ2xMZmlxRU5mZCtIUnozZ0JLNkVs?=
 =?utf-8?B?RlpveVUwM3UyaEd2UEZOeU1qWlZLTjA4VTJzRVA4VUwzR3lkNTJoR0xSUFRy?=
 =?utf-8?B?ajY1TVc2VW1ZZ1BGQ291UkhQSGxXTVpjZ2k4blBBdWM2NDlDZ0d4NWU5bDBW?=
 =?utf-8?B?SG0xdCtNMTU2NFBwT1luVlBPc0huL2VyRGtiQVN3VDRYekdnWU0razZleDY1?=
 =?utf-8?B?VWp0cHFYNTFOZXc1S0ozNmU4Q3hVclRTZGF4RVdQcUxTR2M3N0F4MUpCdEdt?=
 =?utf-8?B?aHp6TjJ3anRzaGhuV0FXYk1qa2VlZlhRSVM2eEZOdVQ4UVRoUWJnR2h0Q2NS?=
 =?utf-8?B?Ym5Na0FqSWhLeVlucHNnVGxUbitQSnlWQ1Fac0ZNVC9BbllNTGtOVWVocG16?=
 =?utf-8?B?TFBpaUJ0MC9RVVRMK0ZXcy9PTHVQTjZTNm5mV3FUd2tPSGVyam10RkRTWktH?=
 =?utf-8?B?OXZMdWJWU0ZyODBNV242b01ZTVUvOFN5ZFh0QzZaM2FnYmFUWllaemdlazI2?=
 =?utf-8?B?cWZHVFdhUysvNi9aOFJqWk9Fa1ptNE1CK0h3NkVSbGxOaVVXbFpMaTBhMHZi?=
 =?utf-8?B?MXpWMmRreG9KbUd2WjR4clBFUU01STR2cUxzV0FLbEFuUHJIUFJ3bmR3MXdI?=
 =?utf-8?B?c0JQL3VrNlF0bit2ekt1Wnlka1l6cFQ0RlhUTVRXQ3pQbTBZM2trZ3ZtUVFp?=
 =?utf-8?B?eWo3aERNL1BNcG1uUUtGT08vaWpHdlN1R0NoZ3l3WEZVbUwySFVrRXN2bHN6?=
 =?utf-8?B?Y3ROOEpxenZLeVRwRFhMb3V2UUoyOUxFVFZuazRJdUVzdHlkdjlhQWVxUFlG?=
 =?utf-8?B?dHkxR1pVdjd3MkJZdnBxQjhOR2dYUG1wRlVEUkdNT2pQanpOaW12WEJYeE5w?=
 =?utf-8?B?RzdvRDNtc0MweFR1TW5rbHM5MVBWZHBjc0ZXOXlCQUlsK29yNDN6TlhCR21z?=
 =?utf-8?B?YlFjTkhlTTVUajR5TWtZQnZmb1RmM2Z0bHlEeDRhdWVzcmE3WndMaTc3K0tr?=
 =?utf-8?Q?Cas8B1pCV7lQdnT7dhjh0/OeOzZuhbbEJekiMK6uYuv7?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c83c21a1-be22-46db-ac34-08da64a60216
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 08:02:19.0297
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: u2QsDpEwI+KilDzkhz+Xo43AQLHZ6megCyWJbPfc8xW+arU6e/0Un7UaGPaHfOak
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4140
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 12.07.22 um 18:50 schrieb John Stultz:
> On Tue, Jul 12, 2022 at 12:46 AM Christian König
> <christian.koenig@amd.com> wrote:
>> Am 12.07.22 um 06:22 schrieb John Stultz:
>>> Allows for basic SYNCOBJ api testing, in environments
>>> like VMs where there may not be a supported drm driver.
>>>
>>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>> Cc: Maxime Ripard <mripard@kernel.org>
>>> Cc: Thomas Zimmermann <tzimmermann@suse.de>
>>> Cc: Jason Ekstrand <jason@jlekstrand.net>
>>> Cc: Christian König <christian.koenig@amd.com>
>>> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>>> Cc: Chunming Zhou <david1.zhou@amd.com>
>>> Cc: David Airlie <airlied@linux.ie>
>>> Cc: Daniel Vetter <daniel@ffwll.ch>
>>> Cc: dri-devel@lists.freedesktop.org
>>> Signed-off-by: John Stultz <jstultz@google.com>
>>> ---
>>>    drivers/gpu/drm/vgem/vgem_drv.c | 3 ++-
>>>    1 file changed, 2 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
>>> index c5e3e5457737..e5427d7399da 100644
>>> --- a/drivers/gpu/drm/vgem/vgem_drv.c
>>> +++ b/drivers/gpu/drm/vgem/vgem_drv.c
>>> @@ -109,7 +109,8 @@ static struct drm_gem_object *vgem_gem_create_object(struct drm_device *dev, siz
>>>    }
>>>
>>>    static const struct drm_driver vgem_driver = {
>>> -     .driver_features                = DRIVER_GEM | DRIVER_RENDER,
>>> +     .driver_features                = DRIVER_GEM | DRIVER_RENDER |
>>> +                                       DRIVER_SYNCOBJ | DRIVER_SYNCOBJ_TIMELINE,
>> Well that's rather surprising. I'm not an export on VGEM, but AFAIK you
>> need to adjust the CS interface to support that stuff as well.
> Apologies, could you clarify a bit more what you mean here?  This was
> just helpful to enable the generic userland ioctls for the example
> test tool in this series.
>
> Are you proposing to add interfaces so the vgem driver can
> attach/signal syncobjs similar to the
> DRM_IOCTL_VGEM_FENCE_ATTACH/DRM_IOCTL_VGEM_FENCE_SIGNAL calls?

Yes, exactly that. I don't see how it would be useful otherwise.

Christian.

>
> thanks
> -john