Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220713074118.14733-1-frieder@fris.de> <20220713074118.14733-5-frieder@fris.de>
In-Reply-To: <20220713074118.14733-5-frieder@fris.de>
From:   Heiko Thiery <heiko.thiery@gmail.com>
Date:   Wed, 13 Jul 2022 09:52:42 +0200
Message-ID: <CAEyMn7a7S6UZOTsubM3pY95diY0oR0WNvhQpTUSmedjG59Qn9g@mail.gmail.com>
Subject: Re: [PATCH 4/6] arm64: dts: imx8mm-kontron: Use upper case PMIC
 regulator names
To:     Frieder Schrempf <frieder@fris.de>
Cc:     devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Frieder Schrempf <frieder.schrempf@kontron.de>,
        Fabio Estevam <festevam@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Frieder,

Am Mi., 13. Juli 2022 um 09:41 Uhr schrieb Frieder Schrempf <frieder@fris.de>:
>
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>
> Use upper case PMIC regulator names to comply with the bindings.
>
> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> ---
>  .../freescale/imx8mm-kontron-n801x-som.dtsi   | 22 +++++++++----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> index 2d0661cce89b..2e3d51bbf92e 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
> @@ -85,7 +85,7 @@ pca9450: pmic@25 {
>
>                 regulators {
>                         reg_vdd_soc: BUCK1 {
> -                               regulator-name = "buck1";
> +                               regulator-name = "BUCK1";

Wouldn't it be better to use the real signal or voltage rail names
used in the schematics?

Like it is done here as example:
https://elixir.bootlin.com/linux/v5.19-rc6/source/arch/arm64/boot/dts/freescale/imx8mn-evk.dts#L44

Or use a name that includes both information (signal + PMIC out):
https://elixir.bootlin.com/linux/v5.19-rc6/source/arch/arm64/boot/dts/freescale/imx8mp-verdin.dtsi#L445

>                                 regulator-min-microvolt = <800000>;
>                                 regulator-max-microvolt = <850000>;
>                                 regulator-boot-on;
> @@ -96,7 +96,7 @@ reg_vdd_soc: BUCK1 {
>                         };
>
>                         reg_vdd_arm: BUCK2 {
> -                               regulator-name = "buck2";
> +                               regulator-name = "BUCK2";
>                                 regulator-min-microvolt = <850000>;
>                                 regulator-max-microvolt = <950000>;
>                                 regulator-boot-on;
> @@ -107,7 +107,7 @@ reg_vdd_arm: BUCK2 {
>                         };
>
>                         reg_vdd_dram: BUCK3 {
> -                               regulator-name = "buck3";
> +                               regulator-name = "BUCK3";
>                                 regulator-min-microvolt = <850000>;
>                                 regulator-max-microvolt = <950000>;
>                                 regulator-boot-on;
> @@ -115,7 +115,7 @@ reg_vdd_dram: BUCK3 {
>                         };
>
>                         reg_vdd_3v3: BUCK4 {
> -                               regulator-name = "buck4";
> +                               regulator-name = "BUCK4";
>                                 regulator-min-microvolt = <3300000>;
>                                 regulator-max-microvolt = <3300000>;
>                                 regulator-boot-on;
> @@ -123,7 +123,7 @@ reg_vdd_3v3: BUCK4 {
>                         };
>
>                         reg_vdd_1v8: BUCK5 {
> -                               regulator-name = "buck5";
> +                               regulator-name = "BUCK5";
>                                 regulator-min-microvolt = <1800000>;
>                                 regulator-max-microvolt = <1800000>;
>                                 regulator-boot-on;
> @@ -131,7 +131,7 @@ reg_vdd_1v8: BUCK5 {
>                         };
>
>                         reg_nvcc_dram: BUCK6 {
> -                               regulator-name = "buck6";
> +                               regulator-name = "BUCK6";
>                                 regulator-min-microvolt = <1100000>;
>                                 regulator-max-microvolt = <1100000>;
>                                 regulator-boot-on;
> @@ -139,7 +139,7 @@ reg_nvcc_dram: BUCK6 {
>                         };
>
>                         reg_nvcc_snvs: LDO1 {
> -                               regulator-name = "ldo1";
> +                               regulator-name = "LDO1";
>                                 regulator-min-microvolt = <1800000>;
>                                 regulator-max-microvolt = <1800000>;
>                                 regulator-boot-on;
> @@ -147,7 +147,7 @@ reg_nvcc_snvs: LDO1 {
>                         };
>
>                         reg_vdd_snvs: LDO2 {
> -                               regulator-name = "ldo2";
> +                               regulator-name = "LDO2";
>                                 regulator-min-microvolt = <800000>;
>                                 regulator-max-microvolt = <900000>;
>                                 regulator-boot-on;
> @@ -155,7 +155,7 @@ reg_vdd_snvs: LDO2 {
>                         };
>
>                         reg_vdda: LDO3 {
> -                               regulator-name = "ldo3";
> +                               regulator-name = "LDO3";
>                                 regulator-min-microvolt = <1800000>;
>                                 regulator-max-microvolt = <1800000>;
>                                 regulator-boot-on;
> @@ -163,7 +163,7 @@ reg_vdda: LDO3 {
>                         };
>
>                         reg_vdd_phy: LDO4 {
> -                               regulator-name = "ldo4";
> +                               regulator-name = "LDO4";
>                                 regulator-min-microvolt = <900000>;
>                                 regulator-max-microvolt = <900000>;
>                                 regulator-boot-on;
> @@ -171,7 +171,7 @@ reg_vdd_phy: LDO4 {
>                         };
>
>                         reg_nvcc_sd: LDO5 {
> -                               regulator-name = "ldo5";
> +                               regulator-name = "LDO5";
>                                 regulator-min-microvolt = <1800000>;
>                                 regulator-max-microvolt = <3300000>;
>                         };
> --
> 2.37.0
>