Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 16:32:16 +0800
From:   Xin Ji <xji@analogixsemi.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        bliang@analogixsemi.com, qwen@analogixsemi.com,
        jli@analogixsemi.com, Rob Herring <robh@kernel.org>,
        linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v17 1/2] dt-bindings: usb: Add analogix anx7411 PD binding
Message-ID: <20220713083216.GA2789798@anxtwsw-Precision-3640-Tower>
References: <20220713072943.2789612-1-xji@analogixsemi.com>
 <1cbe0b48-c472-2bd8-9153-6ef0412adefe@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1cbe0b48-c472-2bd8-9153-6ef0412adefe@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/2XXakxC+gtz8Ky6bEeLCYqRP5XZwjtDXgl8rCxggT16qt31oiYkdvdGIje/?=
 =?us-ascii?Q?5Qx+9/N+493FFjJUC8KN7nx71EaFGSyfBviAeR28Af/7uPhGDIE7UebG7+GM?=
 =?us-ascii?Q?MqdNFHmYBisqbQ+JDlWFvc3dyt+vGzYRtBiUcWVr66YoBrSBH/aEQEowzm+r?=
 =?us-ascii?Q?SXTkhdFRKTSpbYc9g0kTbgNwyrQXIR/EWpMjZJDkNnnyzG181O7E6/uuMp4H?=
 =?us-ascii?Q?I8SYFycDQMid0sgDKgKY/nk3oXTnk6Sld7L7jQW7zsFr30vxbZwpGsEeIvqo?=
 =?us-ascii?Q?u7M1oRMVvQdTTspB8REHHpZ20ou3hXV8cw+9jDnO0IxZYo5QSwNp0Clqxtl1?=
 =?us-ascii?Q?vczJcqgm5tth2+kWyv5230SUvw44mgR5yAe9AqCrqlZFQlcKJ47YfejWz6F1?=
 =?us-ascii?Q?vmH5utDoaVdHPQSqXqkYKsoIvff7wTX+tuAK5nHKJG/A5YGRc6FNQzbieIy+?=
 =?us-ascii?Q?HHBlf/KmroCqjiG606j/mO/5NN+nq5E4VJbGFbCIKd0XE09jbicn3Z11wKGA?=
 =?us-ascii?Q?PmLSVtOdqU+h/ocZLINpT3AW78aOcp2Jj1NnIk/8cC9aDIdlb/rUAY+uzfLW?=
 =?us-ascii?Q?U5f07qJ9MBvEk+vrAImyPOHDmUGTnd3J0oEK0Hh35f6R7Xa+sWmZf5Cd6uld?=
 =?us-ascii?Q?F/kz31PXReYpp8Tmc0LvapDijOZ7q6bioLMqqnWoGk42lao2ivK575gY+gQy?=
 =?us-ascii?Q?lgawii9PhELcsp4NhjBiT/y6dHPxWIcshuekqG+jnDIeeaiL0nVPnTpv5iil?=
 =?us-ascii?Q?ONnTY2hwgcffk2N+Z61ihzQCAMUOpkvSn0X4mblqjaof/Nx7ofDlSFN1pMRA?=
 =?us-ascii?Q?oKgpg84Vdk/TyGF1G1dUf9+/R/a3gpjUmMLzcHLbFty0gbC1UFwdMrhiFFat?=
 =?us-ascii?Q?BqPYMJE5gJxb+cH3HQtT2LnlDsbV16wjdpYe+sBN7rYf2RB7VxzXd+3UzU7Z?=
 =?us-ascii?Q?5FLpNkqAZ/tet4D7/ged+pVzgu0MDh65iOItoguVsITRzFLoqJtBoKHCXVY1?=
 =?us-ascii?Q?YjUrz4+CDirubrrMjeL9Gg7gsTXvJ1v0nTW0bjy602I/juz+5vEsOXbqiujQ?=
 =?us-ascii?Q?pH4FGtAvGr9G/yV5RiOf8gwoz98A8po7fkloyfJBjZHkS7xFUkV7ATreCgTD?=
 =?us-ascii?Q?UcGvUwEPXrdxPRZZHdA276yyxelquE2PYo7wRX7Vl99jXhN3qwI078NNcJiV?=
 =?us-ascii?Q?CLM07wTZfYfoWb7UTV0p6Ul0DTIk5NS38PcitVf2wOC+BogFE767wBXJx0tD?=
 =?us-ascii?Q?Q178mIh+oQkSiZpF+lomwxi/BC4QCk1tcsqMaVOx20Sw3BRyW8r6bt+nu0I8?=
 =?us-ascii?Q?R3VDWFrAeuvn1PcN0P1McaNLFYGyXfwb6z/J6rImMlidqKlYWOm6yOe6CY0C?=
 =?us-ascii?Q?DNLqxpdA1BPUrQ8tr1T4PNctZRYVZsOpCYCcc7tFR3Vhv4dRpACQYywKAL1l?=
 =?us-ascii?Q?6Btkw4SkOW74vVJqTqqSSyZbekMBDMUskZbpw6onoFOZXU1DVZp7WC0dIyxx?=
 =?us-ascii?Q?eE+BVs81xc5/A18Abjf/jqdr9oFw5XDRHTU9IAnpJZapltGQtB756cpbfff7?=
 =?us-ascii?Q?NeU+LzzNH2arMME3c4q4pCEELKr5o61hO2nTy0D3?=
X-OriginatorOrg: analogixsemi.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 796d41c3-eeb6-477f-c2cc-08da64aa3618
X-MS-Exchange-CrossTenant-AuthSource: BY5PR04MB6739.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 08:32:24.3082
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: b099b0b4-f26c-4cf5-9a0f-d5be9acab205
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: vjc9DjH0v0Sg+YGFuLdkX0Ip2L+bDSctHRSqFdsDakrGzGnp1e2Y0KPZGzwoK6CWFyBKu0mWhgCVeGaMt1l13Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5340
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jul 13, 2022 at 10:25:55AM +0200, Krzysztof Kozlowski wrote:
> On 13/07/2022 09:29, Xin Ji wrote:
> > Add analogix PD chip anx7411 device binding
> > 
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Xin Ji <xji@analogixsemi.com>
> > 
> > ---
> > v16 -> v17 : Add node name "usb_typec"
> > v15 -> v16 : No changes
> > v14 -> v15 : No changes
> > v13 -> v14 :
> >     1. Fix Robot compile error. Fix node name not correct.
> >     2. Change HEX to lowercase.
> >     3. Use "ports" property.
> > v12 -> v13 :
> >     1. Drop the quotes for "$id" and "$schema"
> >     2. Remove "allOf" label
> >     3. Change node name from "i2c1" to "i2c"
> >     4. Change node name from "typec" to "usb-typec"
> > ---
> >  .../bindings/usb/analogix,anx7411.yaml        | 81 +++++++++++++++++++
> >  1 file changed, 81 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > new file mode 100644
> > index 000000000000..60aac5765320
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/analogix,anx7411.yaml
> > @@ -0,0 +1,81 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fusb%2Fanalogix%2Canx7411.yaml%23&amp;data=05%7C01%7Cxji%40analogixsemi.com%7C56773c30348841ded78d08da64a9519d%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637932975639786406%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=NEKPMjT9Hxp6uUsnYA%2BnrdVWedWovkV4bls%2BjYQQoDA%3D&amp;reserved=0
> > +$schema: https://nam10.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cxji%40analogixsemi.com%7C56773c30348841ded78d08da64a9519d%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637932975639786406%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=YD4mavtim6InAbpjgHYVzw74RNZTOpyXRkzKqPUVPjY%3D&amp;reserved=0
> > +
> > +title: Analogix ANX7411 Type-C controller bindings
> > +
> > +maintainers:
> > +  - Xin Ji <xji@analogixsemi.com>
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - analogix,anx7411
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  connector:
> > +    type: object
> > +    $ref: ../connector/usb-connector.yaml
> > +    description:
> > +      Properties for usb c connector.
> > +
> > +    properties:
> > +      compatible:
> > +        const: usb-c-connector
> > +
> > +      power-role: true
> > +
> > +      data-role: true
> > +
> > +      try-power-role: true
> > +
> > +    required:
> > +      - compatible
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - connector
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        usb_typec: anx7411@2c {
> 
> Node name is still specific.
> https://nam10.safelinks.protection.outlook.com/?url=https%3A%2F%2Fdevicetree-specification.readthedocs.io%2Fen%2Flatest%2Fchapter2-devicetree-basics.html%23generic-names-recommendation&amp;data=05%7C01%7Cxji%40analogixsemi.com%7C56773c30348841ded78d08da64a9519d%7Cb099b0b4f26c4cf59a0fd5be9acab205%7C0%7C0%7C637932975639786406%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=x4UcIH%2BppZdbgsXf%2FPfvpjyUuvyVZB2tTNQqaXg0iXY%3D&amp;reserved=0
> make it "typec".
Hi Krzysztof, OK, I'll change it
Thanks,
Xin
> 
> Best regards,
> Krzysztof