Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4f121712-25ce-45e1-1faf-abcf55e952d8@kontron.de>
Date:   Wed, 13 Jul 2022 10:25:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 4/6] arm64: dts: imx8mm-kontron: Use upper case PMIC
 regulator names
Content-Language: en-US
From:   Frieder Schrempf <frieder.schrempf@kontron.de>
To:     Heiko Thiery <heiko.thiery@gmail.com>,
        Frieder Schrempf <frieder@fris.de>
Cc:     devicetree@vger.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        Fabio Estevam <festevam@gmail.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        NXP Linux Team <linux-imx@nxp.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>
References: <20220713074118.14733-1-frieder@fris.de>
 <20220713074118.14733-5-frieder@fris.de>
 <CAEyMn7a7S6UZOTsubM3pY95diY0oR0WNvhQpTUSmedjG59Qn9g@mail.gmail.com>
 <02a9b4ca-baf8-9f06-12be-57853893fb50@kontron.de>
In-Reply-To: <02a9b4ca-baf8-9f06-12be-57853893fb50@kontron.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TzZ4WU1mNHN5M1Z5R2NVSnJORnM5MjlZWUVqb2xheVM4Kzh5U1BnM1lWSHY4?=
 =?utf-8?B?S1cyQnI3VHlYK0ZVVTd3VUJ4NjJFMk9XcmZuUXFGbld0M29uMWlycUhoV21G?=
 =?utf-8?B?Wi9xK0RMT1MxQ0hiL1JxQzJUTDEzOFNRRWoyNHJFZ1pYWXl3Qzd3Q3N4SWQ0?=
 =?utf-8?B?WTM4MUF4dFZYWFBQa0tmVXV5ZkxkZnMvZ3ZQMTFxSm96UnJOcGhSL0dsa3ZF?=
 =?utf-8?B?UTVpSGJEK1VlVlVRSExDcHhPNWRjSUM2NVFxTVFDUkhMaUt6N1VQVi9zVnFO?=
 =?utf-8?B?ZFNaQWlIcUkvVnpLWUNRMnI2WTJrN01HZitPamdibDVwZktjWG9ubGc4VjBy?=
 =?utf-8?B?Z0JEdzlrbTdCcXQrbGtpa1ZEclRaTG94cEJOcUNkRk1KVndNc2pRZWlqYlpZ?=
 =?utf-8?B?dWVUYzdSQUo3cWVEckpFaGNUckZZY0ZWV1ZOdCtCWWtjRWNpNzJaMi9RS2Vm?=
 =?utf-8?B?Q2NFTnpkdFpUYTNEdEVKYmMvZW1VNkdNM3EzVDJwMVFaNmdFLzVmYnlzOWZF?=
 =?utf-8?B?bUpFaEtITk12QjN0dld4ZFRMeHpxUzZaZ0JTVjVIWkYwV2gwNHY5aWxZSHhq?=
 =?utf-8?B?VWM1VHZMK0lVbHRDTmJkLzBtcFNOWFNzWU15YjFtS3o3WDBpYk14SFNoNkFt?=
 =?utf-8?B?VW1WbDRrbHBUclZhVmhuMlVLdG9oVktLWmpDbnl0WHppSi8xT3Y1UjB3WHNX?=
 =?utf-8?B?VlZkdE4rMnBxRWVNUzR5dUovRnkxTlNTWDRvcVhNdWtTeFMzS2pITkpSTS9R?=
 =?utf-8?B?MmJhcUQ5Z1lFbnU2Y0o0R1QxZGczOEpkdkZDQnM0cUk1NFRQZCs0dmVjZldv?=
 =?utf-8?B?R3JtQkNtMGpBWDJNWGhDdy92ZDQ5N1BwSk1iUjExeUV3MnljS1BmTk5tays1?=
 =?utf-8?B?TDRWOUpFOXYzVFZVM1dUOVVyQ2NScHE3T0pkU3llUUhMMVU5M3FVUWF6NnZp?=
 =?utf-8?B?cHI3QUpSc1Jsb1Z4ZDhDa3B0ejNVaFBVNTB5WlJBUjhySkNSTThLTWZVWFdz?=
 =?utf-8?B?YWpsZnlyOGxjTTVCY3FLUDdtTUdMRlg0OUVJVEJkRzArZzJtdzg2N0JFeVJq?=
 =?utf-8?B?bjV6LzNNREY2VFdSM2NTSEpMM21QeVY0eGVsbnBqdGFBQmhyS0hXOG1ZYjl2?=
 =?utf-8?B?Z2VRQW95NmdHZFBtRTZsV2JTRVNOYkFYdTc2MU5hUzZ2Y2dNUExLOExQKzVG?=
 =?utf-8?B?VDl0WTB0UWZvcld3d01iWDE1THh6MzVhTnF6aTZIVHRMc3FuQnl2ZUo5Vm9O?=
 =?utf-8?B?bU1CUTFaV3YxR0RzNkY0bk4wQ3hqNEtHKy9Bbk1qQ2Z1cVhtdW1DVS9VNTZD?=
 =?utf-8?B?YklsdjBMOE5iWTlBeFpEZjgxaWNUdE9ZcmVsTUhUUGRRMVZ5bFo5clV2S3V0?=
 =?utf-8?B?Nk1yam9wSm01ZmpLZEFLVFVSWGYrY0piM0FqdWZSWnFIZ1VET1VWUy9JQ2hW?=
 =?utf-8?B?bTNiMU1GSTFVemJ0TWR5cEJLRHQzYzVJYTV6a2ZNNUlmS0NsSTd6STU3aFA3?=
 =?utf-8?B?K0V0bGdiZW56RE1COXZkQ08wLzBBMXVZWlh4cDhveUFLMXRRTHBHVFkvZ2xm?=
 =?utf-8?B?eTNTd0tiTjRsa05JUzZTaWtSSUpkV3dQM0E4eE1lTUZnYVEzblE5N2hZOUVh?=
 =?utf-8?B?WitkWGtDcE9WZDhiK3k5QTJYVXhqR0k2alRJU2JtcTJLak1iM2ZRelZYWXZP?=
 =?utf-8?B?OUE0UXI2ZnROejFtZFZ2MmdyUExreVdjc2VoTngvWmlWY2xTK3lyTXRnNDU3?=
 =?utf-8?B?bmJGTjQ2dEx6ZzM0ZmZ1ZE9meE9oSTc2a3ZLSlZzaGhyMDJTKzkvZlZzRTEw?=
 =?utf-8?B?SlYzRS9PeEFKNEM1YkxsTy96MjNtMEQvcld0RVZhT3htYWxaa1FWL0wyb3c4?=
 =?utf-8?B?b243bHhWR0JlQlBLTm02ZU00MjdCenVLejE5S3E1bzliQ0c1VUg0c05QL1lM?=
 =?utf-8?B?MmVvRWZrRExuZVNxWXR5OUt2Rlk5a3ZobFVKZzR1bWVuMVRqR28xa0RzcE1w?=
 =?utf-8?B?Z0pQdHpxSS9Lam9YMlU5azFjVFpPWVF5UEJJdzVGUXZmVkdHMzJuc0V2Q0FO?=
 =?utf-8?B?eXdscUtXRlc2QzhpTUZUcFZmek1sMmRzZlVJck1obEVtLzc1YlVMemRwWEdU?=
 =?utf-8?B?eU5uUXAvYnBQWHB3K256aHJKOGk1Y3Z6TmlIMHBaQjNldFpTeHZkRzhYWER5?=
 =?utf-8?Q?2XrzWIj4iA23YMATIZikUMykSimGB6WcFl/ouD4QosZj?=
X-OriginatorOrg: kontron.de
X-MS-Exchange-CrossTenant-Network-Message-Id: 2a0ab3af-f3e5-4891-799f-08da64a94278
X-MS-Exchange-CrossTenant-AuthSource: PA4PR10MB5681.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 08:25:35.6600
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2QmWAl9qArYmJ/8+z0E6l18iXHnX+SmvS0WGt8uQbHN0QZXAJP0/5XbOiQTx7iJgUUYeKFMHImjQnOUEPcYGVf03gRsQ39cTNVOjOBLlX1M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR10MB1547
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
        SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 13.07.22 um 10:15 schrieb Frieder Schrempf:
> Am 13.07.22 um 09:52 schrieb Heiko Thiery:
>> Hi Frieder,
>>
>> Am Mi., 13. Juli 2022 um 09:41 Uhr schrieb Frieder Schrempf <frieder@fris.de>:
>>>
>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>
>>> Use upper case PMIC regulator names to comply with the bindings.
>>>
>>> Signed-off-by: Frieder Schrempf <frieder.schrempf@kontron.de>
>>> ---
>>>  .../freescale/imx8mm-kontron-n801x-som.dtsi   | 22 +++++++++----------
>>>  1 file changed, 11 insertions(+), 11 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>>> index 2d0661cce89b..2e3d51bbf92e 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>>> @@ -85,7 +85,7 @@ pca9450: pmic@25 {
>>>
>>>                 regulators {
>>>                         reg_vdd_soc: BUCK1 {
>>> -                               regulator-name = "buck1";
>>> +                               regulator-name = "BUCK1";
>>
>> Wouldn't it be better to use the real signal or voltage rail names
>> used in the schematics?
> 
> Sounds like a good idea, thanks! I will try to include in the next
> version of this patchset.

On the other hand, the bindings stipulate that the regulator-names
should be "^BUCK[1-6]$" and "^LDO[1-5]$". But I admit these names are
not really useful and maybe the bindings should be changed to allow
arbitrary names?