Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Date:   Wed, 13 Jul 2022 11:03:40 +0200
From:   Michael Walle <michael@walle.cc>
To:     Philipp Zabel <p.zabel@pengutronix.de>
Cc:     linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        =?UTF-8?Q?Cl=C3=A9ment_L=C3=A9ger?= <clement.leger@bootlin.com>,
        Claudiu Beznea <claudiu.beznea@microchip.com>,
        Kavyasree Kotagiri <kavyasree.kotagiri@microchip.com>
Subject: Re: [PATCH] Revert "reset: microchip-sparx5: allow building as a
 module"
In-Reply-To: <20220713084010.168720-1-p.zabel@pengutronix.de>
References: <20220713084010.168720-1-p.zabel@pengutronix.de>
User-Agent: Roundcube Webmail/1.4.13
Message-ID: <73dc6fcedebcae098751bd093fe2d028@walle.cc>
Precedence: bulk

[+ Claudiu, Kavyasree ]
Am 2022-07-13 10:40, schrieb Philipp Zabel:
> This reverts commit b6b9585876da018bdde2d5f15d206a689c0d70f3.
> 
> This breaks MDIO on kswitch-d10, presumably because the global switch
> reset is not released early enough anymore.
> 
> Reported-by: Michael Walle <michael@walle.cc>
> Cc: Clément Léger <clement.leger@bootlin.com>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

Thanks!

Tested-by: Michael Walle <michael@walle.cc>

And maybe Microchip can chime in here and tell us what
subsystems in the SoC will actually be reset by this.
I fear this reset will affect almost every part of the
SoC. So it would have to be bound to every single
device? Or maybe adding that reset to the switch driver
was a mistake in the first place?

I mean, if it wouldn't be for the guard bit, it would
also reset the CPU core..

-michael