Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9aa8538b-d535-4de5-6e07-fd81d2b3db33@amd.com>
Date:   Wed, 13 Jul 2022 11:15:59 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v2] drm/syncobj: Fix sync syncobj issue
Content-Language: en-US
To:     "Das, Nirmoy" <nirmoy.das@linux.intel.com>,
        jie1zhan <jesse.zhang@amd.com>, broonie@kernel.org,
        dri-devel-bounces@lists.freedesktop.org,
        dri-devel@lists.freedesktop.org
Cc:     Vijendar.Mukunda@amd.com, Basavaraj.Hiregoudar@amd.com,
        Sunil-kumar.Dommati@amd.com, ajitkumar.pandey@amd.com,
        lucas.demarchi@intel.com, lionel.g.landwerlin@intel.com,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        open list <linux-kernel@vger.kernel.org>
References: <20220707102953.769684-1-jesse.zhang@amd.com>
 <22a21338-305d-bdf7-0079-df67fb030fc7@amd.com>
 <43192086-b9a6-387c-4a29-ea28aa65a3b4@linux.intel.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <43192086-b9a6-387c-4a29-ea28aa65a3b4@linux.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEpBTmxieFBQY2lOSm5oc2RkNUV1VGNsaVVmeG5oZXVaR3FwbVVPdnZzSVRG?=
 =?utf-8?B?WDFYL1RQQWVUdWVPWXRBRnU0M0FoZHRxYTByT1Y5WEp5V05xNFBBdk5nRGlv?=
 =?utf-8?B?RjZXM1BmeEMwLyswcGtiM0Nhb0ZlSkNkZFhGTnZjNkZ0VDUxdG5uWUJIaFRh?=
 =?utf-8?B?NE9XWU5ZcXNUYWV5dTVWY3FtVGpGYlhkc2lXVzNEbUhyU1pzTVVjeUI2WWc4?=
 =?utf-8?B?NWZDWHBGZ0FRdk13U21scFBxeEszME00bkdOYjN3bktZeEJVZzRSVmw2dDk5?=
 =?utf-8?B?UHZCejFIcVJ3RU12cHBKaTZDRFVUQXEvU1ZxTmtTcjdPenp3cU1kY2pJcGZz?=
 =?utf-8?B?bC82bzFOaU1iY2tHUlBWUDF0T1J4M2R6N2x0VERzWDhQNnREV2FhTXh1cXNw?=
 =?utf-8?B?T29wZml0eFc4aGhiRVFSUm5YNlJ3RUxWY2c1MTlmU0twc29PWnZocnEzck1p?=
 =?utf-8?B?YnpCMmc2WGJvUTNYU2loSzRCMFZFZ2NFL0tZckt3V0dJT08yMjNEZDYwODJq?=
 =?utf-8?B?cWVHd0FvaHdxdExlSEJjd2FTZmp3QmZwN2tGSllkY3l3MTZKdG5SeUozTXBj?=
 =?utf-8?B?ank4czE0MEM5S05wVVJiRnRlSnBQa1BFckw4TERWOXpFdUJHQWdmcUdsWGNm?=
 =?utf-8?B?UFVFa1MvcWk2SDhFYnZCRTJOQThmdGRoaloxeVdla3VZcjNPcWNSTmZGU1V3?=
 =?utf-8?B?aUFuS0NjVXFKVit0N1lqdmIxdmFpYnRSN0drQ21sWUVHdW1ycW9PNUhYV3Ri?=
 =?utf-8?B?bUNIZitCMkROQWI0UVh4LzJHZERqVFhyb0o0aEZ2dXZJdGxFR0xiR3lUZVlh?=
 =?utf-8?B?NFVhcStsc21FUVVjVGxFUTF6NVArdDJOVDRyQVpWUXZReEpTNnljQW83Vnp0?=
 =?utf-8?B?MWlqYmFJUXE1WVA1WXhHNHY5ME5sdmlBeHZxZWxmbno0THM5bHlSVXN1aEZz?=
 =?utf-8?B?dExON3gxYkd2UW05OS9GVHp4MTdqOXkxMExFQlFpNkJSelZCUHpIazVxcTQ2?=
 =?utf-8?B?SWpXTk55OWR3Q1JXQksyYzRoU3N3OUpNRVc2UXpHbkdwNTMrMzl5S0pBYzk5?=
 =?utf-8?B?eGQzUTJQWUhSZVdTNTU5b0l6OHNSRitFQlF1UkovTmZjdUI4UTQwN3FHeFVE?=
 =?utf-8?B?dVZQQllvM3drMWFlSXdHQVQxMEN6aGwxblY5MXBsSlZUcytucnpKa3Eva3JK?=
 =?utf-8?B?M2ZDSHNoMGo2Q21IM0ExQWYyUUlvelpBeUFIVE90bkVrc3JPVll1WDBjYWdR?=
 =?utf-8?B?QUhBZlEzOWJxdGg0NlNWU1E4c3ZFOFExWFNoVUFSWUF2dWpzdGkwNnBjUmpu?=
 =?utf-8?B?V0V6bUJ3Rm05cThOd1paQ1ZDbmJPeGYzZThmYnNyUXIxcHd6ZU0wQkFNVnh2?=
 =?utf-8?B?K0NEdnpqVE42S3hGTDdoVHpMYWcvaWUzSWZ1Q3RtcTZwNml4SWRnODVnMVVB?=
 =?utf-8?B?OU1LMTZkY0Q2cmlsNVBJRHY1NGJSc3BGRDNuTTdCaS9UYTFxUEt4aHdqVFlX?=
 =?utf-8?B?UC9YZ0FHdnYybkE4T0ROaEJOdkVEeFlrbFRYQ25SMk1CUzhNV2dqdi94S3dn?=
 =?utf-8?B?bFgwaTUxZE9oLzBzOWNvZUd2VTEzZUw5MkhjdGhBYXIwQ1NQbVlGK3Zsd25K?=
 =?utf-8?B?ZGlpeGtPMXhidVFPSW5GM0d5d2NOdHp4ZTFFbWJiNzBhcXBTVHgxWk5vekRv?=
 =?utf-8?B?OXVZbS8rcnpnSFZjNjQ1N2FuUG1tWCtkTnZBc0pydWgwTkR6b2JmQlRRbVNn?=
 =?utf-8?B?bFlJcHlUV3dTRGFwMURvZUdGSDdoOEc2OHJxa3ZYbmpwekZrcENFM3hIMkc1?=
 =?utf-8?B?QVpOT0YyTG1TTFBtUlhBOS9qNktOd21ySWJnaUo3VGxlWUR4dnFBYnNSQVRC?=
 =?utf-8?B?N0RhUUFWa1d4SXBSOVhiWUlWdmNET0dLUVl0NXZKS3BGa1BvUGlCTHQxdith?=
 =?utf-8?B?a0ZuNnh4N2d6d0lpM1pEaUhhYy9NSmxEazdrekhxTmFQWEEwQlRQZ0dnR1lH?=
 =?utf-8?B?NmU1cU5qRnVQa2FlUTRMRnFGZzVYTjByYVc3MUlXWCtZYUJGRVdJQ1d0Tzdh?=
 =?utf-8?B?ejNuMXlQdTdmYmRpL2EvZnZOMXFmdEQ3cjR1NXg5SHJWb09VMFRNVWgyYjZu?=
 =?utf-8?B?WmNOZ1M2R2pqcTBTYTlHbU9zTDJRcVNGSWlRZ0hDWUpRKzh4aEJPQVphN3Y5?=
 =?utf-8?Q?aPi0lkY1LXN3zbj9DDOudj8K8z+a4m4WCTatztbxVi73?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d20fc1d-dc00-4b09-13f4-08da64b0509f
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 09:16:05.6752
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0k7hB+N2VCdrtX97fjaeKf3VkaXfCDO4dFNDeZW6KywOWyLXRA14FgbXhL/Fs8yI
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4167
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 13.07.22 um 10:42 schrieb Das, Nirmoy:
> Hi Christian,
>
> On 7/12/2022 12:26 PM, Christian König wrote:
>> Ping to the Intel guys here. Especially Lucas/Nirmoy/Lionel.
>>
>> IIRC you stumbled over that problem as well, have you found any 
>> solution?
>
> I might be wrong but  I think you are talking about 
> igt@syncobj_timeline@transfer-timeline-point testcase which seems to be
>
> green in CI now 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fintel-gfx-ci.01.org%2Ftree%2Fdrm-tip%2Figt%40syncobj_timeline%40transfer-timeline-point.html&amp;data=05%7C01%7Cchristian.koenig%40amd.com%7C722fc33842734ef5c05108da64abac60%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637932985747614383%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=q8JygSVZfGA8cEZn%2BdxVXX79pkpXRjZTS8kBQ6Lq%2Bmw%3D&amp;reserved=0
>
> Lucas found out that the issues got fixed after ec8d985ff26f ("drm: 
> use dma_fence_unwrap_merge() in drm_syncobj")

Yeah, but that's just coincident. The original bug that we fail to 
enable signaling in the syncobj is still there.

No that this is any major problem, but it would still be nice to have 
that fixed.

Regards,
Christian.

>
>
> Regards,
>
> Nirmoy
>
>>
>> Regards,
>> Christian.
>>
>> Am 07.07.22 um 12:29 schrieb jie1zhan:
>>> enable signaling after flatten dma_fence_chains on transfer
>>>
>>> Signed-off-by: jie1zhan <jesse.zhang@amd.com>
>>> ---
>>>   drivers/gpu/drm/drm_syncobj.c | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/gpu/drm/drm_syncobj.c 
>>> b/drivers/gpu/drm/drm_syncobj.c
>>> index 7e48dcd1bee4..0d9d3577325f 100644
>>> --- a/drivers/gpu/drm/drm_syncobj.c
>>> +++ b/drivers/gpu/drm/drm_syncobj.c
>>> @@ -920,6 +920,7 @@ static int 
>>> drm_syncobj_transfer_to_timeline(struct drm_file *file_private,
>>>       if (ret)
>>>           goto err_free_fence;
>>>   +    dma_fence_enable_sw_signaling(fence);
>>>       chain = dma_fence_chain_alloc();
>>>       if (!chain) {
>>>           ret = -ENOMEM;
>>