Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <22805e12-7144-037f-c58c-4bc182d27919@leemhuis.info>
Date:   Wed, 13 Jul 2022 11:47:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: Regression in v5.19-rc4 Sound Distortion
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        Daniel Exner <dex@dragonslave.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
References: <46fd7a73-06fd-a8a0-8530-0ecf9b18c08d@dragonslave.de>
 <f8725aba-2cd1-c79c-eaf9-d272c140049e@collabora.com>
From:   Thorsten Leemhuis <regressions@leemhuis.info>
In-Reply-To: <f8725aba-2cd1-c79c-eaf9-d272c140049e@collabora.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12.07.22 18:35, Dmitry Osipenko wrote:
> On 7/12/22 19:02, Daniel Exner wrote:
>
>> Since  v5.19-rc4 this box got some *loud* distorting sound on boot and
>> after some time without any sound if something plays sound again from
>> the integrated speakers in my monitor.
>>
>> I managed to bisect this down to:
>>
>>> commit 202773260023b56e868d09d13d3a417028f1ff5b
>>> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>> Date:   Fri Jun 17 15:24:02 2022 +0300
>>>
>>>    PM: hibernate: Use kernel_can_power_off()
>>
>> Reverting that commit on top of v5.19-rc6 does indeed fix the problem here.
> 
> You're saying that the problem is on boot, but this patch is about
> suspension to disk, which has nothing to do neither with the boot nor
> with power-off. I'm afraid your bisection is incorrect.

After quickly looking at the code this looks appropriate, but why does
reverting that commit help then? That's a bit odd. Daniel: are you maybe
using suspend-to-disk and forgot to mention it?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.