Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp532985imw; Wed, 13 Jul 2022 03:20:43 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vA+WajEYfqkmfYGlrkp5yotsH0uCrl8NjypFxQ0tyu6j/ib8OcOwB9NNKIb2hp/0JLBdBX X-Received: by 2002:a17:902:8b85:b0:16b:c407:f2b5 with SMTP id ay5-20020a1709028b8500b0016bc407f2b5mr2392082plb.35.1657707642903; Wed, 13 Jul 2022 03:20:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657707642; cv=none; d=google.com; s=arc-20160816; b=ojtq3lslYDmyTCdCz4VA6TwOQEDWV+xXTt6uMd4x76n1SKO1oy2uTBAOp085Vjv3Rg cRM8shNpB4BzkyVWFvYw77xbE1Q4dgYT30iwSPVMIQEFh3AGooPfAH7NHRCmWUMNsuyG jJOWbmlQYgoJYpqBzWfeY97AG775iw1nWp0IDoOD/DhQ/N1NCqjMwmIMspLhpAPhwwhj v5or1afFAvJHvwL1wMNo4UB5DSTYwsuVQZsmJ5aYnNNT0vAEvoc+g6MeJ95P2ekv/NpR EpSGBdLmz6ogXQA/kNBzV810SqPRCat0w5maJltZahNP/LIyNIEZaGyAoPr7kedP14D/ JdHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=B/bZLQ21BnbCxpHA4zoKoOFFh9G3ZriCKWCB4lTGRTU=; b=ZMxrhrkM8Ha+UTHMSHJfcnD9iOKqtlr+eUucJDUmpMJhF3BkU6HTCkzu1l4dfgxyRN GOci9ztNh0UU6nT4LUgkKU+ktRIL2vHJkv81FRciksS8gqFk1pfFE4Z2uljyB0AWhQgu VmvuQWxdDVx1il7SKK9d0mJbef2c0VUYGjB6htSiHMeHet+plYhQ8BW2GRJggG8i9tJU YgE50KQhUubZttqqwxk6zKJBeIDRreosCGp4qg5VIx7ItycBsB2xfF9h6lX6WlsF6WW4 Soyrtwi8DReYRVcmvKTzeqFulF7cxeATpSwIg+JkWzj+Hwrcra9fWt8VVmfWUMNgujJx NO8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZO6UB9xl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e10-20020aa78c4a000000b0052571551c57si14334020pfd.296.2022.07.13.03.20.27; Wed, 13 Jul 2022 03:20:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=ZO6UB9xl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236083AbiGMJji (ORCPT + 99 others); Wed, 13 Jul 2022 05:39:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58174 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234588AbiGMJjg (ORCPT ); Wed, 13 Jul 2022 05:39:36 -0400 Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FC10F54E9 for ; Wed, 13 Jul 2022 02:39:36 -0700 (PDT) Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-31c9b70c382so106695947b3.6 for ; Wed, 13 Jul 2022 02:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B/bZLQ21BnbCxpHA4zoKoOFFh9G3ZriCKWCB4lTGRTU=; b=ZO6UB9xl2PomzSnA9P0ERrfsb+F0CnXxcbeTNjkLpFEo+2za3/xXWGbmqKTihGXER4 mUgRTu0USH+xA3FoCVjWLUFkdgJyDitP/5IlrEykEULV55mtPO57VI6rmC/VX416o04i kwQ2YtAApJmvL4GOZ2EoIzNaIBDWwqYuzIng2KRohWNuuIVHdS8JipjKP99t92jluQsC SISG6PGesDj5oYOmbT0cXN8DLCLKvFQyDUy4LXMu77z2q11E2r0MZC87PvFMpE1f/3gy HcQxarJCB6amUiC0bsTHYF7BFZRv9dnUrP+YMZZZOKyEzJfLzJ57y79Rrry3IR8It8sz VUxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B/bZLQ21BnbCxpHA4zoKoOFFh9G3ZriCKWCB4lTGRTU=; b=iZAPOrK1QPZTm0N9NfBeVLdV8dbDG1SflV3EQk66NlLJS0vhWSsffFWjFIgmklPGaC KSs4j9xMgmvah15k/aRbv6K9knlAHr5TBOYsnmgafLQtMPgH7OxuM3qwCAlnkW3rjtS9 mDK8VUlBU2vEuZNs/pcgjwH469Lkmj/gxlgCMnbuErnAaDt6aZbeRedJTp0J3ucUmePj petS888Rj/0QKhAobZyggrDUutbs7Q0CyiO5HCkSuuRN609d4TB2fNdc69fXBTzwcpyO NlurnBhI+9L0D8F/tYOGZr+I7Dj38Bk3EwvbBsupINSZJGgNaHw8NQowcuvYyzkwmPjf 56rg== X-Gm-Message-State: AJIora/aBnrdI1EewK181aS9nBopw6WyI85X0fE6cUGSX94FPuL/ykgf TY9CBzU91GcpGqNjp1DZyD8ZMPqWbXJa0zNSlSM= X-Received: by 2002:a81:4986:0:b0:31d:388b:d08d with SMTP id w128-20020a814986000000b0031d388bd08dmr3002440ywa.185.1657705175260; Wed, 13 Jul 2022 02:39:35 -0700 (PDT) MIME-Version: 1.0 References: <20220707091301.1282291-1-cezary.rojewski@intel.com> <6c8e4104-2239-a188-649d-585f059cabdd@intel.com> <17c91bfb3a864ae1be2ac3226f170f55@AcuMS.aculab.com> In-Reply-To: <17c91bfb3a864ae1be2ac3226f170f55@AcuMS.aculab.com> From: Andy Shevchenko Date: Wed, 13 Jul 2022 11:38:58 +0200 Message-ID: Subject: Re: [PATCH 1/2] lib/string_helpers: Introduce strsplit_u32() To: David Laight Cc: Cezary Rojewski , =?UTF-8?Q?P=C3=A9ter_Ujfalusi?= , Andy Shevchenko , Mark Brown , ALSA Development Mailing List , Takashi Iwai , Jaroslav Kysela , "amadeuszx.slawinski@linux.intel.com" , Pierre-Louis Bossart , Hans de Goede , Ranjani Sridharan , Linux Kernel Mailing List , Liam Girdwood , Kai Vehmanen , Bard Liao Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2022 at 11:14 AM David Laight wrote: > > > if (pint) > > - *pint = value; > > + memcpy(pint, &value, min(nsize, sizeof(value))); > > That is just soooooo broken. OK. -- With Best Regards, Andy Shevchenko