Received: by 2002:ad5:4acb:0:0:0:0:0 with SMTP id n11csp543146imw; Wed, 13 Jul 2022 03:32:59 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uARyNwYrWB9QJLy3DieG+oqyv3PmucQwXEP7waz5Qlxew7jqrwg4yi6bz+6dNusBEmcVOB X-Received: by 2002:a62:79d7:0:b0:52a:b557:2796 with SMTP id u206-20020a6279d7000000b0052ab5572796mr2672510pfc.34.1657708379582; Wed, 13 Jul 2022 03:32:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1657708379; cv=none; d=google.com; s=arc-20160816; b=BDr5OncmvUV1HFhp3TsF/J8iP0Jj408NDtL5GooUGzxDlnSWM1nzuRx8dydQR2oACl oadglVn5a9NhgBhjPT/CcZEja3STOmvbmBbPI/cNsqyO5juBICiD6fRVu6cm3AHo5p8D Z+NmAL2mrODXSaiDt//kGdCEfTyMDYGySyAyvXsDc5NummxVrjfVrtqKFt1CS9PMvyf2 naFT9DasUi0hoDhXlncXvF5J6DpXTuw+BM9If/AfXfVDjXwTjrxVQluvomfXW5YIL/Nk s3zTqRJL6bemKLoVIfQYLIz1ycD4rnFmXVI/wrNuD7FNrEZpfUcdwPIJPUZgGNSrXhrJ zyxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=9+qa3xwQVkTAZSm4H6G+2appJ0LJkU71UTSiAwNKpj8=; b=xKy9sgEq2vhdXSRaaYwfIaO3V/FzPCq+ceiM6Np0pWUWQTxf7Cb8Ffv2sv6fcSHqok /vWAQWX4BOYqA8xeW+XQCeY5RKhUTluN5h9zEs7mIrIaq+wbYqBzhjt9GnLpIsbIAaTR 1FokInWAMgIPAudG86fKx0izTYYJyRa9VoHnuQnQ/nalB2IKhrH9w3sRPi8c468sPqnr 2jMtT9KCnKCKSzP82yKPtzcotEk9Qo183jbKsj9kisPXr7iinGRkKq4U2MoAhR29xq/R N33z7MaDCw3BDApdT61lb8s+mgf8yL6IrcpfgZtKidBUWjyr8TxgbWcfdLDKRMKyVzTY fP3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MyKRjAo4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z21-20020a637e15000000b00415456234b5si17109106pgc.30.2022.07.13.03.32.47; Wed, 13 Jul 2022 03:32:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MyKRjAo4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235683AbiGMKaD (ORCPT + 99 others); Wed, 13 Jul 2022 06:30:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231241AbiGMK34 (ORCPT ); Wed, 13 Jul 2022 06:29:56 -0400 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1756EE5842; Wed, 13 Jul 2022 03:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657708196; x=1689244196; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=xCPTZdPlr/QKclHnOwFieHwilG0LSlbmNN9362YdJ2k=; b=MyKRjAo4mnJiCq/UzI/B+Mhr5EoErog+xjUQeBiyWETk9DmLjW8OjUv0 ebF6J3WRAF26fPfwEUEK90TmbuT4QO80Wvc6u9HQpv0z4XG7rXanygQ77 jxMp2kSs3wCHPgEO37wJx+eMSDUn/Yojl9QbDkPWFU0MZ6sygfvnMrWC4 Go5q7eLvlOrYC9mijQHBuxpXcQ+o/klSnf5+fTydBChN4qzPV+GzwZ9h7 Mwngom/J/7YXhXHC3okFLJEKnVeeUdQVVC0KUevC9BYVUwGN3636VRcjZ Jp/dyRqsJbUSWwWdsh15Yi4YycX3P8JPWjJ2huxX4wq6DJusBj2QSErDa Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10406"; a="371486768" X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="371486768" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 03:29:55 -0700 X-IronPort-AV: E=Sophos;i="5.92,267,1650956400"; d="scan'208";a="570574395" Received: from ifatima-mobl1.amr.corp.intel.com (HELO khuang2-desk.gar.corp.intel.com) ([10.212.1.196]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 03:29:54 -0700 Message-ID: <753184425e9d613841f4870a8a69f8cf96832f8d.camel@intel.com> Subject: Re: [PATCH v7 035/102] KVM: x86/mmu: Explicitly check for MMIO spte in fast page fault From: Kai Huang To: Isaku Yamahata Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , Sean Christopherson Date: Wed, 13 Jul 2022 22:29:51 +1200 In-Reply-To: <20220713083515.GQ1379820@ls.amr.corp.intel.com> References: <71e4c19d1dff8135792e6c5a17d3a483bc99875b.1656366338.git.isaku.yamahata@intel.com> <20220713083515.GQ1379820@ls.amr.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 (3.44.3-1.fc36) MIME-Version: 1.0 X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >=20 > Although it was needed, I noticed the following commit made this patch > unnecessary. So I'll drop this patch. Kudos to Sean. >=20 > edea7c4fc215c7ee1cc98363b016ad505cbac9f7 > "KVM: x86/mmu: Use a dedicated bit to track shadow/MMU-present SPTEs" >=20 Yes is_shadow_present_pte() always return false for MMIO so this patch isn'= t needed anymore.