Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 14:09:08 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Joel Slebodnick <jslebodn@redhat.com>
Cc:     linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com,
        bcm-kernel-feedback-list@broadcom.com, nsaenz@kernel.org,
        athierry@redhat.com, gustavoars@kernel.org, keescook@chromium.org,
        stefan.wahren@i2se.com, gascoar@gmail.com, ojaswin98@gmail.com,
        len.baker@gmx.com, jakobkoschel@gmail.com,
        linux-staging@lists.linux.dev,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org, jsavitz@redhat.com
Subject: Re: [PATCH] remove custom return values in vc04_services
Message-ID: <20220713110908.GR2338@kadam>
References: <20220712181928.17547-1-jslebodn@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220712181928.17547-1-jslebodn@redhat.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5/RLoZhtHICOAJ7dq16TJv0XEnqlMsLHQEDP5/vNpftbKB/Buludt7Myxrh8?=
 =?us-ascii?Q?ZLZRS8aLwHU2cl+c2NdhC4X0ek1RR9w9hPQlqiTPrdNOso2iRvwP3XlFoPPT?=
 =?us-ascii?Q?2DJuMgza7MeE7NXvLq/uY6FUpHjAe683lRtM4CLZJJz7bK+8lLmflopcLUbR?=
 =?us-ascii?Q?OjgBlSrPO0vMwS+8UNh30qpWQrXIOLNblNQ+oAjS8k/HQRC3pyTuFmvnmZJX?=
 =?us-ascii?Q?XnnFkOVceMracsNEY/34e1YlgjmmsJaJT9z3JwukgSStKx2yLd2p45/3dFnn?=
 =?us-ascii?Q?iZhpOl4huNOaiSWzhsWEKwbHp5N7wgthpMvQ/Uu1Vhygc2SplPQN3Vlc7UGo?=
 =?us-ascii?Q?UxFv9YgC9sX8XcJcwbMS8YMy0K0E1nyF6CVQpwIwwIMUgSNdWNgidoMNms1k?=
 =?us-ascii?Q?OENmvZtCOxPSNbyzTtmPxsLBnd2v4qI1s2+f2X7I0M0E/yZMooDAWT9+xOL2?=
 =?us-ascii?Q?r6f+tckc6tRbVxEt/HywyEsr0m0gbf53xqPGA3WIUxn/2otmopqIJQrr41RM?=
 =?us-ascii?Q?8OXg/Z2AVX8ltg02+y1TUa34mHzGjZwAkS6q283jBsOdkKMkfnomw51qBEMO?=
 =?us-ascii?Q?iZYDgT4tN+VJ2cRRTp+3WrECIMfelH6cMav7m6wz9yxfg5kgLbxn2n6N0mx8?=
 =?us-ascii?Q?UhKc8ENlwel+Pdjf2x2mvfldR9lLE0L/xaMamcFWvEfUW3D2uIOcNnbkTaHB?=
 =?us-ascii?Q?nKsC91YcqT3Ri4NkdWPqaF6lHY9WgUxmvd7ZJyPKCgHKkhrjBzJhGxwurNid?=
 =?us-ascii?Q?Fj5I/8Fy2NHEq5Y8T3y2j8YqaMfyDqiC4LfqnwylC9xxOSgb/cjn6ByVpTYl?=
 =?us-ascii?Q?QdD6cymOmbZ1XSrPLS8ajtLEYsb9Y7wtpnAjxg6mvBn9FWTlVGld8zcJku6J?=
 =?us-ascii?Q?nM0UqLZMh+sdrdys8Hf9+vvLBpmnPI4TwLCKpVj07f1QF7W1t7l5xJYZZ0JI?=
 =?us-ascii?Q?5kugEXZmORTabkmVfhBglj6S/FgINJFSac7P3wLo+SIq+XPBc0YlF5FF3PQF?=
 =?us-ascii?Q?J1WBHeAM3Cce7o99KIp4yR1d3XxSYBrxezeDI6zWE1JszEtQWBeTH2SN3drs?=
 =?us-ascii?Q?j2YoG1N8Qt9BdjnW8RpPbpHw1e4glFaFnSvaVAKUNAf/QclSKSLZGafZOBo/?=
 =?us-ascii?Q?LodZGmGlt5uSUuMmXcPeDAFUHo6nV93K+Arxed9XMSS5txFK18NtqQeMRu+C?=
 =?us-ascii?Q?CZw/JR7Syx/MSqk25P1xK1bxzsyRvYdU7+IULJ1QWsH30RrdTKejcav2nk9N?=
 =?us-ascii?Q?ZrNBCoYR+Cjd8C62mHaGLWjebXhYhyXl64JaLSS60HpSQbS1peNbJKGVpWyR?=
 =?us-ascii?Q?8N1I4cBJsABZMH4pxsiIoGRuM84vQ9PWlwqdkAncw+G6ifqgYsy0lG2aOtd5?=
 =?us-ascii?Q?y/1HfgA2VpY0WEUiIQ4NUEnrcnj0QFciMnLcTaTzrU5Bvja8sjR6CvZ90VNX?=
 =?us-ascii?Q?XqmZLENobMBsNDHzAWM6fazDM+z4B5Iw7e+76WZFHTEISJCaTS8GSOr2wvNd?=
 =?us-ascii?Q?iSBg8ZFF10Q0J9BOGbeZwB4fPrNWY3wnxMy/CsKrR2p5oUDSnfSVBaqmSyb+?=
 =?us-ascii?Q?S0Pa8eUgPqIh58qAKyTmzq877ymtq/moUcAzUqVkkFMhDl9sjxPy/tZKOtma?=
 =?us-ascii?Q?hQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0584b2e0-d5aa-49b9-d977-08da64c02da9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2022 11:09:39.2544
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i0DofWAHfVHXvc2xm2yz7IFaSqsRT/PMkAQlTcyUjI6cB0W2JyJE9UsfOE+HbKlt5JwqTGn6QRxkseH+5WlTXRbYt8xazSxuE5+im77miMY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6076
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-13_02:2022-07-13,2022-07-12 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207130046
X-Proofpoint-ORIG-GUID: NeNlqZZhLBeCOuUL9nK5Nwe_r3b9vicW
X-Proofpoint-GUID: NeNlqZZhLBeCOuUL9nK5Nwe_r3b9vicW
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 12, 2022 at 02:19:28PM -0400, Joel Slebodnick wrote:
> @@ -3264,27 +3260,25 @@ release_message_sync(struct vchiq_state *state, struct vchiq_header *header)
>  	remote_event_signal(&state->remote->sync_release);
>  }
>  
> -enum vchiq_status
> +int
>  vchiq_get_peer_version(unsigned int handle, short *peer_version)
>  {
> -	enum vchiq_status status = VCHIQ_ERROR;
> +	int status = -EINVAL;
>  	struct vchiq_service *service = find_service_by_handle(handle);
>  
>  	if (!service)
>  		goto exit;
>  
> -	if (vchiq_check_service(service) != VCHIQ_SUCCESS)
> +	if (vchiq_check_service(service))
>  		goto exit;
>  
>  	if (!peer_version)
>  		goto exit;
>  
>  	*peer_version = service->peer_version;
> -	status = VCHIQ_SUCCESS;
> +	status = 0;
>  
>  exit:
> -	if (service)
> -		vchiq_service_put(service);

Too aggressive with the delete key.

>  	return status;
>  }

regards,
dan carpenter