Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220713123922.2284522-1-vamshigajjela@google.com>
In-Reply-To: <20220713123922.2284522-1-vamshigajjela@google.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 13 Jul 2022 14:51:25 +0200
Message-ID: <CAHp75Vf8fOpyp0R+D5w0gYeVTAUOa+Qnb=16bT9LnpjyUk-JSg@mail.gmail.com>
Subject: Re: [PATCH v2] serial: 8250_dw: Avoid pslverr on reading empty
 receiver fifo
To:     Vamshi Gajjela <vamshigajjela@google.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Phil Edworthy <phil.edworthy@renesas.com>,
        Emil Renner Berthing <kernel@esmil.dk>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Johan Hovold <johan@kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Manu Gautam <manugautam@google.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jul 13, 2022 at 2:43 PM Vamshi Gajjela <vamshigajjela@google.com> wrote:
>
> From: VAMSHI GAJJELA <vamshigajjela@google.com>
>
> With PSLVERR_RESP_EN parameter set to 1, the device generates an error
> response when an attempt to read an empty RBR with FIFO enabled.
>
> This happens when LCR writes are ignored when UART is busy.
> dw8250_check_lcr() in retries to update LCR, invokes dw8250_force_idle()
> to clear and reset FIFO and eventually reads UART_RX causing the error.
>
> Avoid this by not reading RBR/UART_RX when no data is available.

Thanks for an update!
My comments below.

...

> +       /*
> +        * With PSLVERR_RESP_EN parameter set to 1, the device generates an
> +        * error response when an attempt to read empty RBR with FIFO enabled.

an empty

> +        */
> +       lsr = p->serial_in(p, UART_LSR);

I have just noticed that you do it independently on FIFO enablement.

> +       if ((up->fcr & UART_FCR_ENABLE_FIFO) && !(lsr & UART_LSR_DR))
> +               return;

I would recommend to move it inside the conditional

  if (fcr & FIFO) {
    lsr = ...
    if (!(lsr &))
      return;
  }

-- 
With Best Regards,
Andy Shevchenko