Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 13 Jul 2022 14:41:50 +0100
Message-ID: <8735f5165d.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Robert Marko <robimarko@gmail.com>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-arm-msm <linux-arm-msm@vger.kernel.org>,
        linux-gpio@vger.kernel.org,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: qcom: spmi-gpio: make the irqchip immutable
In-Reply-To: <CAOX2RU5k0UJiJ7o3ULjLVLUO=cchT_Azdvzs5FKdjXLX1_muOQ@mail.gmail.com>
References: <20220624195112.894916-1-robimarko@gmail.com>
        <87edyq1ujr.wl-maz@kernel.org>
        <20220712124445.GC21746@workstation>
        <87czea1i2f.wl-maz@kernel.org>
        <CAOX2RU5RX+H=omuKGye2fBy9dOFmfC9HC_3pekeGMxDJuReCUw@mail.gmail.com>
        <d8912a0d811b5eb924b8c4136b099f72@kernel.org>
        <CAOX2RU4MpyEQ0RtcrZ07VXRbB+SWWU=1zWfYUXhQFtvh=MCiDw@mail.gmail.com>
        <874jzl17lc.wl-maz@kernel.org>
        <CAOX2RU5k0UJiJ7o3ULjLVLUO=cchT_Azdvzs5FKdjXLX1_muOQ@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 13 Jul 2022 14:34:46 +0100,
Robert Marko <robimarko@gmail.com> wrote:
> 
> On Wed, 13 Jul 2022 at 15:10, Marc Zyngier <maz@kernel.org> wrote:
> >
> > On Wed, 13 Jul 2022 13:33:32 +0100,
> > Robert Marko <robimarko@gmail.com> wrote:
> > >
> > > On Wed, 13 Jul 2022 at 13:47, Marc Zyngier <maz@kernel.org> wrote:
> > > >
> > > > On 2022-07-13 12:08, Robert Marko wrote:
> > > > > I will look at IRQ GPIO docs, but in this case, then we have more
> > > > > conversions that
> > > > > are not correct.
> > > >
> > > > Then please point them out.
> > >
> > > Oh, now I get the issue, I was misunderstanding it completely.
> > > gpiochip_enable_irq and gpiochip_disable_irq are not being called
> > > at all.
> > >
> > > However, I dont see them being called before the conversion as well.
> > > I am not really familiar with the PMIC IRQ-s, looked like an easy conversion
> > > to get rid of the warning.
> >
> > They definitely were. Look at how gpiochip_add_data() eventually ends
> > up calling gpiochip_set_irq_hooks((), which hijacks the irq_chip
> > function pointers to insert the calls to these helpers.
> 
> Well, that is the thing, since irqchip->irq_enable and
> irqchip->irq_disable were never populated in the SPMI GPIO driver,
> gpiochip_set_irq_hooks then does not insert them.
> During runtime, gpiochip_irq_enable and gpiochip_irq_disable are
> never used even before the conversion, that is what I am trying to
> convey.

It is the mask/unmask versions that would be used, with similar
effects.

	M.

-- 
Without deviation from the norm, progress is not possible.